Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Prolog constraints isn't deprecated - they doesn't exist anyone #6123

Closed
1 task
asvishnyakov opened this issue Feb 9, 2024 · 4 comments
Closed
1 task
Labels
bug Something isn't working

Comments

@asvishnyakov
Copy link

Self-service

  • I'd be willing to implement a fix

Describe the bug

Yarn doesn't take into account engines: node from package.json regardless enableConstraintsChecks. This is because this contstraints wasn't "deprecated" as said here, they was completely removed.

To reproduce

  1. Clone project with engines: node in package.json
  2. Run yarn 4.x

Environment

System:
    OS: Windows 11 10.0.22631
    CPU: (8) x64 Intel(R) Core(TM) i7-2670QM CPU @ 2.20GHz
  Binaries:
    Node: 20.11.0 - C:\Users\ALEKSA~1\AppData\Local\Temp\xfs-2d7894a2\node.CMD
    Yarn: 4.0.2 - C:\Users\ALEKSA~1\AppData\Local\Temp\xfs-2d7894a2\yarn.CMD
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD

Additional context

No response

@asvishnyakov asvishnyakov added the bug Something isn't working label Feb 9, 2024
@merceyz
Copy link
Member

merceyz commented Feb 9, 2024

The constraints it's referring to is https://yarnpkg.com/features/constraints, not the engines field.

@arcanis arcanis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
@asvishnyakov
Copy link
Author

@merceyz @arcanis But engines worked on yarn 3.x and doesn't work on yarn 4.x. Why?

@merceyz
Copy link
Member

merceyz commented Feb 9, 2024

That's surprising to see as we never implemented it, see #1177.

@asvishnyakov
Copy link
Author

@merceyz Wow! Just installed yarn 3.x and it doesn't appear. So it's really surprising and means something did it "on behalf" of yarn. Really interesting. Thank you for the information and sorry for inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants