Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] packageExtensions not being applied correctly #2351

Closed
1 task done
ganemone opened this issue Jan 8, 2021 · 1 comment
Closed
1 task done

[Bug] packageExtensions not being applied correctly #2351

ganemone opened this issue Jan 8, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ganemone
Copy link
Contributor

ganemone commented Jan 8, 2021

  • I'd be willing to implement a fix

Describe the bug

A potential bug with handling package extensions was introduced in this commit. I believe the changes were intended to be refactoring, but not changing behavior of packageExtensions. However, the behavior is now different in certain edge cases. I believe the edge case occurs when a packageExtension is active for one package, but redundant in another.

To Reproduce

See https://github.com/ganemone/yarn-bug/tree/main

@ganemone ganemone added the bug Something isn't working label Jan 8, 2021
@merceyz
Copy link
Member

merceyz commented Jan 8, 2021

You're running into the final point here #2091 (comment), use resolutions to override existing dependency versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants