Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]v1 lockfile patterns issue with "@xxx/xxx" packages in Taobao registry #2220

Open
wuyiw opened this issue Dec 8, 2020 · 0 comments
Open
Assignees
Labels
bug Something isn't working upholded Real issues without formal reproduction

Comments

@wuyiw
Copy link

wuyiw commented Dec 8, 2020

Describe the bug

In LegacyMigrationResolver.ts pattern for custom registries like Taobao is:

// Note: /download/ is used by custom registries like Taobao
[/^https?:\/\/[^/]+\/(?:[^/]+\/)*(?:@[^/]+\/)?([^/]+)\/(?:-|download)\/\1-[^/]+\.tgz(?:#|$)/, version => `npm:${version}`],

this pattern fails to match packages like @types/chrome with the link:
https://registry.npm.taobao.org/@types/chrome/download/@types/chrome-0.0.51.tgz#173174baf8e801fe51d1d07e58c11044c74d2b8c
because @types is put in a non-capturing group hence not referenced later when it should be.

Environment:

  • Yarn version 2.4.0
@wuyiw wuyiw added the bug Something isn't working label Dec 8, 2020
@paul-soporan paul-soporan added the upholded Real issues without formal reproduction label Dec 8, 2020
@paul-soporan paul-soporan self-assigned this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upholded Real issues without formal reproduction
Projects
None yet
Development

No branches or pull requests

2 participants