.count misbehaves with hyphenated flags

[kahlil]

If I do something like this:

var opts = require('yargs')
    .count('log-level')
    .alias('l', 'log-level')
    .argv;

console.log(opts);

And pass -lll yargs will always count 2 no matter what. If I use loglevel as the main name of the flag it counts them correctly.

[bcoe]

Hey @kahlil what version of yargs are you running, I can't seem to reproduce:

#!/usr/bin/env node

var opts = require('./')
    .count('log-level')
    .alias('l', 'log-level')
    .argv;

console.log(opts);

Benjamins-MacBook-Pro:yargs benjamincoe$ ./test.js -llll
{ _: [], l: 4, 'log-level': 4, logLevel: 4, '$0': 'test.js' }

[phated]

Sorry, this is probably related to gulp-cli, which is on a super old version (1.3.3). I am working on updating it now.

[phated]

Ref #78

[kahlil]

Oops, @phated is right. I did not check the version! Sorry for this 🙏

[nexdrew]

Closing based on previous comments. If you find another problem, please open a new issue. Thanks!

[hildjj]

With version 3.30.0:

var argv = require('yargs')
.options({
  verbose: {
    description: 'Verbose output',
    boolean:     true,
    count:       true,
    alias:       'v'
  }
}).argv;

console.log(argv.verbose);  // outputs 2+count(v)

With .options, the count is always 2 more than it should be. Using:

var argv = require('yargs')
    .count('verbose')
    .alias('v', 'verbose')
    .argv;

everything seems to work fine.

[hildjj]

Actually, it's the boolean: true that's causing the issue, not .options.

[nexdrew]

@hildjj Thanks for pointing this out! count is just a special form of boolean, so the boolean part is superfluous/unnecessary.

[hildjj]

Perhaps a warning/error, then, if you specify both? Starting the count at 2 was unexpected behavior.

[nexdrew]

@hildjj Agreed. Would you mind creating a new ticket for that?