Downgrades strip-ansi to version 3.0.1 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts 185a77e
|
@realityking it would be good for us to figure out what the heck changed. Looking at the failing tests it looks like we introduced a new newline potentially? I bet something is happening on the string boundaries. |
|
@bcoe I agree figuring out what changed would be good. Unfortunately I can't reproduce it locally which makes testing rather hard. IMHO it'd still be good to merge this to get master back to a working state. |
|
BTW, tests on this branch passed. Somehow Travis is not reporting the status to GitHub. |
|
Tests are still failing, I'll prepare another patch reverting |
bcoe
pushed a commit
that referenced
this pull request
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts 185a77e
It's a guess but I think this is the package that broke it🤞