-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close when user clicks off modal (on overlay) #24
Comments
Yes, it's easy to do today. See the examples in the dummy app to learn how. |
Where exactly is it in the dummy app? I couldn't find it. Thank you! |
@oskarrough You're right this was hard to find:
If you want to override this sucker, look here:
And do something similar as suggested in the README for Keyboard Shortcuts |
@theworkerant / @oskarrough sorry this was tough to understand. Can one of you submit a PR that would make it easier to grok for a developer new to the project? |
@lukemelia I think the issue is that the documentation doesn't clearly specify how the close action is triggered, I made a PR to fix that. If the close action is sent from other places besides clicking the overlay let me know, I can clarify further. |
Thank you @pzurag, helped me! |
Is there a way to do this already? If not we can add it pretty quickly, seems like pretty general behavior.
The text was updated successfully, but these errors were encountered: