Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close when user clicks off modal (on overlay) #24

Closed
pzuraq opened this issue Apr 27, 2015 · 6 comments
Closed

Close when user clicks off modal (on overlay) #24

pzuraq opened this issue Apr 27, 2015 · 6 comments

Comments

@pzuraq
Copy link

pzuraq commented Apr 27, 2015

Is there a way to do this already? If not we can add it pretty quickly, seems like pretty general behavior.

@lukemelia
Copy link
Contributor

Yes, it's easy to do today. See the examples in the dummy app to learn how.

@oskarrough
Copy link

Where exactly is it in the dummy app? I couldn't find it. Thank you!

@theworkerant
Copy link

@oskarrough You're right this was hard to find:

<div {{bind-attr class="overlayClassNamesString translucentOverlay:translucent overlay-class"}} {{action 'close'}}></div>

If you want to override this sucker, look here:

And do something similar as suggested in the README for Keyboard Shortcuts

@lukemelia
Copy link
Contributor

@theworkerant / @oskarrough sorry this was tough to understand. Can one of you submit a PR that would make it easier to grok for a developer new to the project?

@pzuraq
Copy link
Author

pzuraq commented May 15, 2015

@lukemelia I think the issue is that the documentation doesn't clearly specify how the close action is triggered, I made a PR to fix that. If the close action is sent from other places besides clicking the overlay let me know, I can clarify further.

@oskarrough
Copy link

Thank you @pzurag, helped me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants