Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile with Nginx 1.21.1 #51

Open
ip6li opened this issue Jul 8, 2021 · 6 comments · May be fixed by #52
Open

Does not compile with Nginx 1.21.1 #51

ip6li opened this issue Jul 8, 2021 · 6 comments · May be fixed by #52

Comments

@ip6li
Copy link

ip6li commented Jul 8, 2021

Compiler complains with:

nginx_ajp_module/ngx_http_ajp.c:140:29: Fehler: »ngx_http_request_t« {alias »struct ngx_http_request_s«} hat kein Element namens »space_in_uri«; meinten Sie »plus_in_uri«?
     if (r->quoted_uri || r->space_in_uri || r->internal) {
                             ^~~~~~~~~~~~
                             plus_in_uri
@FraPazGal
Copy link

Hello,

Is there any update on this? The compilation is failing with the following error:

ngx_http_ajp.c: In function 'sc_for_req_get_uri':
ngx_http_ajp.c:139:29: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'space_in_uri'; did you mean 'plus_in_uri'?
     if (r->quoted_uri || r->space_in_uri || r->internal) {
                             ^~~~~~~~~~~~
                             plus_in_uri
make[1]: *** [objs/Makefile:2251: objs/addon/nginx-module-ajp-0.20200326.0/ngx_http_ajp.o] Error 1

The error should be related to the changes performed in the latest NGINX version `1.21.1:

nginx/nginx@release-1.21.0...release-1.21.1

@ip6li
Copy link
Author

ip6li commented Aug 23, 2021

This one is outdated, see https://github.com/dvershinin/nginx_ajp_module

@ssticsistemas
Copy link

Hi,
same error and my solution with updated project:
in file ngx_http_ajp.c, line 139: if (r->quoted_uri || r->space_in_uri || r->internal) {
replace with: if (r->quoted_uri || r->plus_in_uri || r->internal) {
and rerun ./configure, make and make install
working correctly

@tao12345666333
Copy link

Hi, same error and my solution with updated project: in file ngx_http_ajp.c, line 139: if (r->quoted_uri || r->space_in_uri || r->internal) { replace with: if (r->quoted_uri || r->plus_in_uri || r->internal) { and rerun ./configure, make and make install working correctly

In fact this behavior is inconsistent. You can just delete it.

- if (r->quoted_uri || r->space_in_uri || r->internal) {
+ if (r->quoted_uri || r->internal) {

space_in_uri is to handle some bad clients, but it's not necessary now

@yaoweibin
Copy link
Owner

yaoweibin commented Oct 26, 2022 via email

@tao12345666333
Copy link

Sure!

@tao12345666333 tao12345666333 linked a pull request Dec 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants