fix: missing fs/promises patches to resolve Not found error
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
robertsLando
changed the title
Not found errorfs/promises patches to resolve Not found error
kuema
reviewed
Feb 11, 2025
| fs.promises.read = util.promisify(fs.read); | ||
| fs.promises.realpath = util.promisify(fs.realpath); | ||
| fs.promises.fstat = util.promisify(fs.fstat); | ||
| fs.promises.statfs = util.promisify(fs.fstat); |
There was a problem hiding this comment.
I think there's a copy-paste error here.
Shouldn't this be: fs.promises.statfs = util.promisify(fs.statfs);
I recently updated to pkg v6 and my statfs calls are giving the following error, because actually fstat is called instead.
TypeError: The "fd" argument must be of type number. Received type string ('/')
There was a problem hiding this comment.
Thanks for highlight this. Just submitted a commit on master to fix this
There was a problem hiding this comment.
Thanks for fixing and releasing.
statfs is working again with v6.3.1 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accessandrealpathpatches were missing