Improve jsx-closing-bracket-location error message #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding expected column information for the closing bracket, as well
as reporting the error at the closing bracket instead of the opening
bracket. Parsing the error message should now be sufficient to allow
writing an external autofixer.
Example input
test.jsx
with default options:Resulting error:
test.jsx:2:10: Ereact/jsx-closing-bracket-location The closing bracket must be aligned with the opening tag (expected column 1 on the next line)
Note that the reported error location now corresponds to the closing
>
bracket on line 2, and that the error message now includes the exact location of where that closing bracket should have been.Test Plan:
npm install
npm run test