Add allowed strings, jsx-no-literals

[benhollander]

No description provided.

[benhollander]

@ljharb I've updated my branch to reflect the changes you suggested

[cainlevy]

I'd love to use this. Is there a timeline for new releases?

[ljharb]

v7.15.0 is released.

[cainlevy]

@benhollander is this working as you hoped? we're also dealing with   (and other punctuation) but the allowedStrings option seems to be confounded by leading or trailing whitespace.

[benhollander]

@cainlevy it does work for my use case, but I can see that this line doesn't take whitespace into account, since it's doing a straight string comparison.

Options:

1. We could make that function strip whitespace from node.value before comparing it to the list of strings coming from the config. That would likely result in some results that users might not expect.
2. We could all for passing a regex instead of a straight string. That seems like it would result in false positives/negatives if people didn't write perfect regexes, which seems likely to me.

Other ideas?

[cainlevy]

1. My first instinct for the immediate issue is also trim. Can you say more about a situation where it might be surprising?

   It's worth noting here that the error message trims the value, which creates confusion about what should be added to allowedStrings. For example, this error message from my project was not fixed by adding allowedStrings: [" "]:

   Missing JSX expression container around literal string: “ ”         react/jsx-no-literals
   

2. We're migrating from tslint. The equivalent rule there is jsx-use-translation-function and its options are allow-punctuation and allow-htmlentities. Those options trade abstractness for usability and may take care of most of what people want from allowedStrings and allowedRegexps with less fiddling. Thoughts?