Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-handler-names triggers when using ES7 bind operator. #630

Closed
rodoabad opened this issue Jun 10, 2016 · 4 comments
Closed

jsx-handler-names triggers when using ES7 bind operator. #630

rodoabad opened this issue Jun 10, 2016 · 4 comments
Labels

Comments

@rodoabad
Copy link

rodoabad commented Jun 10, 2016

Example:

onClick={props::handleCreateDealerHistoryReportClick}

Which is the same as handleCreateDealerHistoryReportClick.bind(props) assuming this is props in a stateless function component.

@ljharb
Copy link
Member

ljharb commented Jun 10, 2016

That should actually be erroring out on the jsx-no-bind rule :-p but this should still be fixed.

@rodoabad
Copy link
Author

@ljharb if you have jsx-no-bind turned off and have jsx-handler-names turned on this will error out.

@ljharb ljharb added the bug label Jun 10, 2016
@rodoabad
Copy link
Author

@evcohen did you submit a PR for this?

@beefancohen
Copy link
Contributor

@rodoabad I PR'ed for reporting error on jsx-no-bind using ES7 bind operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants