Fix error caused by templates in ConditionalExpressions (jsx-indent) #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template strings are constructed differently from other tokens in
espree. Other tokens are created by the Token class and are thus
Token class objects. They look like this:
```
Token {
type: 'String',
value: '"bar"',
start: 44,
end: 49,
loc:
SourceLocation {
start: Position { line: 4, column: 11 },
end: Position { line: 4, column: 16 } },
range: [ 44, 49 ] }
```
Template tokens, however, are constructed differently and end up as
plain JavaScript objects, which look like this:
```
{ type: 'Template',
value: '`bar`',
loc:
{ start: Position { line: 4, column: 11 },
end: Position { line: 4, column: 16 } },
range: [ 44, 49 ] }
```
See: [espree's token-translator.js](https://github.com/eslint/espree/blob/58f75be6b89d8904b6366ed368045cb02c4a4e33/lib/token-translator.js#L43)
As a result of this different construction, the `start` and `end`
properties are not present on the template token object. To correct this
I've changed to using the `range` property, which I infer to be more
proper given the method it is being passed into is called
`getNodeByRangeIndex`. I also think we can safely rely on `range` being
present on all token types.
Fixes jsx-eslint#1061
ljharb
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template strings are constructed differently from other tokens in espree. Other tokens are created by the Token class and are thus Token class objects. They look like this:
Template tokens, however, are constructed differently and end up as plain JavaScript objects, which look like this:
See: espree's token-translator.js
As a result of this different construction, the
startandendproperties are not present on the template token object. To correct this I've changed to using therangeproperty, which I infer to be more proper given the method it is being passed into is calledgetNodeByRangeIndex. I also think we can safely rely onrangebeing present on all token types.Fixes #1061