Review comments

jsx-eslint · Nov 22, 2017 · 7def79f · 7def79f
1 parent c8ee193
commit 7def79f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/rules/jsx-child-element-spacing.js b/lib/rules/jsx-child-element-spacing.js
@@ -1,6 +1,7 @@
 'use strict';
 
-const INLINE_ELEMENTS = [
+// This list is taken from https://developer.mozilla.org/en-US/docs/Web/HTML/Inline_elements
+const INLINE_ELEMENTS = new Set([
   'a',
   'abbr',
   'acronym',
@@ -32,7 +33,7 @@ const INLINE_ELEMENTS = [
   'textarea',
   'tt',
   'var'
-];
+]);
 
 module.exports = {
   meta: {
@@ -61,7 +62,7 @@ module.exports = {
 
     const isInlineElement = node => (
       node.type === 'JSXElement' &&
-      INLINE_ELEMENTS.indexOf(elementName(node)) !== -1
+      INLINE_ELEMENTS.has(elementName(node))
     );
 
     const TEXT_FOLLOWING_ELEMENT_PATTERN = /^\s*\n\s*\S/;