Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE-T feature channels not reduced after forward()? #15

Open
lcxrocks opened this issue Oct 22, 2024 · 0 comments
Open

APE-T feature channels not reduced after forward()? #15

lcxrocks opened this issue Oct 22, 2024 · 0 comments

Comments

@lcxrocks
Copy link

First, thank the authors for their valuable contribution to the community!

In the paper, the learned residual is added to the refined training images cache F', and the affinity matrix is computed between f' and F', as described in equation (13) and beyond.

However, I noticed a small discrepancy between the paper and the code. In the code, the selected Q channels are only modified, not extracted as described in the paper.

Here's the relevant code:

APE/utils.py

Line 132 in 70460de

new_cache_keys[:, self.indices] = new_cache_keys[:, self.indices] + res_keys

Could this be due to a misunderstanding on my part, or is there an intentional reason for this difference? Thank you for your time in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant