Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Search link for Khan Academy is broken #601

Open
iamtburger opened this issue Aug 27, 2023 · 4 comments
Open

Binary Search link for Khan Academy is broken #601

iamtburger opened this issue Aug 27, 2023 · 4 comments

Comments

@iamtburger
Copy link
Contributor

Hi,

The link for Khan Academy - Binary Search is broken on the following page:
https://www.techinterviewhandbook.org/algorithms/sorting-searching/

URL on the page
Actual working URL

I'm happy to fix it if that's ok.

@yangshun
Copy link
Owner

Yes please submit a PR

@iamtburger
Copy link
Contributor Author

What should be the [project] for the commit message?

@yangshun
Copy link
Owner

@iamtburger don't worry about it, I'll change it before merging. I think you can use fix:

@iamtburger
Copy link
Contributor Author

Thanks! I opened the PR.
Funny thing is, if you delete the / from the URL (the one which was already on in the Handbook) you don't land on the Ooops page, but the Algorithms main page. I changed the URL to point at the exact location of Binary Search, but still had to omit the / from the end to prevent landing on Page not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants