Fix bulk move of issues and replace cakeError to Exceptions #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 2.0 of CakePHP using cakeError() should be replaced with throwing Exceptions (http://book.cakephp.org/2.0/en/development/errors.html). List of available exceptions: http://book.cakephp.org/2.0/en/development/exceptions.html#built-in-exceptions-for-cakephp This fixes: #278
Request for bulk move contains "ids" query parameter, so code finding issue ids should also scan this parameter. This fixes #279
Move.ctp should not provide issue_id param as it can handle multiple issues at once. All issues are already included as hidden inputs in form. (cherry picked from commit 3d056a6ba79f9e96e9d81e4bcc472902f5ebdc0f)
Tracker field should not be required as user can select "No change" which is treated as none and blocks form submit (cherry picked from commit 6dd815f1dc2d28587e70be34bd4fdffa6b48d72c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for bulk move contains "ids" query parameter, so code finding
issue ids should also scan this parameter.
This fixes #279
Replace cakeError method with throwing Exceptions.
Since version 2.0 of CakePHP using cakeError() should be replaced with
throwing Exceptions (http://book.cakephp.org/2.0/en/development/errors.html).
List of available exceptions:
http://book.cakephp.org/2.0/en/development/exceptions.html#built-in-exceptions-for-cakephp
This fixes #278