Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density option is broken. #162

Closed
Zirafnik opened this issue Apr 18, 2023 · 3 comments
Closed

Density option is broken. #162

Zirafnik opened this issue Apr 18, 2023 · 3 comments

Comments

@Zirafnik
Copy link

Density option has no effect on the final result.

I have flied through the library code and at first glance it seems that the problem is not on 'pdf2pic' end, as all the gm calls seem to be okay.

But none of the dependencies upstream report this issue. Not the node gm library we are using, and not the GraphicsMagick itself.

It would be great if somebody could test the gm dependency alone, and see if the problem is coming from there. If density works in gm, then the problem lies here.

@Zirafnik
Copy link
Author

Zirafnik commented Apr 19, 2023

I have tested the 'PDF2Pic' library manually, by inserting higher values, when setting gm settings, directly in the code.

public gmBaseCommand(stream: fs.ReadStream, filename: string): gm.State {
    return this.gm(stream, filename)
      .density(300, 300) // 300, instead of default 72
      ...

Unfortunatelly, still no luck. It appears the gm dependency or upwards must be broken.

@mskec
Copy link
Collaborator

mskec commented May 11, 2023

Hi @Zirafnik,

I tested different density options and I can see difference in the output.
Here is my test file mskec@161e7c8
I have [email protected].

@mskec
Copy link
Collaborator

mskec commented Jun 17, 2023

I'll close the issue. Feel free to submit more info if you think the problem is in pdf2pic.

@mskec mskec closed this as completed Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants