From 28667387a1f3db3427cf2ef9651cd1f2b612cfc7 Mon Sep 17 00:00:00 2001 From: Tim Sullivan Date: Wed, 29 Jun 2022 13:49:50 -0700 Subject: [PATCH] =?UTF-8?q?[reporting]=20functional=20test:=20increase=20a?= =?UTF-8?q?llowance=20for=20visual=20difference=E2=80=A6=20(#135356)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [reporting] functional test: increase allowance for visual difference in downloaded report * Revert "skip flaky suite (#135309)" This reverts commit b556857350d987d1adab928be92d491aa210c45f. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../reporting_functional/reporting_and_timeout/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/test/reporting_functional/reporting_and_timeout/index.ts b/x-pack/test/reporting_functional/reporting_and_timeout/index.ts index 9832f00675062..9e06e18072846 100644 --- a/x-pack/test/reporting_functional/reporting_and_timeout/index.ts +++ b/x-pack/test/reporting_functional/reporting_and_timeout/index.ts @@ -17,8 +17,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const browser = getService('browser'); const compareImages = getService('compareImages'); - // FLAKY: https://github.com/elastic/kibana/issues/135309 - describe.skip('Reporting Functional Tests with forced timeout', function () { + describe('Reporting Functional Tests with forced timeout', function () { const dashboardTitle = 'Ecom Dashboard Hidden Panel Titles'; const baselineAPng = path.resolve(__dirname, 'fixtures/baseline/warnings_capture_a.png'); const sessionPng = 'warnings_capture_session_a'; @@ -51,8 +50,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const captureData = await PageObjects.reporting.getRawPdfReportData(url); const pngSessionFilePath = await compareImages.writeToSessionFile(sessionPng, captureData); + // allow minor visual differences: https://github.com/elastic/kibana/issues/135309#issuecomment-1169095186 expect(await compareImages.checkIfPngsMatch(pngSessionFilePath, baselineAPng)).to.be.lessThan( - 0.01 + 0.011 ); }); });