Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/goroutine leak #7

Merged
merged 10 commits into from
Apr 20, 2024
Merged

Fix/goroutine leak #7

merged 10 commits into from
Apr 20, 2024

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Apr 19, 2024 •
edited
Loading

Fixes

  • close rpc client to fix goroutine leak.

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 19, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 19, 2024 •
edited
Loading

Here's the code health analysis summary for commits 1ed36a0..ec222e9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (1ed36a0) to head (ec222e9).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   87.29%   87.89%   +0.59%     
==========================================
  Files           9        9              
  Lines         425      446      +21     
==========================================
+ Hits          371      392      +21     
  Misses         35       35              
  Partials       19       19
Flag Coverage Δ
Unit-Tests 87.89% <100.00%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit a10bc58 into main Apr 20, 2024
8 checks passed
@cnlangzi cnlangzi deleted the fix/goroutine_leak branch April 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cnlangzi