Fix FormattedRelativeTime with high seconds values #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected: For an item with an age of 3 days, on initial load don't add the timer but do show "3 days ago" Actual: Item shows "1 day ago" now matter how old it is The FormattedRelativeTime intends to stop using a timer once it goes over one day. However, at the point it removes this timer it also fixes the value at one day, so the display can only ever be "1 day ago", which is incorrect. This fix removes the overriding of the current state value, but continues to bypass the timer. It also adds a test for this case (which was failing before the fix)
|
Thanks a lot for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects: v3.0.0-beta.20
Expected:
For an item with an age of 3 days, on initial load don't add the timer but do show "3 days ago"
Actual:
Item shows "1 day ago" now matter how old it is
The FormattedRelativeTime intends to stop using a timer once it goes over one day. However, at the point it removes this timer it also fixes the value at one day, so the display can only ever be "1 day ago", which is incorrect.
This fix removes the overriding of the current state value, but continues to bypass the timer. It also adds a test for this case (which was failing before the fix)