Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactflowProps.isValidConnection is missing EdgeType template parameter #4813

Open
julianbrummer-gip opened this issue Nov 14, 2024 · 1 comment

Comments

@julianbrummer-gip
Copy link

What platform were you using when you found the bug?

  • React Flow version: 12.3.5

Live code example

No response

Describe the Bug

// component-props.ts:
ReactflowProps<NodeType extends Node = Node, EdgeType extends Edge = Edge> {
    // ...
    isValidConnection?: IsValidConnection; // type should actually be IsValidConnection<EdgeType>
}

Steps to reproduce the bug or issue

Open component-props.ts

Expected behavior

// component-props.ts:
ReactflowProps<NodeType extends Node = Node, EdgeType extends Edge = Edge> {
    // ...
    isValidConnection?: IsValidConnection<EdgeType>;
}

Screenshots or Videos

No response

Additional context

No response

@moklick
Copy link
Member

moklick commented Nov 15, 2024

Thanks! This will be fixed with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants