Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theming support #17

Open
ggoodman opened this issue Nov 30, 2015 · 2 comments
Open

Add theming support #17

ggoodman opened this issue Nov 30, 2015 · 2 comments

Comments

@ggoodman
Copy link

Embedding this library in 0.1.x in a project with a modern build step was very easy and provided an opportunity to adjust and/or overwrite styles.

For example, I would like to use a different font-size and font-family. I don't think the library should be hard-coded with those sorts of decisions already made and set in stone.

For now I need to use !important rules but hope you consider an disableStyles or similar option and add relevant classNames back to nodes in the tree to facilitate 3rd party theming.

Cheers, great module!

@xyc
Copy link
Owner

xyc commented Dec 3, 2015

@ggoodman Inline styles are discussed in #4

  • disableInlineStyles could be an option
  • or add theme props for customization

For now, you can fork the repo and change inline styles.

@mathew-kurian
Copy link

@ggoodman +1. Currently using 9e06fc1 (npm 1.6). Great work however!

@xyc xyc changed the title Embedded styles have made it very difficult to theme Add theming support Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants