-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object is not abstract and does not implement abstract base class member public abstract fun describeContents(): Int #14
Comments
Hi. Thanks for the issue. Have you included the parcelize plugin on your module? This is required for android, just like any other android module |
Yes i tried with parcelize plugin , and different versions of the 'optional' (other) libraries as well but i get that issue. If i but @parcelize on the class itself i get , Object is not abstract and does not implement abstract base class member public abstract fun describeContents(): Int defined in some decompose package. As well as , I am unable to 'find' the methods given in the doc |
I see what the issue is. You should only need to annotate with @Parcelize
sealed class StoryHomeScreen: Parcelable {
object List: StoryHomeScreen()
data class Details(val section: TopStorySection, val uri: ArticleUri, val title: String): StoryHomeScreen()
} The documentation is wrong and I will use this issue to correct this. Thanks for pointing this out 👍 Hopefully the above fix works for you |
Thanks , that solved the issue and since you are fixing the README , maybe change val commonMain by getting {
dependencies {
implementation("io.github.xxfast:decompose-router:${versions.decompose-router}")
// You will probably need to also bring in decompose and essenty
implementation("com.arkivanov.decompose:decompose:${versions.decompose}")
implementation("com.arkivanov.decompose:extensions-compose-jetbrains:${versions.decompose}")
implementation("com.arkivanov.essenty:parcelable:${versions.essenty}")
}
} as the other libraries are needed else you can't use the router at all |
Yup will do |
I have just checked and the original code works for me just fine. I mean, |
yeah, you are right @arkivanov, I'm assuming the issue was an outdated cache prior to adding Nevertheless, I've update the readme (in #15) to go with the simpler approach of declaring |
I get error
Also the doc is lacking , i mean so push function for router
The text was updated successfully, but these errors were encountered: