-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropwizard UnitOfWork Guice Interceptor #42
Comments
Hi! |
this is actually quite amazing. Do you think it's feasible to add it into Guicey or a standalone example should be enough? @xvik |
nvm I thought I get it working in my test case... |
Ideally, it should be improved and become a guicey-ext module to simplify configuration. For now, there is only a basic hibernate example |
Hi,
This is my first submission to this project so allow me to begin by saying: Thank you for the awesome work.
Now, Dropwizard's
@UnitOfWork
only works on jersey resources by default. To get them to work for methods on classes that are not jersey resources, you have to manually instantiate such classes by running them throughUnitOfWorkAwareProxyFactory
. Example from Dropwizard docs:This of course goes against what we aspire to achieve by using a DI such as Guice.
Since guice has AOP I think this awesome bundle can ship optional support for
@UnitOfWork
outside resources, using Guice AOP.Here is an example of such Guice module (briefly tested and it works): https://stackoverflow.com/a/38267726/43597
It can even just be included in the Hibernate example in the docs. I'd be happy to provide a PR if this deems plausible.
The text was updated successfully, but these errors were encountered: