-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetConditionalStyle #1690
Comments
Thanks for your issue. I have just added support for getting the conditional format style definition, please upgrade to the master branch code, and this feature will be released in the next version. |
Dear Xuri,
thanks for fast reply. I have tested new lib and it works as my first
workaround. Problem is that field PatternFill.PatternType is an empty
string, and there is no mapping for it in styleFillPatterns. As a result I
got in the Style.Fill structure Pattern -1 and Color null. But in excel I
can see that the color is defined (it is background of the cell). So. I
didn't know better so I added additional check for empty string (in my
workaround) and assigned Pattern=1 in that case.
You certainly have better knowledge of excel file format, so maybe you can
prepare better solution.
Best wishes and many thanks, Franis Sirkovic.
…On Tue, Oct 17, 2023 at 3:21 AM xuri ***@***.***> wrote:
Thanks for your issue. I have just added support for getting the
conditional format style definition, please upgrade to the master branch
code, and this feature will be released in the next version.
—
Reply to this email directly, view it on GitHub
<#1690 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIRI3SKEOXYOWNZHKFYITX7XMTDAVCNFSM6AAAAAA55D67TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGUYDMMBZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks for your feedback. I have tested this with unit tests, and it works well. Are you opening an existing workbook that contains a conditional format style or creating a conditional format style on a new workbook with this library? Could you provide a file attachment without confidential info and a standalone demo to reproduce this? |
Dear Xuri,
here is linux executable and xlsx file. Utility is simple xlsx to json
converter. If you prefer I can send you a sources or windows exe.
Best wishes, Franis Sirkovic.
P.S. Just my curiosity, it seems to me that we are not in the same time
zone. I am from Croatia.
…On Wed, Oct 18, 2023 at 4:55 AM xuri ***@***.***> wrote:
Thanks for your feedback. I have tested this with unit tests, and it works
well. Are you opening an existing workbook that contains a conditional
format style or creating a conditional format style on a new workbook with
this library? Could you provide a file attachment without confidential info
and a standalone demo to reproduce this?
—
Reply to this email directly, view it on GitHub
<#1690 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIRI3LKF2Z63DCK4NJCGTX75AINAVCNFSM6AAAAAA55D67TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGUZTMNZRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I can't find your attachments in your reply, you can upload attachment to this issue, and show us a standalone reproducible source code demo. |
Dear Xuri,
here is windows version of utility.
Password for .7z file is win.
e2j.bin should be renamed to e2j.exe
Best wishes, Franis Sirkovic
…On Wed, Oct 18, 2023 at 4:55 AM xuri ***@***.***> wrote:
Thanks for your feedback. I have tested this with unit tests, and it works
well. Are you opening an existing workbook that contains a conditional
format style or creating a conditional format style on a new workbook with
this library? Could you provide a file attachment without confidential info
and a standalone demo to reproduce this?
—
Reply to this email directly, view it on GitHub
<#1690 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIRI3LKF2Z63DCK4NJCGTX75AINAVCNFSM6AAAAAA55D67TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGUZTMNZRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I still can't find your attachments in your reply, could you upload it by webpage instead of reply by email? In addition, please show us a standalone reproducible source code demo instead of binary files. |
Here is xlsx file and source files of utility. |
I have used webpage to send you xlsx file and sources.
…On Wed, Oct 18, 2023 at 10:13 AM xuri ***@***.***> wrote:
I still can't find your attachments in your reply, could you upload it by
webpage instead of reply by email? In addition, please show us a standalone
reproducible source code demo instead of binary files.
—
Reply to this email directly, view it on GitHub
<#1690 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIRI3BP5ZDL3VRPJ7IHMLX76FT3AVCNFSM6AAAAAA55D67TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXHEZDAMZRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have made some changes to resolve this issue, please try to upgrade the master branch code. This change will be released in the next version. |
It works perfectly for my case. Thanks for help. Best wishes, Franis Sirkovic. |
- Support get the conditional format style definition - Update the unit test
- Improve compatibility with the viewer which doesn't support default theme part namespace - ref qax-os#1690, support read background color style, and conditional format with default pattern type - Update the unit tests
Description
I am very satisfied with excelize lib. As far as I can see all functions come in get/set pairs, for example NewStyle()/GetStyle(). But I have found one exception: there is only NewConditionalStyle() function. There are no GetConditionalStyle() function. So, it makes conditional styles something like write only memory (register). And, of course, I need GetConditionalStyle() function. I can't find style for conditionally highlighted cells.
I would appreciate if you can add it.
In the meantime I have found ugly workaround, I am accessing file.Styles.Dxfs.Dxfs directly.
Best wishes, Franis Sirkovic.
The text was updated successfully, but these errors were encountered: