Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domrender not using isCursorInitialized #4790

Closed
tisilent opened this issue Sep 12, 2023 · 2 comments · Fixed by #4798
Closed

Domrender not using isCursorInitialized #4790

tisilent opened this issue Sep 12, 2023 · 2 comments · Fixed by #4798
Assignees
@Tyriar
Labels
area/renderer-dom help wanted
Milestone
5.4.0

Comments

@tisilent
Copy link
Contributor

on vscode
step:

  1. using webgl render
  2. create new terminal
  3. reload window
    terminal do not display cursor

step:

  1. using dom render
  2. create new terminal
  3. reload window
    terminal display cursor
@tisilent
Copy link
Contributor Author

I'm not sure that kind of behavior is correct.

@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2023

Yep the cursor is not meant to show at all until it's focused. We should be able to craft a regression test that covers this too 👍

@tisilent tisilent mentioned this issue Sep 13, 2023
Merged
@Tyriar Tyriar added this to the 5.4.0 milestone Sep 14, 2023
@Tyriar Tyriar self-assigned this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/renderer-dom help wanted
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

using isCursorInitialized for domrenderer tisilent/xterm.js
2 participants
@Tyriar @tisilent