Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Buffer.iterator #4331

Closed
jerch opened this issue Dec 19, 2022 · 1 comment · Fixed by #4335
Closed

Remove Buffer.iterator #4331

jerch opened this issue Dec 19, 2022 · 1 comment · Fixed by #4335
Labels
type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@jerch
Copy link
Member

jerch commented Dec 19, 2022

@Tyriar

Since the old linkifier is gone, Buffer.iterator (and subsequentially BufferStringIterator and Buffer.stringIndexToBufferIndex) is not used by any code anymore. I think it can be removed. Also it is not exposed to outside, furthermore I think that this Java-ish iterator was not the best idea. (In case we want a similar feature in the future, maybe it could be achieved more idiomatic by a generator pattern.)

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2022

Nice 👍. I think this was added before browsers supported generators well, or at least before I knew we were clear to use them.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Dec 19, 2022
@Tyriar Tyriar added this to the 5.2.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants