Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerline symbols don't support letter spacing on webgl #3969

Closed
Tyriar opened this issue Jul 30, 2022 · 1 comment · Fixed by #3985
Closed

Powerline symbols don't support letter spacing on webgl #3969

Tyriar opened this issue Jul 30, 2022 · 1 comment · Fixed by #3985
Assignees
@Tyriar
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 30, 2022

Webgl:

image

Canvas:

image
@Tyriar Tyriar added type/bug Something is misbehaving area/addon/webgl labels Jul 30, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Jul 31, 2022
@Tyriar Tyriar self-assigned this Jul 31, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jul 31, 2022

This was tough to track down. It ended up being because of the pixel clipping when background color changes not being letter spacing aware:

https://github.com/Tyriar/xterm.js/blob/e7e71dbd3c5d69ed296d8058514a7b60e8cb2050/addons/xterm-addon-webgl/src/GlyphRenderer.ts#L206-L220

@Tyriar Tyriar mentioned this issue Jul 31, 2022
Merged
@Tyriar Tyriar mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix powerlines, custom glyph offset and improve demo Tyriar/xterm.js
1 participant
@Tyriar