-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage for encode.ts file #47
Conversation
If you prefer using I'm aiming for about 90% branch coverage per file, but any improvement is great! It might not be possible to increase it further because reports are still experimental. If you think we've hit the limit, I'm happy with the PR as is. |
@xseman - I asked because this can lead to a major breaking change. On the other hand, I see an added value in creating an enum of errors and moving the changing parts of error response to |
Nice, it looks like you've handled everything with the encoding. If you're not working on decoding, we can merge it. |
I have assigned some time for |
* Add test for headerBysquare * Add test for headerBysquare version * Add test for headerBysquare document type and reserved nibble * Add test for direct debit. * Add test for removeDiacritics
Current improvement:
Hi @xseman. Please check the implementation. The main change is, that I have introduced the
EncodeError
class with theEncodeErrorMessage
enum. What do you think about that approach?