Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move global_variables from Photosphere to a subclass #430

Open
lmauviard opened this issue Dec 2, 2024 · 0 comments
Open

Move global_variables from Photosphere to a subclass #430

lmauviard opened this issue Dec 2, 2024 · 0 comments
Assignees
@lmauviard @ckazantsev
Labels
good first issue Good for newcomers

Comments

@lmauviard
Copy link
Collaborator

The global_variables in Photosphere is required by raising NotImplementedError('Subclass and provide an implementation.') if not implemented. However, it is used only for plotting using _image and is useless for inference.

I think this should be moved to a subclass made for plotting only. It also bothers the module_generator which would not need to make a CustomPhotosphere otherwise (given that the load NSX files are in the base Photosphere too)
@lmauviard lmauviard added good first issue Good for newcomers hackweek2024 Issues to be fixed during the 2024 Hack Week labels Dec 2, 2024
@lmauviard lmauviard self-assigned this Dec 2, 2024
@ckazantsev ckazantsev self-assigned this Dec 5, 2024
@drannawatts drannawatts removed the hackweek2024 Issues to be fixed during the 2024 Hack Week label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmauviard lmauviard

@ckazantsev ckazantsev

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

430-move-global_variables-from-photosphere-to-a-subclass ckazantsev/xpsi_ck
3 participants
@drannawatts @lmauviard @ckazantsev