Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remover responsabilidade de clique do componente Block #15

Closed
gbombassaro opened this issue Jun 30, 2020 · 1 comment · Fixed by #38
Closed

Remover responsabilidade de clique do componente Block #15

gbombassaro opened this issue Jun 30, 2020 · 1 comment · Fixed by #38
Assignees
@gbombassaro
Labels
melhoria Melhoria a ser realizada no projeto

Comments

@gbombassaro
Copy link
Contributor

Teremos mais de uma função passando aqui? Caso não, sugiro usar direto handleClick ao invés de um objeto. Pode causar confusão na hora de escrever o código. Com uma props direto fica mais certeiro de saber o que o componente espera.

Originally posted by @gbombassaro in #13
@gbombassaro gbombassaro added the melhoria Melhoria a ser realizada no projeto label Jun 30, 2020
@gbombassaro gbombassaro self-assigned this Jun 30, 2020
@gbombassaro
Copy link
Contributor Author

Também não consigo utilizar o flex-wrap no componente. Podemos criar uma prop wrap true|false que comande esse estilo para as rows.

@gbombassaro gbombassaro linked a pull request Jul 15, 2020 that will close this issue
Fix/block #38
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbombassaro gbombassaro

Labels
melhoria Melhoria a ser realizada no projeto
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/block xproglabs/prensa-designsystem
1 participant
@gbombassaro