공지글목록을 일반글목록처럼 trigger 이용해 별도로 추출할 수 있는 기능 추가 #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejin7940
changed the title
ghost
self-assigned this
ghost
removed their assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
일반글을 추출하는 getDocumentList 에도
XE 의 기본 쿼리 대신 trigger 를 이용해 목록을 가져오는 기능이 있듯이
공지글을 추출하는 getNotcieList 에도
동일한 기능이 있는게 좋을듯합니다. ( 실제 필요할때가 있어서 Core 에 추가해쓰고 있거든요 )
소스는 getDocumentlist 에서와 거의 동일합니다.
자연스럽게
ModuleHandler::triggerCall('document.getNoticeList', 'before', $obj); 트리거도 추가되겠네요.