Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page action should toggle entries to reading list #4

Open
kevonfernando opened this issue Sep 16, 2021 · 2 comments
Open

Page action should toggle entries to reading list #4

kevonfernando opened this issue Sep 16, 2021 · 2 comments

Comments

@kevonfernando
Copy link

The page action button should ideally be able to remove a webpage from the reading list if it has already been added.
Also this is a great addon. I really like the idea of keeping it in a native style which is why I downloaded it. Thank you for making this addon.

@xpmn
Copy link
Owner

xpmn commented Sep 16, 2021

Hi! Thank you for a feedback!

I did this logic at the very beginning, but then I changed it - now clicking on the icon hoist a link in the list. I did it because it isn't possible to show in address bar the actual status (icon always in initial state) - so I had accidentally removed some of my articles.

I think about adding some indicator to show visited link in list. And maybe show some popup in opened link (but it requires access to all pages :( )

@kevonfernando
Copy link
Author

Oh, I see the problem. Maybe you could circumvent this issue by having two page actions? The current default (not added state) only shows when a url is not yet in the list and a new one (added state) only when it already is in the list. Would this be possible instead?

Also the read indicator in the list would be nice too. Would make it more like in Firefox for iOS.

And about the popup, the feature as well as the permission could be optional. This way the addon would be less scary for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants