Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax error in docstrings #11

Open
bjornaa opened this issue Sep 1, 2020 · 2 comments
Open

syntax error in docstrings #11

bjornaa opened this issue Sep 1, 2020 · 2 comments

Comments

@bjornaa
Copy link

bjornaa commented Sep 1, 2020

Hi,

A trivial detail, but slightly annoying.

There are four syntax errors in xroms.py all related to the docstrings.
For roms_dataset, open_netcdf, open_zarr the docstring starts with ''' and end with """.
For the function hgrad is opposite, starts with """ and end with '''.

Automatic running of black before commit can be discussed,
but black (and possibly other tools) will prevent this kind of errors to get into the repo.

Bjørn Ådlandsvik

@kthyng
Copy link
Contributor

kthyng commented Oct 28, 2022

Yes! Thank you. I am going to start improving the packaging. I haven't figured out how to run precommit checks and make improvements automatically, so if you know how to do that I would love the assistance.

@kthyng
Copy link
Contributor

kthyng commented May 24, 2023

Hi again! I've recently put out a new version to PyPI (v0.2.4, still coming through on conda-forge). Please check to see if this issue is still present in the new version so that over time we can work to address these. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants