Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: use ethers::types::Bytes wherever we accept input to an RPC #71

Open
insipx opened this issue Feb 14, 2024 · 0 comments
Open

Bug: use ethers::types::Bytes wherever we accept input to an RPC #71

insipx opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@insipx
Copy link
Contributor

insipx commented Feb 14, 2024

Is your feature request related to a problem?

Bytes is a special type from ethers that handles hex strings. We should try to reach parity with ethers by using Bytes instead of Vec<u8>. This also avoids errors where we pass the bytes of a hex string, rather than the decoded bytes of a hex string

Describe the solution to the problem

No response

Describe the uses cases for the feature

No response

Additional details

No response
@insipx insipx added the enhancement New feature or request label Feb 14, 2024
@insipx insipx added bug Something isn't working and removed enhancement New feature or request labels Feb 14, 2024
@insipx insipx changed the title Feature request: use ethers::types::Bytes wherever we accept input to an RPC Bug: use ethers::types::Bytes wherever we accept input to an RPC Feb 14, 2024
@insipx insipx mentioned this issue Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
D14N Work
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@insipx