Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict ugorji encoding #50

Open
johnabass opened this issue May 20, 2020 · 0 comments
Open

Strict ugorji encoding #50

johnabass opened this issue May 20, 2020 · 0 comments
Assignees
@schmidtw
Labels
question Further information is requested

Comments

@johnabass
Copy link
Contributor

We currently configure the ugorji library to be very loose when decoding. For example, spans was defined as a [][]string, but when the underlying message format changed there was no error because ugorji silently did the conversion.

Should we continue to do this? Do we want XMiDT cluster code to throw an error when a msgpack or JSON message is encountered that does not strictly conform to the WRP spec?
@johnabass johnabass added the question Further information is requested label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmidtw schmidtw

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmidtw @johnabass