Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: add cmake support #5437

Closed
star-hengxing opened this issue Oct 7, 2024 · 3 comments · Fixed by #5640
Closed

boost: add cmake support #5437

star-hengxing opened this issue Oct 7, 2024 · 3 comments · Fixed by #5640

Comments

@star-hengxing
Copy link
Contributor

star-hengxing commented Oct 7, 2024

Is your feature request related to a problem? Please describe.

set_urls("https://github.com/boostorg/boost/releases/download/boost-$(version)/boost-$(version)-cmake.7z")
add_versions("1.86.0", "ee6e0793b5ec7d13e7181ec05d3b1aaa23615947295080e4b9930324488e078f")

Describe the solution you'd like

Create new package boost-cmake or use on_source + add_configs("cmake", {description = "Use cmake buildsystem", default = false, type = "boolean"})

Describe alternatives you've considered

No response

Additional context

No response

@SirLynix
Copy link
Member

SirLynix commented Oct 7, 2024

why not default to cmake for newer builds?

@star-hengxing
Copy link
Contributor Author

I'm not sure if using cmake directly would break downstream users.
Msys2 has switched to cmake, but someone reported a bug msys2/MINGW-packages#13608 (comment)

It's fine to build with cmake by default, but it's a good idea to leave a warning to remind the user that they can fallback to b2 and try building again.

@waruqi
Copy link
Member

waruqi commented Oct 8, 2024

we can attempt to add add_configs("cmake" and set it to true (default) + warning first.

if it will be broken, we can set it(false) to fallback to b2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants