Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godotcpp4: fix python scripts #4888

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

Persson-dev
Copy link
Contributor

Was causing

NameError: name 'BoolVariable' is not defined:
  File "~/.xmake/cache/packages/2408/g/godotcpp4/4.2/source/godotcpp4/SConstruct", line 36:
    cpp_tool.options(opts, env)
  File "~/.xmake/cache/packages/2408/g/godotcpp4/4.2/source/godotcpp4/tools/godotcpp.py", line 325:
    tool.options(opts)
  File "~/.xmake/cache/packages/2408/g/godotcpp4/4.2/source/godotcpp4/tools/ios.py", line 24:
    opts.Add(BoolVariable("ios_simulator", "Target iOS Simulator", False))```

@star-hengxing
Copy link
Contributor

It looks like upstream has been fixed, maybe just need to update the commit hash?

@Persson-dev
Copy link
Contributor Author

You're right. It works just fine now 👍

@star-hengxing star-hengxing merged commit 27d880f into xmake-io:dev Aug 11, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants