Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boost package:config("vs_runtime") to package:has_runtimes #4875

Closed
wants to merge 19 commits into from

Conversation

fasiondog
Copy link
Contributor

调整 boost 库中使用的 package:config("vs_runtime") 为 package:runtimes()

@star-hengxing
Copy link
Contributor

一个 pr 单独一个分支,用以前的分支就会把提交附带上来。另外不要用中文 commit

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


A PR is a separate branch, and the commit will be attached to the previous branch. Also don’t use Chinese commit

@@ -101,7 +101,7 @@ package("boost")
linkname = linkname .. "-mt"
end
if package:is_plat("windows") then
local vs_runtime = package:config("vs_runtime")
local vs_runtime = package:runtimes()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 package:has_runtime

@fasiondog fasiondog changed the title 调整 boost 库中使用的 package:config("vs_runtime") 为 package:runtimes() update boost package:config("vs_runtime") to package:has_runtimes Aug 9, 2024
@waruqi
Copy link
Member

waruqi commented Aug 9, 2024

commit 清理下,然后 force push 下,不要带中文

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Clean up the commit and then force push. Do not include Chinese characters.

@fasiondog fasiondog closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants