concurrencpp: support some platform #4834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔on_check failed with |
|
先放着吧 等下周我看下 |
Let it go for now. I'll take a look at it next week. |
这个我修了，改成仅仅在 on_test 才做检测。。 |
waruqi
reviewed
Aug 4, 2024
| void test() { | ||
| auto x = std::hardware_destructive_interference_size; | ||
| } | ||
| ]]}, {configs = {languages = "c++20"}}), "package(concurrencpp) Require at least C++20.") |
There was a problem hiding this comment.
不过这里似乎还是不太准，我 macos 上测试
8C454D9092B3AAD9C2C3C0B4.cpp:7:31: error: no member named 'hardware_destructive_interference_size
' in namespace 'std'
auto x = std::hardware_destructive_interference_size;
~~~~~^但是去掉这个 最后安装编译 on_test 都能过。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.