-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breakpad: add support for linux and macosx #4783
Conversation
这 5k 行是什么玩意。。 |
What the hell is this 5k line. . |
是linux_syscall_support 的头文件 |
在add_deps中添加了以后,和源代码中的编译路径不一致,我就通过patch来加 |
It is the header file of linux_syscall_support |
After adding it in add_deps, it was inconsistent with the compilation path in the source code, so I added it through patch. |
可以参考隔壁,也单独打一个包 |
You can refer to the one next door, or pack it in a separate bag |
好的👌
…---Original---
From: ***@***.***>
Date: Mon, Jul 29, 2024 17:58 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [xmake-io/xmake-repo] breakpad: add support for linux and macosx(PR #4783)
可以参考隔壁,也单独打一个包
https://conan.io/center/recipes/linux-syscall-support
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
头文件库加上 |
packages/b/breakpad/xmake.lua
Outdated
@@ -63,5 +84,5 @@ package("breakpad") | |||
end | |||
|
|||
local header = "client/" .. plat .. "/handler/exception_handler.h" | |||
assert(package:check_cxxsnippets({test = snippets}, {configs = {languages = "c++11"}, includes = header})) | |||
assert(package:check_cxxsnippets({test = snippets}, {configs = {languages = "c++17"}, includes = header, {packages = "breakpad"}})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不需要加 packages,没这个用法
Header library plus |
packages/b/breakpad/xmake.lua
Outdated
os.cp(package:installdir("include", "breakpad", "processor"), package:installdir("include")) | ||
os.cp(package:installdir("include", "breakpad", "google_breakpad"), package:installdir("include")) | ||
os.cp(package:installdir("include", "breakpad", "third_party"), package:installdir("include")) | ||
print("fucking success") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove logs
packages/b/breakpad/xmake.lua
Outdated
print(os.curdir() , "is the xmake pkg install dir") | ||
io.replace("configure", "WARN_CXXFLAGS \" -Werror\"", "WARN_CXXFLAGS ", {plain = true}) | ||
local configs = {"--disable-dependency-tracking"} | ||
if package:debug() then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package:is_debug
packages/b/breakpad/xmake.lua
Outdated
@@ -33,6 +38,22 @@ package("breakpad") | |||
import("package.tools.xmake").install(package, configs) | |||
end) | |||
|
|||
on_install("linux", "macosx", function (package) | |||
print(os.curdir() , "is the xmake pkg install dir") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove logs
@@ -33,6 +38,20 @@ package("breakpad") | |||
import("package.tools.xmake").install(package, configs) | |||
end) | |||
|
|||
on_install("linux", function (package) | |||
io.replace("configure", "WARN_CXXFLAGS \" -Werror\"", "WARN_CXXFLAGS ", {plain = true}) | |||
local configs = {"--disable-dependency-tracking", "CXXFLAGS=-std=gnu++17"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, 修改成新的格式并更改了includedir,删除了复制头文件的操作
添加了breakpad的linux 和macosx的支持