Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpad: add support for linux and macosx #4783

Merged
merged 13 commits into from
Aug 12, 2024

Conversation

hahahahbenny
Copy link
Contributor

添加了breakpad的linux 和macosx的支持

@star-hengxing
Copy link
Contributor

这 5k 行是什么玩意。。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


What the hell is this 5k line. .

@hahahahbenny
Copy link
Contributor Author

这 5k 行是什么玩意。。

是linux_syscall_support 的头文件

@hahahahbenny
Copy link
Contributor Author

这 5k 行是什么玩意。。

在add_deps中添加了以后,和源代码中的编译路径不一致,我就通过patch来加

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


What the hell is this 5k line. .

It is the header file of linux_syscall_support

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


What the hell is this 5k line. .

After adding it in add_deps, it was inconsistent with the compilation path in the source code, so I added it through patch.

@star-hengxing
Copy link
Contributor

可以参考隔壁,也单独打一个包
https://conan.io/center/recipes/linux-syscall-support

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


You can refer to the one next door, or pack it in a separate bag
https://conan.io/center/recipes/linux-syscall-support

@hahahahbenny
Copy link
Contributor Author

hahahahbenny commented Jul 29, 2024 via email

@hahahahbenny hahahahbenny reopened this Aug 8, 2024
@star-hengxing
Copy link
Contributor

头文件库加上 set_kind("library", {headeronly = true})

@@ -63,5 +84,5 @@ package("breakpad")
end

local header = "client/" .. plat .. "/handler/exception_handler.h"
assert(package:check_cxxsnippets({test = snippets}, {configs = {languages = "c++11"}, includes = header}))
assert(package:check_cxxsnippets({test = snippets}, {configs = {languages = "c++17"}, includes = header, {packages = "breakpad"}}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要加 packages,没这个用法

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Header library plus set_kind("library", {headeronly = true})

os.cp(package:installdir("include", "breakpad", "processor"), package:installdir("include"))
os.cp(package:installdir("include", "breakpad", "google_breakpad"), package:installdir("include"))
os.cp(package:installdir("include", "breakpad", "third_party"), package:installdir("include"))
print("fucking success")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove logs

print(os.curdir() , "is the xmake pkg install dir")
io.replace("configure", "WARN_CXXFLAGS \" -Werror\"", "WARN_CXXFLAGS ", {plain = true})
local configs = {"--disable-dependency-tracking"}
if package:debug() then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package:is_debug

@@ -33,6 +38,22 @@ package("breakpad")
import("package.tools.xmake").install(package, configs)
end)

on_install("linux", "macosx", function (package)
print(os.curdir() , "is the xmake pkg install dir")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove logs

@@ -33,6 +38,20 @@ package("breakpad")
import("package.tools.xmake").install(package, configs)
end)

on_install("linux", function (package)
io.replace("configure", "WARN_CXXFLAGS \" -Werror\"", "WARN_CXXFLAGS ", {plain = true})
local configs = {"--disable-dependency-tracking", "CXXFLAGS=-std=gnu++17"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 修改成新的格式并更改了includedir,删除了复制头文件的操作

@star-hengxing star-hengxing merged commit ad5fd80 into xmake-io:dev Aug 12, 2024
49 of 65 checks passed
@hahahahbenny hahahahbenny deleted the breakpad branch August 27, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants