Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::codecvt by MultiByteToWideChar due to deprecation #29

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

doomlaur
Copy link

Replace std::codecvt for UTF-8 to UTF-16 conversions under Windows by MultiByteToWideChar provided by the Windows API, as the std::codecvt conversions are deprecated since C++17 and removed in C++26.

… MultiByteToWideChar provided by the Windows API, as the std::codecvt conversions are deprecated since C++17 and removed in C++26.
@doomlaur doomlaur requested a review from m7913d September 29, 2024 20:58
@coveralls
Copy link

coveralls commented Sep 29, 2024

Pull Request Test Coverage Report for Build db265a11-d8e9-4562-8b61-2e9fc04f2e88

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.146%

Totals Coverage Status
Change from base Build a8225596-cf11-41cc-8702-f753b3c69ddc: 0.0%
Covered Lines: 10656
Relevant Lines: 12816

💛 - Coveralls

source/utils/path.cpp Outdated Show resolved Hide resolved
source/utils/path.cpp Outdated Show resolved Hide resolved
Copy link
Member

@m7913d m7913d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the sometimes irrelevant/incorrect remarks.

@doomlaur
Copy link
Author

doomlaur commented Oct 1, 2024

No worries, thanks for approving! 😄

@doomlaur doomlaur merged commit 1adaadb into master Oct 1, 2024
24 checks passed
@doomlaur doomlaur deleted the replace_codecvt branch October 1, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants