Make EncoderConfig non_exhaustive #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows changing it in the future without performing an API breaking change.
|
It is probably a good idea, but the current implementation in rust seems to trip in exactly the pattern that makes possible to write code w/out caring about additional fields... |
|
Oh indeed, I've thought the ..Default::default pattern still works with non_exhaustive, but seems it's disallowed. Apparently so that you are allowed to add private fields in the future... Should I close this? |
|
At least for now, it seems that it has more cons than pros sadly =/ |
|
Ok then! Btw, I'm interested in this struct because of #151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows changing it in the future without performing an API breaking
change.