Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout Playlist: Refactor Convert to global #3452

Closed
maurofmferrao opened this issue Jul 8, 2024 · 0 comments
Closed

Layout Playlist: Refactor Convert to global #3452

maurofmferrao opened this issue Jul 8, 2024 · 0 comments
Assignees
@maurofmferrao
Labels
bug
Milestone
4.1.0-rc1

Comments

@maurofmferrao
Copy link
Member

maurofmferrao commented Jul 8, 2024 •
edited
Loading

If we have a Layout Playlist and press the Convert Layout playlist into a Global playlist. button multiple times, it will create several playlists from that one, and the resulting Playlist ion the Layout will have multiple sub-Playlists instead of just one.

It was decided to refactor this functionality:

  • Move button/trigger from Properties Panel to the context menu ( right-click )
  • Only enable for Playlists that aren't still converted to global
  • Show error message from Back-End when request to convert fails
@maurofmferrao maurofmferrao added this to the 4.1.0-rc1 milestone Jul 8, 2024
@maurofmferrao maurofmferrao self-assigned this Jul 8, 2024
maurofmferrao added a commit to xibosignage/xibo-cms that referenced this issue Jul 10, 2024
@maurofmferrao
Editor: Prevent multiple click on Convert playlist
04c59fc 
relates to xibosignage/xibo#3452
@maurofmferrao maurofmferrao mentioned this issue Jul 10, 2024
Closed
maurofmferrao added a commit to xibosignage/xibo-cms that referenced this issue Jul 15, 2024
@maurofmferrao
Editor: Prevent multiple click on Convert playlist
875f91d 
relates to xibosignage/xibo#3452
maurofmferrao added a commit to xibosignage/xibo-cms that referenced this issue Jul 16, 2024
@maurofmferrao
Layout Playlist: Convert to global refactor
0367f78 
relates to xibosignage/xibo#3452
@maurofmferrao maurofmferrao mentioned this issue Jul 16, 2024
Merged
@maurofmferrao maurofmferrao changed the title Layout Playlist: Prevent multiple consecutive clicks on the Convert to global button Layout Playlist: Refactor Convert to global Jul 16, 2024
maurofmferrao added a commit to xibosignage/xibo-cms that referenced this issue Jul 19, 2024
@maurofmferrao
Layout Playlist: Refactor Convert to global playlist fix
1fd085f 
relates to xibosignage/xibo#3452
maurofmferrao added a commit to xibosignage/xibo-cms that referenced this issue Jul 22, 2024
@maurofmferrao
Layout Playlist: Convert to global refactor (#2638)
b258eb1 
relates to xibosignage/xibo#3452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurofmferrao maurofmferrao

Labels
bug
Projects
None yet
Milestone
4.1.0-rc1
Development

No branches or pull requests
1 participant
@maurofmferrao