Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder is broken #33

Closed
atlanteh opened this issue Sep 7, 2016 · 7 comments
Closed

placeholder is broken #33

atlanteh opened this issue Sep 7, 2016 · 7 comments

Comments

@atlanteh
Copy link
Contributor

atlanteh commented Sep 7, 2016

if date is not specified the current date is placed by default instead of the placeholder, so placeholder is useless. We actually need it.

@carlespuyol
Copy link

+1

2 similar comments
@aharons
Copy link

aharons commented Sep 11, 2016

+1

@eranrgdc
Copy link

+1

@feyy
Copy link
Contributor

feyy commented Sep 12, 2016

I'm sorry I can't reappear your issue. Can you give me more info or some code?

@atlanteh
Copy link
Contributor Author

<Datepicker placeholder="Please insert a date" />

This shows the current date instead of the placeholder.
This happens due to commit b08fb7e which fixes issue #26

@feyy
Copy link
Contributor

feyy commented Sep 12, 2016

Your code work well in my example. Whether show the placeholder only depend on date and placeholder properties.

https://github.com/xgfe/react-native-datepicker/blob/master/index.js#L128-L132

@atlanteh
Copy link
Contributor Author

Ok, so I reinstalled the module, made sure I had latest and suddenly it started to work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants