Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #42

Open
dougiesquire opened this issue Apr 5, 2021 · 2 comments
Open

Add type annotations #42

dougiesquire opened this issue Apr 5, 2021 · 2 comments

Comments

@dougiesquire
Copy link
Contributor

We are now type checking xhistogram using mypy (#38). However, none of the code is static typed at this point.

It would be good to type annotate the existing methods.

@Badboy-16
Copy link
Contributor

Hi, I would like to work on this issue and will submit a PR in the coming days :)

@dougiesquire
Copy link
Contributor Author

Great @Badboy-16 , a PR would be very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants