From d5c3a29298b34cb19e2cce36e4f4d51d42fc9226 Mon Sep 17 00:00:00 2001 From: XDi00 Date: Tue, 21 Nov 2023 18:45:50 +0800 Subject: [PATCH] Squashed commit of the following: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit commit 4b5ef8328bdd846752495c00e3310e388cdfb3cf Merge: 21bf288277 c9ee29028f Author: Dan Balasescu Date: Tue Nov 21 18:00:19 2023 +0900 Merge pull request #25521 from Syriiin/fix/refactor-miss Fix implicitly used method being named incorrectly commit 21bf288277e08044e88bdc33ce53a779b293c617 Merge: bf972a04ee ed38746823 Author: Dean Herbert Date: Tue Nov 21 16:56:36 2023 +0900 Merge pull request #25520 from peppy/context-menu-spacers Allow context menus to have visible spacers commit bf972a04eebb9c20cc548ec4de2683bedbbd0da6 Merge: d83b2e24e7 4b2d8aa6a6 Author: Bartłomiej Dach Date: Tue Nov 21 16:28:14 2023 +0900 Merge pull request #25409 from Tom94/bspline-sliders Add free-hand drawing of sliders to the editor commit ed3874682365596f96fac6c8622821786b3645a5 Author: Bartłomiej Dach Date: Tue Nov 21 16:14:30 2023 +0900 Fix spacer appearing on top of menu commit d83b2e24e7eabb1bc79c9857dd3f631f4497d24d Merge: 3d569850b1 7c5345bf7e Author: Bartłomiej Dach Date: Tue Nov 21 15:48:36 2023 +0900 Merge pull request #25371 from RatinFX/open-editor-timestamp Implement opening editor timestamp links commit 4b2d8aa6a647b28c13f63dc3047cca04b8b8c398 Author: Dean Herbert Date: Tue Nov 21 15:31:39 2023 +0900 Add `ToString` on `PathType` for better test output commit cc33e121258adb0d607fba5c6bf9897e1979eac5 Author: Dean Herbert Date: Tue Nov 21 15:16:40 2023 +0900 Fix dragging after one point already placed incorrectly entering drawing mode commit 1660eb3c15b1075e93a64a2938e8e86451f5df84 Author: Dean Herbert Date: Tue Nov 21 15:31:24 2023 +0900 Add failing test coverage of drag after point placement commit a210469956ca340bb302f76679c49142e2e0ae69 Author: Dean Herbert Date: Tue Nov 21 14:52:21 2023 +0900 Reorder methods commit 016de7be6a9c0a5709e966b6f2bb45349d8f38e8 Author: Dean Herbert Date: Tue Nov 21 14:51:09 2023 +0900 Simplify drag handling code in `SliderPlacementBlueprint` commit cf6f66b84f729a71e04a34b7d9acf9091dfbd7cb Author: Dean Herbert Date: Tue Nov 21 14:37:06 2023 +0900 Remove redundant `Clear()` call commit 92728ea56460dfe0c2135d9165ee8d35e49fe8ad Author: Dean Herbert Date: Tue Nov 21 14:10:48 2023 +0900 Simplify toolbox initialisation commit ba6fbbe43c122413c4b4b81eb9450e77f3361f8b Author: Dean Herbert Date: Tue Nov 21 14:03:45 2023 +0900 Update framework commit 3d094f84add9f669b2bf0e1bd41bd83da4fd01fd Author: Dean Herbert Date: Tue Nov 21 14:02:15 2023 +0900 Fix incorrect parsing of BSpline curve types commit 9c3f9db31838295cccc0ea4f771933dbb4fa2dc7 Author: Dean Herbert Date: Tue Nov 21 14:02:08 2023 +0900 Add failing test coverage of BSpline encoding parse failure commit 7bedbe42642384a20b681220b507fcc737325c1e Author: Dean Herbert Date: Tue Nov 21 13:36:06 2023 +0900 Apply NRT to `SliderPlacementBlueprint` tests commit 5175464c18dafc3931b723ae06dbb4375c7c0a77 Author: Dean Herbert Date: Tue Nov 21 13:35:04 2023 +0900 Update test coverage (and add test coverage of curve drawing) commit e69e78ad4123a4d89915aa44286a8e637e49429d Author: Dean Herbert Date: Tue Nov 21 13:10:44 2023 +0900 Refactor b-spline path conversion code to better handle linear segments commit 0a5444d091de73c2cc9fe8360146248d1b06b39e Author: Dean Herbert Date: Tue Nov 21 13:05:31 2023 +0900 Fix using the incorrect position for the first point commit 314a7bf6f1058195ecf5995fc18a5e5bc1eb94fe Author: Dean Herbert Date: Tue Nov 21 11:33:05 2023 +0900 Simplify `AddOnce` call to avoid `self` argument commit 7c5345bf7e88ba364cd3606e424f4ae45b6760f2 Author: Dean Herbert Date: Tue Nov 21 15:09:33 2023 +0900 Use `SimpleErrorNotification` for error display commit 917a68eac3273f969a7b760cd7a258e475fcc23e Author: Dean Herbert Date: Tue Nov 21 15:08:15 2023 +0900 Adjust localisablel strings and keys commit 3afaafb1d9a19692cbd6750eda24cbd7d920c7d2 Author: Dean Herbert Date: Tue Nov 21 15:05:51 2023 +0900 Reorder and simplify private helper methods commit c9ee29028fbcf3056c82d5b5c182f862f68974fa Author: Samuel Cattini-Schultz Date: Tue Nov 21 16:54:20 2023 +1100 Fix implicitly used method being named incorrectly commit 9718a802490519780c3d88f55a90037a20b26421 Author: Dean Herbert Date: Tue Nov 21 14:24:19 2023 +0900 Add visible spacer between "inherit" and other curve types commit 405ab499e9dfd7c75477513aa38b344ffb901781 Author: Dean Herbert Date: Tue Nov 21 14:24:10 2023 +0900 Allow context menus to have visible spacers commit 3680024e3102d5dcca617371105d4c3bf3787945 Author: Dean Herbert Date: Tue Nov 21 11:15:00 2023 +0900 Fix tolerance not being transferred to blueprint in all cases commit e9f371a5811b72763a50fc1e5fffba5ef95e081f Author: Dean Herbert Date: Tue Nov 21 09:59:49 2023 +0900 Refactor slider settings class commit 638c8f1adc2e135aff574e135c515adfbf384423 Author: Dean Herbert Date: Tue Nov 21 00:25:23 2023 +0900 Get rid of weird cruft and non-standard flow commit 6f5c468a83cd0341616d01d10ef5345568a7d943 Author: Dean Herbert Date: Tue Nov 21 00:21:44 2023 +0900 Rename settings class commit 750bbc8a19cfdb0f1c3133e9bd86e02bacb51f0d Author: Dean Herbert Date: Tue Nov 21 00:17:25 2023 +0900 Simplify null checks commit 745a04a243b90a1b83da308ea3e8e6467c9faacc Author: Bartłomiej Dach Date: Mon Nov 20 22:12:15 2023 +0900 More test cleanup commit a8fc73695f30b3d22c260c8ea030f3034d1c21d5 Author: Bartłomiej Dach Date: Mon Nov 20 22:04:08 2023 +0900 Rename variable commit 364a3f75e15001b785f185c41ba69e28edecf926 Author: Bartłomiej Dach Date: Mon Nov 20 22:03:25 2023 +0900 Compile regexes commit c16afeb34700b22a09932ad792ae801c0c5bffb9 Author: Bartłomiej Dach Date: Mon Nov 20 21:57:07 2023 +0900 Fix tests commit b6215b2809aac10f2bbf82403b76c6ca37f8d285 Author: Bartłomiej Dach Date: Mon Nov 20 21:37:29 2023 +0900 Rename and document `SelectFromTimestamp` commit 234ef6f92379b3cbf0c9a07f2334f2a068f9fe95 Author: Bartłomiej Dach Date: Mon Nov 20 21:34:36 2023 +0900 Rectify selection keep-alive logic commit 246aacb216d692b7bc54ae7fccebfd5869561d82 Author: Bartłomiej Dach Date: Mon Nov 20 21:29:19 2023 +0900 Remove unnecessary guard Setting a bindable's value to something if that value is already there is a no-op (doesn't trigger bindings / callbacks). commit 0e0ab66148ec99a0458b5102541e1a58206a2887 Author: Bartłomiej Dach Date: Mon Nov 20 21:27:24 2023 +0900 Simplify parsing code Less methods, less smeared around logic, saner data types. commit c9e8d66e1970fa8498761b4fb5fe868bf879d1d7 Author: Bartłomiej Dach Date: Mon Nov 20 21:02:12 2023 +0900 Improve xmldoc commit 492fd06c624b2d8d8ff65464798bcde72c4fd51c Author: Dean Herbert Date: Mon Nov 20 19:21:23 2023 +0900 Remove unnecessary null override commit 3d569850b15ad66b3c95e009f173298d65a8e3de Merge: aeb1aaf97a 66f7b9fae1 Author: Bartłomiej Dach Date: Mon Nov 20 17:58:15 2023 +0900 Merge pull request #25493 from peppy/adjust-slider-tick-animation Adjust slider follow circle animation to not abruptly scale on early ticks commit ded9981d07b8bc54fd43a53a76f6335aab5d636f Author: Dean Herbert Date: Mon Nov 20 17:55:01 2023 +0900 Update framework commit 7633c92a78b8341411fc0e3185efc2118bf09fc5 Merge: 4061417ac8 aeb1aaf97a Author: Dean Herbert Date: Mon Nov 20 17:53:58 2023 +0900 Merge branch 'master' into bspline-sliders commit 4061417ac8cff9242cf5582fdb8b173f7095059e Author: Bartłomiej Dach Date: Mon Nov 20 15:54:43 2023 +0900 Decrease default value for slider tolerance Highly subjective change, but at 50 the drawing just did not feel responsive enough to input. commit 43dbd65708de80e4e671e042e76496ffb7526d57 Author: Bartłomiej Dach Date: Mon Nov 20 15:53:25 2023 +0900 Show Catmull as a control point type option if selection already contains it commit 8e39dbbff1898830ab70c5b418ec31b661fede42 Author: Bartłomiej Dach Date: Mon Nov 20 15:41:26 2023 +0900 Adjust casing of curve type menu items The "Perfect curve" one in particular... fixes test failures, as some tests were relying on this particular casing. But the new version feels more correct anyway, so it's whatever. commit 5f302662be30eff9eb12318c40651f1f776fb09c Author: Bartłomiej Dach Date: Mon Nov 20 15:34:23 2023 +0900 Remove test terminally broken by introduction of slider drawing commit 46d4587c97fc8a6d7b3a2ea0e98366fe149f2ed3 Author: Bartłomiej Dach Date: Mon Nov 20 15:34:01 2023 +0900 Add test for slider drawing commit 6d7d826b8b76f775bf59d600d493912a92950540 Author: Bartłomiej Dach Date: Mon Nov 20 15:08:58 2023 +0900 Fix incorrect legacy conversion when B-splines are used commit 80a3225bb28f315aeceda4dc5e10c2222faa0e1f Author: Bartłomiej Dach Date: Mon Nov 20 13:35:07 2023 +0900 Use static `BEZIER` instead of allocating new every time commit 487326a4c786aa89b597ea191ec83c701386736d Author: Bartłomiej Dach Date: Mon Nov 20 13:22:36 2023 +0900 Remove pattern matching syntax usage in switch Also throw on unknown types. commit 5d1bac6d7a55a980e608fbf6bfa8744ceb30b18f Author: Bartłomiej Dach Date: Mon Nov 20 13:17:43 2023 +0900 Remove `IToolboxAttachment` for now The interface doesn't really do anything useful right now because it enforces a common contract, but all usages of the contract go through the concrete implementation, and it inflates the already-huge diff. commit affef85f2521246412949531e291fdbed4cf1272 Author: Bartłomiej Dach Date: Mon Nov 20 13:02:51 2023 +0900 Remove `ISliderDrawingSettingsProvider` Seems like excessive abstraction. commit 831884a64b74113f76bc59eed0466f232b71f7aa Author: Bartłomiej Dach Date: Mon Nov 20 13:00:12 2023 +0900 Remove unused enum member commit f46945a29439716ef10e5e82277cf5e338044094 Author: Bartłomiej Dach Date: Mon Nov 20 12:42:16 2023 +0900 Avoid one unnecessary path update from B-spline builder commit 518dcc567b14cdf8ade2d449b20cdcbcfcf45e98 Author: Bartłomiej Dach Date: Mon Nov 20 12:41:22 2023 +0900 Null-check `drawingSettingsProvider` As it's annotated as an optional dependency. commit 7820c8ce4d558381f80444fcf3fb38035382a852 Author: Bartłomiej Dach Date: Mon Nov 20 12:28:20 2023 +0900 Decrease redundancy of equality implementations commit 25c1a900473de216ba5c07b306b4e49316ec7828 Author: Bartłomiej Dach Date: Mon Nov 20 12:25:44 2023 +0900 Change switchexpr to standard switch statement commit 577cb9994ce54202bf2c07548389f0e6b701fa8f Author: Bartłomiej Dach Date: Mon Nov 20 12:24:32 2023 +0900 Move static instances / construction methods closer together commit aeb1aaf97a98c30c22646fa4d0ab3fcc1642c2f2 Merge: 166518db7a 6304ba18e5 Author: Bartłomiej Dach Date: Mon Nov 20 12:21:35 2023 +0900 Merge pull request #25490 from peppy/auto-generator-spm Refactor `OsuAutoGenerator` to allow custom SPM specifications commit 33b592f1c723fb4824f2084337de9dbb940d2b1f Author: Bartłomiej Dach Date: Mon Nov 20 12:04:30 2023 +0900 Update framework (again) commit b6e3e42445f55de1dd7787a9d95716ac0f717425 Merge: 360864fd7b 166518db7a Author: Bartłomiej Dach Date: Mon Nov 20 12:03:29 2023 +0900 Merge branch 'master' into bspline-sliders commit 6304ba18e55ff0aeb5e3257bc73fb40eb06b5971 Merge: e182acf3e8 166518db7a Author: Bartłomiej Dach Date: Mon Nov 20 11:50:44 2023 +0900 Merge branch 'master' into auto-generator-spm commit e182acf3e8c012fe36f8317d70ca7d6abe1803e9 Author: Bartłomiej Dach Date: Mon Nov 20 11:50:28 2023 +0900 Expand comment for clarification commit 307ec172cbcc49f0edf26aed318d5390666faafa Author: Dean Herbert Date: Fri Nov 17 23:48:48 2023 +0900 Use simplified formula commit 166518db7a84ce5619b7ee74a014651dd9256f22 Merge: dee6a79911 bd932a5417 Author: Dan Balasescu Date: Fri Nov 17 20:12:24 2023 +0900 Merge pull request #25491 from peppy/update-localisation-analyser Update localisation analyser commit 66f7b9fae1e0aaf86609bdbf3315870198e0f8b2 Author: Dean Herbert Date: Fri Nov 17 19:09:24 2023 +0900 Adjust slider follow circle animation to not abruptly scale on early ticks commit bd932a5417dd7bc4fba8b237832d556c27ea0d9b Author: Dean Herbert Date: Fri Nov 17 17:07:21 2023 +0900 Update localisation analyser Pulls in https://github.com/ppy/osu-localisation-analyser/pull/60. commit a1673160f12e08612aa42a9db89f8b9f2e6324f0 Author: Dean Herbert Date: Fri Nov 17 16:44:11 2023 +0900 Refactor `OsuAutoGenerator` to allow custom SPM specifications commit dee6a799113fe24f5acab7088c5d0e0c305adad3 Merge: 87a76b9ee8 b88e3cd26f Author: Bartłomiej Dach Date: Thu Nov 16 22:25:14 2023 +0900 Merge pull request #25481 from peppy/make-skin-store-fallback Change `ResourceStore` provided to `Skin` to be a fallback, not replacement commit b88e3cd26f8eb3f7b90e8bc6a96097ae23d3773e Author: Dean Herbert Date: Thu Nov 16 20:16:23 2023 +0900 Change `ResourceStore` provided to `Skin` to be a fallback, not replacement commit 87a76b9ee80055a85cb51a12e0a70083c1ba63e2 Merge: 0a8ede6274 dc2d574965 Author: Dean Herbert Date: Thu Nov 16 17:39:35 2023 +0900 Merge pull request #25478 from Joehuu/fix-comment-markdown Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class commit 0a8ede627465586c54ad324eb140a268f77da353 Merge: d09d58639a b45872d2e0 Author: Dean Herbert Date: Thu Nov 16 17:01:03 2023 +0900 Merge pull request #25469 from Joehuu/argon-hide-counter-labels Add ability to toggle labels on argon counter components commit d09d58639ae0cd07bf472d05b32aaee50827e81a Merge: 4642b916b0 1e2f1b3ef2 Author: Bartłomiej Dach Date: Thu Nov 16 16:47:03 2023 +0900 Merge pull request #25400 from frenzibyte/unload-main-menu-storyboard Unload beatmap storyboards when not in main menu screen commit 1e2f1b3ef202d3a7f80274f1c87725e41287c5c2 Merge: dbd4f26436 4642b916b0 Author: Bartłomiej Dach Date: Thu Nov 16 15:46:44 2023 +0900 Merge branch 'master' into unload-main-menu-storyboard commit dbd4f26436c988a8d1e1afb6e893e82fedb25460 Author: Bartłomiej Dach Date: Thu Nov 16 15:37:53 2023 +0900 Use alternative method of scheduling storyboard unload commit b45872d2e0f901e65c6e44cc0439f29b562f3785 Merge: 73eda6c09c 4642b916b0 Author: Dean Herbert Date: Thu Nov 16 14:20:13 2023 +0900 Merge branch 'master' into argon-hide-counter-labels commit 73eda6c09c259e0f517ffa75a0affb8902ef1fd4 Author: Dean Herbert Date: Thu Nov 16 14:18:49 2023 +0900 Move non-matching default value to argon skin default speficiation instead commit 39a3313929035bc50e308a5ecee8f568f85dbe76 Author: Dean Herbert Date: Thu Nov 16 14:11:01 2023 +0900 Update tooltip description slightly commit 4642b916b0b0b2a212a5b72edfc78036d3a3628f Merge: 7f90db7603 0c0093e641 Author: Dean Herbert Date: Thu Nov 16 13:44:39 2023 +0900 Merge pull request #25468 from peppy/argon-skin-coverage Add test coverage of accessing skin layout after importing customised default skins commit dc2d5749651de89bd1e4d5bba615068bfce1ac30 Author: Joseph Madamba Date: Wed Nov 15 19:41:13 2023 -0800 Fix comment markdown image not showing tooltips commit 2b19cf6ce4b908880db4854a4f74d30edd7714ac Author: Joseph Madamba Date: Wed Nov 15 19:43:25 2023 -0800 Fix comment markdown style regression commit 7f90db7603714c665ae05cd83f59c61060d8dd2f Merge: 189fca2eb6 2987c0e802 Author: Dean Herbert Date: Wed Nov 15 19:02:30 2023 +0900 Merge pull request #25472 from bdach/argon-health-folding-in-on-self Fix argon health bar folding in on itself when too narrow commit 2987c0e802ec597ab7480c9d3623b423592669bc Author: Dean Herbert Date: Wed Nov 15 19:01:52 2023 +0900 Add note about enfocing size methodology commit 0c0093e6413300efa4d3c41e173a0f8f73723a7e Merge: b118999120 189fca2eb6 Author: Bartłomiej Dach Date: Wed Nov 15 18:30:03 2023 +0900 Merge branch 'master' into argon-skin-coverage commit b118999120ec13d4632f032429fbc3a26cc43db2 Author: Bartłomiej Dach Date: Wed Nov 15 18:27:08 2023 +0900 Remove unused using directive commit 189fca2eb6b6327e9efc5074aa0304af940546f9 Merge: 10be233562 7b987266d5 Author: Dean Herbert Date: Wed Nov 15 18:01:24 2023 +0900 Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid Add `UserGridPanel` as the `ClickableAvatar` tooltip commit 7b987266d50db8b3c5668a27625f7635a6eeefbc Author: Joseph Madamba Date: Tue Nov 14 16:15:22 2023 -0800 Change behavior of some clickable avatars in line with web commit deef8998f73850d0e40247fa5854f042967e4687 Author: Joshua Hegedus Date: Fri Nov 10 11:45:31 2023 +0100 reverted the change commit aa9deecafe7ad9150d82bfa7015d7e21cf3888b5 Author: Joshua Hegedus Date: Fri Nov 10 11:37:23 2023 +0100 added missing comment, fixed incorrect visibility commit 360864fd7b6dac30bda9a2cf4092a316b280427d Author: cs Date: Wed Nov 15 07:45:28 2023 +0100 Hide catmull curve type when possible commit 520642975bda8de23c51e2b350c637a93115b08c Author: cs Date: Wed Nov 15 07:45:09 2023 +0100 Fix control point hover text and context menu commit 8cd1f08a923b1b38e7b096e59211c0714089d1e5 Author: Bartłomiej Dach Date: Wed Nov 15 13:33:12 2023 +0900 Fix argon health bar folding in on itself commit ceeaf5b67c527c787b8d34eb3594207ed9ac14d7 Author: cs Date: Wed Nov 15 07:09:33 2023 +0100 CI fixes and small tweaks commit aac1854d832ff8ad48333ed0afd968ab50dcf712 Author: Dean Herbert Date: Wed Nov 15 14:08:05 2023 +0900 Add test coverage of layout retrievable after importing modified skins commit a5e1dd8107a8770ab8698cc39a17df2e81847a8b Author: Dean Herbert Date: Wed Nov 15 14:07:51 2023 +0900 Add test coverage of deserialising a modified Argon skin commit 62352ce5f3b6ce56c310a83dccd11d9eb15f90fa Author: Joseph Madamba Date: Tue Nov 14 20:45:23 2023 -0800 Add ability to toggle labels on argon counter components commit 87ace7565dfffebbcfb34f48743406a0c68d1065 Author: Joseph Madamba Date: Tue Nov 14 20:44:33 2023 -0800 Use existing localisation for argon counter component labels commit 71714f8f6e6bd7d2caf9214ff267c05e550352e7 Author: Bartłomiej Dach Date: Wed Nov 15 13:33:03 2023 +0900 Add back test step for testing out argon health bar width commit 10be2335621657391be8e2b7a5395738f61f65b6 Merge: 3b619d4c34 159cf41f82 Author: Dean Herbert Date: Wed Nov 15 13:30:36 2023 +0900 Merge pull request #25466 from bdach/argon-health-initial-width Fix default argon health bar width being zero commit 159cf41f824546013c22ec454fe1bb33a460f2d1 Author: Bartłomiej Dach Date: Wed Nov 15 12:24:47 2023 +0900 Fix default argon health bar width being zero Closes #25460. commit 3b619d4c34ef362344f5dd5ab83dba7fece2e604 Merge: 711bf14c06 2264e1e249 Author: Dean Herbert Date: Wed Nov 15 11:10:59 2023 +0900 Merge pull request #25458 from Joehuu/corner-radius-localisation commit 2264e1e2493b69d0455f57639e60e3e2e10f7e96 Author: Dean Herbert Date: Wed Nov 15 10:45:01 2023 +0900 Change default value and range of `BoxElement`'s corner radius to match other usages commit 74fb1b5f81475121af75072367759a241aa4db38 Author: Dean Herbert Date: Wed Nov 15 10:40:59 2023 +0900 Rename property to match expctations commit 535282ba7d90303058c429c564c9d473afaf8e99 Author: Joseph Madamba Date: Tue Nov 14 14:13:20 2023 -0800 Use existing localisation for corner radius in `BoxElement` commit 711bf14c069a7a060d48ea08ec5d58397caa17bc Merge: 6e0375e3e8 9a7d7dda2a Author: Bartłomiej Dach Date: Tue Nov 14 23:11:39 2023 +0900 Merge pull request #25443 from peppy/fix-argon-custom-skins Fix customised argon skins no longer loading due to incorrect resource store specification commit 6e0375e3e8d2177c6acaf62e6a1973af2be10cc7 Merge: 572ec918d6 83f8f03c7e Author: Dean Herbert Date: Tue Nov 14 23:10:03 2023 +0900 Merge pull request #25442 from bdach/argon-health-bar-sizing-broken Fix argon health bar not relative sizing correctly commit 9a7d7dda2ae564fef11f3e544be339da42abb8d8 Author: Dean Herbert Date: Tue Nov 14 23:04:11 2023 +0900 Update resources commit a745642f764cf28b37800936186399f459cdd47d Author: Dean Herbert Date: Tue Nov 14 22:01:56 2023 +0900 Fix customised argon skins no longer loading due to incorrect resource store spec commit 83f8f03c7e3b173766e9c715bd7869929082600b Author: Bartłomiej Dach Date: Tue Nov 14 21:46:57 2023 +0900 Fix argon health bar not relative sizing correctly commit 572ec918d678183b2845bf3f00197e0bc84e31dc Merge: bb2f38d189 70d2de5669 Author: Dean Herbert Date: Tue Nov 14 17:18:38 2023 +0900 Merge pull request #25432 from bdach/touch-device-fixes Fix some touch device-related issues commit 90ec6895d100dea67e282c75a57779ffa87d0f5d Author: Thomas Müller-Höhne Date: Tue Nov 14 16:52:45 2023 +0900 Automatic red control point generation & corner threshold commit 70d2de56695800a2ca14a027d32cf2c36153e8f5 Author: Bartłomiej Dach Date: Tue Nov 14 16:35:16 2023 +0900 Move song select touch detector to solo implementation It should not run in multiplayer. Even if we wanted to allow touch-only playlist items at some point, the current behaviour of multiplayer song selects with respect to touch device mod is currently just broken. commit 69c2c0e4278d4d419b3ee1ea11f4c8e491514247 Author: Bartłomiej Dach Date: Tue Nov 14 16:30:08 2023 +0900 Fix touch device mod declared valid for multiplayer Mostly matters for web, so that it doesn't permit creation of playlist items with touch device inside. commit fa976a5aa0eeb94dccbcd58b00d51a1c9d7e52df Author: cs Date: Mon Nov 13 08:24:09 2023 +0100 Fix code style/quality issues commit 8ad8764947835e9ce4070338b6e1ea81016df2b1 Author: Dean Herbert Date: Mon Nov 13 14:06:18 2023 +0900 Update framework commit e6b4dfba369ee790ee0cee427aa702a935ce341b Author: Thomas Müller-Höhne Date: Mon Nov 13 12:49:59 2023 +0900 Fix doubled control point at beginning of drawn slider commit c24b3543ab271536b2b98c3c4777a174bc0621c1 Author: Thomas Müller-Höhne Date: Mon Nov 13 12:47:12 2023 +0900 Fix OnDragStart on macOS commit fab6fc9adb633d82d88afe4c76b1313946032ab4 Author: ratinfx Date: Sun Nov 12 15:09:15 2023 +0100 Updated comments, renamed method commit 4e7c40f1d7392376d68989ad5fa26e53430c55c6 Author: ratinfx Date: Sun Nov 12 14:58:46 2023 +0100 Do Split and Parse before checking HitObjects commit bb2f38d189b4a1a6ff888f5a74caf90ec60bf746 Merge: 469b9e2546 7d26de723a Author: Bartłomiej Dach Date: Sun Nov 12 20:47:55 2023 +0900 Merge pull request #25411 from peppy/fix-key-counter-sizing-woes Refactor `KeyCounterDisplay` to use autosize commit 469b9e2546a0eea247f19bdc9e793170fe7c7b05 Author: Dean Herbert Date: Sun Nov 12 17:28:15 2023 +0900 Increase size and adjust positioning of max combo display in argon skin commit 7d26de723a789b14f76fbb18b6b4be4b6a7aba93 Merge: 798e677c09 31feeb5ddc Author: Bartłomiej Dach Date: Sun Nov 12 17:23:31 2023 +0900 Merge branch 'master' into fix-key-counter-sizing-woes commit 31feeb5ddc616bb437c052b2b1680070c9d72563 Author: Dean Herbert Date: Sun Nov 12 17:21:17 2023 +0900 Disable new rider EAP inspection in test class commit 798e677c092a4ad02e0fe0a81163c14b57ff90d4 Author: Dean Herbert Date: Sun Nov 12 15:12:04 2023 +0900 Refactor `KeyCounterDisplay` to use autosize A previous attempt at this was unsuccessful due to a partially off-screen elements not getting the correct size early enough (see https://github.com/ppy/osu/issues/14793). This can be accounted for by setting `AlwaysPresent` when visibility is expected. This fixes [test failures](https://github.com/ppy/osu/actions/runs/6838444698/job/18595535795) due to the newly added `Width` / `Height` being persisted with floating-point errors (by not persisting the values in the first place, via `AutoSize.Both`). commit b995c96dca4e1163edaa8c67fe878425f6b91399 Merge: ccfdf1ffd6 3e8c89e282 Author: Dean Herbert Date: Sun Nov 12 12:14:26 2023 +0900 Merge pull request #25226 from frenzibyte/gameplay-hud-redesign/counters commit 3e8c89e282c74874a8c6885228910d70b64d2e95 Author: Bartłomiej Dach Date: Sun Nov 12 07:42:41 2023 +0900 Fix one more reference to removed setting commit c3201d59449a6b281bcbf904871c526dc8873141 Merge: 04a16b3596 ccfdf1ffd6 Author: Bartłomiej Dach Date: Sun Nov 12 07:33:50 2023 +0900 Merge branch 'master' into gameplay-hud-redesign/counters commit ccfdf1ffd6b34aafa91cfce634b63d8fe8556267 Merge: c5bbd5ac8a 50789d2e18 Author: Bartłomiej Dach Date: Sun Nov 12 07:31:51 2023 +0900 Merge pull request #25402 from peppy/skin-size-editing Add support for adjusting size of skin elements commit c367697559dc8981ce601e44afa45a3ce46a6dc9 Author: ratinfx Date: Sat Nov 11 16:14:26 2023 +0100 Changed TIME_REGEX to accept everything in the parentheses - changed osu-web link to the current value commit 54b8244a18ad3e74d40962be20cab996ba63e90d Author: cs Date: Sat Nov 11 15:02:06 2023 +0100 CI Fixup commit 04a16b35966daf6a0ce3a42096be7857f2ec15f2 Merge: ea556abad8 c5bbd5ac8a Author: Dean Herbert Date: Sat Nov 11 22:38:39 2023 +0900 Merge branch 'master' into gameplay-hud-redesign/counters commit 6ddecfd8062d6b1b0d62a6064d7d0b0b2c8d4760 Author: ratinfx Date: Sat Nov 11 14:13:06 2023 +0100 Update Test cases commit 4e1e19728cb8ff9e11f18ab9c0e8635c2cc2ba9a Author: ratinfx Date: Sat Nov 11 14:02:42 2023 +0100 Refactor HitObject selection in Composer commit c5bbd5ac8a7cac4d7fbf2650d54992acdd8cd8e6 Merge: ed59a379f1 b0aa4a4257 Author: Bartłomiej Dach Date: Sat Nov 11 21:48:21 2023 +0900 Merge pull request #25408 from peppy/skin-editor-export Add "export" item to skin editor menu commit 3f85aa79c5b4402b714da14295b6b796ffa8d6e6 Author: cs Date: Sat Nov 11 10:45:22 2023 +0100 Add free-hand drawing of sliders to the editor commit 926636cc035a17543d987ba9a9ba9c47fa5e7f7f Author: Thomas Müller-Höhne Date: Wed Nov 8 19:43:54 2023 +0900 Generalize Bezier curves to BSplines of Nth degree commit ea556abad802b4cb36ee7ad42b2b7c66b6029f56 Merge: 870e4ce27e 50789d2e18 Author: Bartłomiej Dach Date: Sat Nov 11 21:28:29 2023 +0900 Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters commit 50789d2e18a43dd3b2a2e99ea9487851972f35f9 Author: Bartłomiej Dach Date: Sat Nov 11 21:28:04 2023 +0900 Fix song progress bars not sizing vertically properly commit ee56b4d205f916ea9cf45543c72cce34f53b8a7e Author: Bartłomiej Dach Date: Sat Nov 11 20:55:47 2023 +0900 Use barely better assertion fail message in test commit 870e4ce27e751d2a7129d5fe396f2f96e74865bc Author: Bartłomiej Dach Date: Sat Nov 11 20:42:45 2023 +0900 Fix argon health display not handling invalidation correctly commit b0aa4a4257a5f590a1b65613cbf988b7034d7a9e Author: Dean Herbert Date: Sat Nov 11 20:34:35 2023 +0900 Add "export" item to skin editor menu commit b7972e3c8485b8a9b3ee4df20bd62b2ed59613a3 Merge: a02aeed50a 8d7539ab70 Author: Bartłomiej Dach Date: Sat Nov 11 20:15:49 2023 +0900 Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters commit ed59a379f16eb093a866422b36e2a80d9200bbfc Merge: 4b3fd1716a 61d336521d Author: Dean Herbert Date: Sat Nov 11 20:15:07 2023 +0900 Merge pull request #25407 from peppy/update-framework Update framework commit 8d7539ab70ab1a3cece963afa36802ddd7518682 Merge: b247b94ecb 4b3fd1716a Author: Bartłomiej Dach Date: Sat Nov 11 19:56:09 2023 +0900 Merge branch 'master' into skin-size-editing commit 4b3fd1716a4850ce54b31fdc87a81cc80f26f149 Merge: 1c63f1f89d 2428a97d44 Author: Bartłomiej Dach Date: Sat Nov 11 19:55:04 2023 +0900 Merge pull request #25406 from bdach/skin-editor-bad Fix skin editor not clearing undo history on skin change commit 61d336521da4adc3c8dcc6bacc20a7f23a306d34 Author: Dean Herbert Date: Sat Nov 11 19:48:56 2023 +0900 Update framework commit b247b94ecbdb5405de16ba489ef7a62b36cd7656 Author: Bartłomiej Dach Date: Sat Nov 11 19:15:20 2023 +0900 Revert test changes They were broken because `SerialisedDrawableInfo` is a reference type and as such equality checks will use reference equality rather than member equality. commit 2428a97d449b5e5f51ea2f9c8805c32521301a07 Author: Bartłomiej Dach Date: Sat Nov 11 17:02:21 2023 +0900 Fix editor not clearing undo history on skin change commit 21e1d68b15960c448d9876baaec51776febde22c Author: Bartłomiej Dach Date: Sat Nov 11 15:52:24 2023 +0900 Remove unused using directive commit 96da7a07bbd79bc67cbc58196bb38cd6c835c83a Author: Salman Ahmed Date: Sat Nov 11 02:57:29 2023 +0300 Add detailed explaination on existence of `ScheduleUntilTransitionEnd` commit bb912bc6161a8785f105e3da29f7e95f83261249 Author: Salman Ahmed Date: Sat Nov 11 02:57:17 2023 +0300 Avoid spinning another load thread on initial storyboard load commit 080f13e34d0f5f60381d813edfd590aa2b466194 Author: Salman Ahmed Date: Sat Nov 11 02:56:16 2023 +0300 Schedule outside of `UnloadStoryboard` and fix disposal happening on update thread commit 2e48569982039c9c1e6cb722190a6669ea09aee7 Author: Dean Herbert Date: Fri Nov 10 20:00:51 2023 +0900 Improve test comparison logic Doesn't really help that much with nunit output, but at least you can breakpoint and see the json kinda. commit 57cd5194ce06b16e03dc0dea32a0e81da80b1029 Author: Dean Herbert Date: Fri Nov 10 20:00:20 2023 +0900 Flip comparison to allow non-composite drawables to still get resized commit b7acbde719744a3aac166c676b792e9d87699612 Author: Bartłomiej Dach Date: Fri Nov 10 19:12:26 2023 +0900 Only store width/height of serialised drawable if it isn't automatically computed commit b6dcd7d55f0d421d85e2e97d00ae5704d1fb5487 Author: Bartłomiej Dach Date: Fri Nov 10 18:48:45 2023 +0900 Fix tests so that they actually assert something commit fbf94214a536a5b5aa7246d2ee34ee5ecacf8fb1 Author: Bartłomiej Dach Date: Fri Nov 10 18:36:09 2023 +0900 Fully delegate tooltip show/hide logic commit ec2200d54fff1cf823355571c2a3c827c3a19ca8 Author: Bartłomiej Dach Date: Fri Nov 10 18:26:08 2023 +0900 Remove another reference to bar length commit 26eae0bdeeed6670fc3a47b81abdc75afceda434 Author: Bartłomiej Dach Date: Fri Nov 10 18:25:39 2023 +0900 Remove unused using directive commit 43a4b34295471a2a4c0103aa9383ef75cbb8dc56 Author: Bartłomiej Dach Date: Fri Nov 10 18:20:14 2023 +0900 Fix typo commit c522a703eb4c7122863867124ac309a77b950dd0 Merge: 374e13b496 1c63f1f89d Author: Bartłomiej Dach Date: Fri Nov 10 18:19:27 2023 +0900 Merge branch 'master' into skin-size-editing commit 374e13b496dc3780e03f2c9f76a850ab0a8050e5 Author: Bartłomiej Dach Date: Fri Nov 10 18:18:45 2023 +0900 Remove argon health display bar length setting It is no longer needed. Intentionally not doing backwards migration to simplify things; users can fix their skins. commit 2c1f304f3b4faaa645edb3c138b915ad351c9fa0 Author: Bartłomiej Dach Date: Fri Nov 10 18:13:36 2023 +0900 Fix test failures due to fluctuations in needlessly-serialised automatic sizings commit 1c63f1f89dadef715138cf3979c17110db3fb9bf Merge: 74ccb0873e b7938e78a0 Author: Dean Herbert Date: Fri Nov 10 18:01:40 2023 +0900 Merge pull request #25348 from bdach/less-basic-touchscreen-detection Implement basic touchscreen detection commit 36d0bae42dfe95481b3e20751d8f7032b925e9df Author: Bartłomiej Dach Date: Fri Nov 10 17:57:16 2023 +0900 Restore mention of dependency on another ctor param commit 35e11c7c63b83122a45f5f9820aa6909ffb892bd Author: Dean Herbert Date: Fri Nov 10 17:51:30 2023 +0900 Rename diagonal scale variable and update xmldoc commit d0f1326a63da2187c80c7429cf386bfb3856c8c5 Author: Bartłomiej Dach Date: Fri Nov 10 17:54:48 2023 +0900 Fix formatting commit f25489cc7be71426891f50046b70aefdc24578de Author: Dean Herbert Date: Fri Nov 10 17:53:56 2023 +0900 Check X/Y sizing available separately to fix weird edge cases commit 46a219e01010e32827f3772aae77fece7de8bccf Author: Dean Herbert Date: Fri Nov 10 17:53:02 2023 +0900 Add comment explaining `AutoSize` change in `LegacySongProgress` commit 74ccb0873edcbaa7af5a26973c30bc17e9ec3cf0 Merge: 7c4e9506da 93ff82bc80 Author: Dean Herbert Date: Fri Nov 10 16:59:17 2023 +0900 Merge pull request #25403 from smoogipoo/attempt-fix-diffcalc-quotes Attempt to support quotes in handling of GH comment body commit a02aeed50af48f580a1c5d7fbb8a792f2a652f1a Author: Dean Herbert Date: Fri Nov 10 16:50:41 2023 +0900 Adjust combo animation slightly commit 67312a2db922287fef12c53f00be99b2aa79df8d Author: Dean Herbert Date: Fri Nov 10 16:43:47 2023 +0900 Remove `ArgonScoreWedge` and use `ArgonWedgePiece` directly commit b4ec62473e0e79638b439a9ffd677871014841b3 Author: Dean Herbert Date: Fri Nov 10 16:37:07 2023 +0900 Remove width/height bindables from `ArgonWedgePiece` commit fa5921862f99e6ed4a9757938ad77a8bd9d066ed Author: Dean Herbert Date: Fri Nov 10 16:19:42 2023 +0900 Update deserialising test commit b7938e78a0dc05f6847323058ef58f235e67324f Author: Bartłomiej Dach Date: Fri Nov 10 16:30:21 2023 +0900 Make sure test is in a break ...because apparently it may take a while to update the flag. commit 7c4e9506dad02f7e4282ac478f765d844e954654 Merge: a8cf105beb 1b08f317fb Author: Dean Herbert Date: Fri Nov 10 16:25:01 2023 +0900 Merge pull request #25399 from Susko3/mobile-touch-settings Show touch input settings on mobile commit 7db14baed74277383e4ac567577bb08b3b2aeea5 Author: Dean Herbert Date: Fri Nov 10 16:13:45 2023 +0900 Update resources commit 60df2722ab7d72e040b176d0d756493c6c2daf4e Author: Dean Herbert Date: Fri Nov 10 16:04:28 2023 +0900 Rename `RoundedLine` to `BoxElement` and make more generically useful commit 8690b0876928570e5df1d25a1568db6ec703ee05 Author: Bartłomiej Dach Date: Fri Nov 10 16:08:45 2023 +0900 Fix compose select box test failures commit 1818a84034c57f76335e06371b6a68296b0126f4 Author: Bartłomiej Dach Date: Fri Nov 10 15:52:02 2023 +0900 Rewrite tests to not rely on realtime clock Definitely faster, hopefully more reliable too. commit 4f90ac15fad7df54047abd01b6f88b6e28310277 Author: Dean Herbert Date: Fri Nov 10 15:39:17 2023 +0900 Reduce the default wireframe opacity a bit commit 7e0b41219cd916931bd18d32f87705624b4e723b Author: Dean Herbert Date: Fri Nov 10 15:26:37 2023 +0900 Change animation to only affect number portion, add miss animation commit e861681cd4a081b3cc557df725cb0d2737096ebc Author: Dean Herbert Date: Fri Nov 10 15:06:19 2023 +0900 Adjust argon rolling easings commit 7c3a626f4b2a1706cfc46295770b8673b374aee4 Author: Dean Herbert Date: Fri Nov 10 15:06:07 2023 +0900 Add basic animation for combo counter commit 6c1d48dfaf0e4f06489b22c32b437a2d18d5250a Author: Dean Herbert Date: Fri Nov 10 14:51:14 2023 +0900 Remove unused function commit 99d9db5b76ba5292398201039e75fcb0a9bcc1d7 Author: Dean Herbert Date: Fri Nov 10 14:03:24 2023 +0900 Use a better default size for line commit f31c1c9c7941db573a9516710e42e53946947e25 Author: Dean Herbert Date: Fri Nov 10 12:58:07 2023 +0900 Rename and move skinnable line component to a more commomn place commit a8cf105beb7d8f746c4df2957d448dabc86044d2 Merge: 1a8636638d 44c0442f4f Author: Dan Balasescu Date: Fri Nov 10 15:07:05 2023 +0900 Merge pull request #25342 from peppy/slider-combo-matching-2 Fix osu! (slider) combo not matching expectations when classic mod is disabled commit 93ff82bc80c8bc06bc78149fd49584396ca982bd Author: Dan Balasescu Date: Fri Nov 10 14:52:03 2023 +0900 Attempt to support quotes in handling of GH comment body commit 175dae49c623bfa8632608e204cac168d0b9723a Author: Dean Herbert Date: Fri Nov 10 14:43:51 2023 +0900 Reset scale per axis commit 0add035c674d59bd36ef129d474a76550e3ced92 Author: Dean Herbert Date: Fri Nov 10 14:31:02 2023 +0900 Disable resizing of `LegacySongProgress` Because it looks bad. commit fb361a4e0a8152bb35fe16cdc98bf06993f64a67 Author: Dean Herbert Date: Fri Nov 10 14:25:55 2023 +0900 Reset size along with scale for relative items commit ec3b6e47fb7c6b302e633132362bfe54873a58a6 Author: Dean Herbert Date: Fri Nov 10 14:17:11 2023 +0900 Change selection handling to adjust `Size` instead of `Scale` for edge nodes commit b0c5b3cb1097861506b11862b996b91afe7a384a Author: Dean Herbert Date: Fri Nov 10 14:15:42 2023 +0900 Add `Size` to serialised components of a `SerialisedDrawableInfo` commit 44c0442f4fc7f29f94ea1acad609ab8a676788d0 Author: Dan Balasescu Date: Fri Nov 10 14:00:34 2023 +0900 Adjust comment on Slider's judgement commit 1a8636638dd8a7e8a7f9584aa5fa483e21305981 Merge: 8d47c64325 12a148d108 Author: Bartłomiej Dach Date: Fri Nov 10 05:01:21 2023 +0100 Merge pull request #25385 from peppy/update-squirrel Update squirrel to latest release commit f13648418b82f7158a733588e8caf4f094efc1ec Author: Dean Herbert Date: Fri Nov 10 12:10:52 2023 +0900 Update `HitResultTest` to be more conformant to original expectations commit fb02c317507b7c58770bdd52984eb6a0f91f9b53 Author: Dean Herbert Date: Fri Nov 10 12:09:48 2023 +0900 Fix typo in assert step Co-authored-by: Bartłomiej Dach commit e0a5ec5352d0edf5d73513e203cdeda51624a302 Author: Dean Herbert Date: Fri Nov 10 12:09:16 2023 +0900 Revert incorrect classic mod test assertions commit 7fc2050f7227424b7e734260126146c48e99358e Author: Dean Herbert Date: Fri Nov 10 11:52:34 2023 +0900 Rename variables and mak seconary tooltip type work again commit d3af3c615f01fafb22dc4d0dbeeeb417c73a72c0 Merge: 6f5d905ce7 8d47c64325 Author: Salman Ahmed Date: Fri Nov 10 01:04:03 2023 +0300 Merge branch 'master' into gameplay-hud-redesign/counters commit 6f5d905ce766da9b2e3753585a41298118e9c6b9 Author: Salman Ahmed Date: Fri Nov 10 00:34:29 2023 +0300 Update argon accuracy counter design commit 59998b507acf084cc8d4ffbe85e16d1f3fab9229 Author: Salman Ahmed Date: Thu Nov 9 23:23:49 2023 +0300 Hide background sprite when storyboard finishes loading commit e9471589697083d8ea2214b299aca226085e7de9 Author: Salman Ahmed Date: Thu Nov 9 23:03:01 2023 +0300 Remove fade out transition Unnecessary addition from this PR, makes the background fade to ugly black during transition between screens. commit cc9aeb53079f6f00af307fb0544e0335d9eebcc8 Author: Salman Ahmed Date: Thu Nov 9 22:57:12 2023 +0300 Add test coverage commit 768a31b2f5ec05907f2e1cf18d4bb3f63ae83da1 Author: Salman Ahmed Date: Thu Nov 9 22:56:48 2023 +0300 Fix background crash on a beatmap with no storyboard commit bd8409219f079bcdd922ae2169d676608e512364 Author: Salman Ahmed Date: Wed Nov 8 06:37:29 2023 +0300 Unload beatmap storyboard background when no longer present commit d4722a398892a18f14e868ff471e9132004da8fd Author: Salman Ahmed Date: Thu Nov 9 17:20:05 2023 +0300 Add failing test case commit 1b08f317fbd1fac55276dc05c29b0339667f2871 Author: Susko3 Date: Thu Nov 9 15:12:24 2023 +0100 Show touch input settings on iOS This does not cover android since `TouchHandler` is SDL-based. commit 0c4c9aa4b515840611b3b39017ff73d04a3ecf1b Author: Susko3 Date: Thu Nov 9 14:37:10 2023 +0100 Show touch taps setting in player loader on mobile platforms commit 51cf85a9ab3806fe9294d33b24c52165a08aed6b Author: Susko3 Date: Thu Nov 9 13:22:49 2023 +0100 Add touch input settings to android Also updates touch settings so the touch handler can't be disabled on mobile. commit 8d47c64325ead06322d13cbeee82c46b23b262e8 Merge: 5180fa669b 4fa158e0d8 Author: Bartłomiej Dach Date: Thu Nov 9 14:39:01 2023 +0100 Merge pull request #25398 from peppy/tournament-split-players-better Split tournament player lists more equally commit 615d8384abcc3c412a831a70a73ed0f6c6173467 Author: Dean Herbert Date: Thu Nov 9 22:27:29 2023 +0900 Refactor everythign back to sanity commit edef31f426f8568afc3abf53b7611e525308c1d0 Author: Dean Herbert Date: Thu Nov 9 21:48:41 2023 +0900 Correctly propagate classic behaviour flag to tail commit 1ae3265f925911c3a1f7f640805765b68dc5d335 Author: Dean Herbert Date: Thu Nov 9 21:24:30 2023 +0900 Update tests in line with new behaviour commit 4fa158e0d832f44cddefac1b0dd7b94f879e3993 Author: Dean Herbert Date: Thu Nov 9 21:35:37 2023 +0900 Split tournament player lists more equally commit 5180fa669ba55a5d22c6aca197ee5b315437acb7 Merge: 67dc3aa5b7 92e4a8666d Author: Bartłomiej Dach Date: Thu Nov 9 13:34:29 2023 +0100 Merge pull request #25343 from peppy/spinner-max-sample Continue to play spinner bonus sounds when MAX display occurs commit 4900a91c60fda24f76aeba4d2d2bf42cc1929e2d Author: Joshua Hegedus Date: Thu Nov 9 13:27:09 2023 +0100 fixed static analysis problems and finished the implementation commit ccb9ff826a87dbafbbeb0a0a572a404bc88c7e88 Author: Joshua Hegedus Date: Thu Nov 9 13:09:59 2023 +0100 fixed tests commit 92043f45a47b89a22695089d93aeb87c12553c58 Merge: d3c5988bf1 67dc3aa5b7 Author: Dean Herbert Date: Thu Nov 9 18:45:37 2023 +0900 Merge branch 'master' into slider-combo-matching-2 commit 02966bc02f61c776dc7333c7d0531338c7716927 Merge: f897c21b3f 67dc3aa5b7 Author: Dean Herbert Date: Thu Nov 9 18:19:23 2023 +0900 Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid commit 67dc3aa5b7efa4a722c9d51a7da7e16ceaed6d54 Merge: 67de1b34bd c00a1d948a Author: Dean Herbert Date: Thu Nov 9 18:19:02 2023 +0900 Merge pull request #25366 from Susko3/better-touch-settings Add "disable taps during gameplay" to touch input settings and related UI commit 67de1b34bd2ea9ec8c199e1adfbff16094aeacb4 Merge: 5ac285ed2f e3e752b912 Author: Dean Herbert Date: Thu Nov 9 18:03:47 2023 +0900 Merge pull request #25395 from nekodex/buttonsystem-updates SFX improvements for `ButtonSystem`/`MainMenu` commit e3e752b912ba0b14f9d2d2a96bc1695e65eb94cd Author: Dean Herbert Date: Thu Nov 9 17:56:58 2023 +0900 Update resources commit 63a0ea54109c93984501b66435febf676663cab4 Author: Bartłomiej Dach Date: Thu Nov 9 17:50:57 2023 +0900 Fix `PlayerTouchInputDetector` applying touch device mod when other inactive mods present commit 5d5c803cf6fc97c044551a8bd7d3d11f0db8f41c Author: Bartłomiej Dach Date: Thu Nov 9 17:48:43 2023 +0900 Add failing test case for touch device application during gameplay with incompatible mods active commit 13b599b9b64acb2fa5744e580f8df8d9fcff9fea Merge: 39ad91feea 5ac285ed2f Author: Bartłomiej Dach Date: Thu Nov 9 17:36:48 2023 +0900 Merge branch 'master' into less-basic-touchscreen-detection commit 8a47f05b1615e126c9841b52dd63576a5b1b521a Author: Jamie Taylor Date: Thu Nov 9 14:01:33 2023 +0900 Always play 'swoosh' sample when transitioning back to logo commit 12a148d1084b1a6f11525ff16c223ecb6ddd6927 Author: Dean Herbert Date: Thu Nov 9 12:26:41 2023 +0900 Use new initialisation structure for github sourced update manager commit f69c2ea39b46fff223c8372e6dd1d2a6b2da5bce Author: Jamie Taylor Date: Wed Nov 8 22:18:33 2023 +0900 Implement sample choking/muting for `ButtonSystem` samples commit f0a1df06aced3051a93684588a6f21a0bf0fafd0 Author: Jamie Taylor Date: Wed Nov 8 22:13:35 2023 +0900 Add 'swoosh' samples to accentuate `MainMenu` animations commit 17aa079cb1cd1ee7ae22942aa582507c37037c4d Author: Jamie Taylor Date: Wed Nov 8 22:08:05 2023 +0900 Use new tiered 'back' samples commit fc1a0cf645b345c1b2b0727313a4f11b207a3268 Author: Jamie Taylor Date: Thu Oct 19 16:20:10 2023 +0900 Update `ButtonSystem` to use new sample names commit 5ac285ed2f915bb828c9e0762ad5547cfe506e3f Merge: 626cfae3fe 38d16f620c Author: Dean Herbert Date: Wed Nov 8 18:56:00 2023 +0900 Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash Fix editor crash when creating a new difficulty in a non-existent beatmap commit 626cfae3feb9dd70ab347b44f488c80a836681b4 Merge: 9df8fc14e7 38847c3ac5 Author: Dean Herbert Date: Wed Nov 8 17:24:37 2023 +0900 Merge pull request #25386 from EVAST9919/bar-graph-smooth Ensure `BarGraph`'s draw quad is thick enough commit 38847c3ac5383c9fb69b7bf0b38aa8ea36b23b39 Author: Dean Herbert Date: Wed Nov 8 17:23:01 2023 +0900 Change test to move only on a toggle step commit 6c6baab1156f64388e5fcea3ad712cc7e24bb463 Author: Dean Herbert Date: Wed Nov 8 16:41:30 2023 +0900 Reword comment to explain why commit 9df8fc14e708b6024ab66f9e9c1fc1afabf9451c Merge: 34219c1103 c8d276281a Author: Dean Herbert Date: Wed Nov 8 12:46:59 2023 +0900 Merge pull request #25388 from Joehuu/kudosu-rankings Add ability to view kudosu rankings commit c8d276281ada839a37ab6eb484c36b9b7772a0d1 Author: Joseph Madamba Date: Tue Nov 7 15:49:11 2023 -0800 Fix flags not showing on kudosu rankings The `country` attribute is optional and not included in the kudosu rankings response so use `country_code` instead. commit 387de7ec244f1e5c7381693b6dad96a64630ce1f Author: Joseph Madamba Date: Tue Nov 7 15:53:41 2023 -0800 Add ability to view kudosu rankings commit 2ef17c56b115c3df3d7a539f7494ad568b3a3ddf Author: Salman Ahmed Date: Wed Nov 8 02:13:35 2023 +0300 Remove unused local commit d0fea381b18b5f19450f4d93951e0aed152a85c8 Author: Salman Ahmed Date: Wed Nov 8 02:13:16 2023 +0300 Update skin deserialisation archives commit 18c71c95ccc565255676140486f30a4ed6d3b04f Merge: 07b7e13633 34219c1103 Author: Salman Ahmed Date: Wed Nov 8 02:12:37 2023 +0300 Merge branch 'master' into gameplay-hud-redesign/counters commit 07b7e13633862e85522f0c1778c8dc06ee62724d Author: Salman Ahmed Date: Wed Nov 8 02:07:24 2023 +0300 Place health display in front of the score wedge commit 4de5454538b0dff1b8b4a020a7f12fcb294ccc06 Author: Salman Ahmed Date: Wed Nov 8 02:06:51 2023 +0300 Bring back left-side line next to health display Makes the score counter not look weird when it reaches 8 digits commit fdc714a248d1a9283649d12a11a14e7763bfa1dc Author: Salman Ahmed Date: Wed Nov 8 02:05:19 2023 +0300 Support percentages and ignore dot characters in wireframes part commit d30bac3f49af02f2473e9c1a71aacbdb8f42dd4e Author: Salman Ahmed Date: Wed Nov 8 01:49:13 2023 +0300 Move "required display digits" feature to reside in argon score counter commit e6d3085353886da1a196f6d0354eae86ba9469fa Author: Salman Ahmed Date: Wed Nov 8 01:48:21 2023 +0300 Update accuracy counter design commit cbea2db4bef9322b8dcbe9619d95cb918dcc3b55 Author: Salman Ahmed Date: Tue Nov 7 02:03:16 2023 +0300 Support absolute-sized health bar and use it for default layout commit b092b0093affc97453d4f14be7b7a68005d5ae31 Author: Andrei Zavatski Date: Mon Nov 6 21:13:36 2023 +0300 Make sure bar draw quad is thick enough commit c00a1d948a94b871c4b50099d3f5924d142714c4 Merge: 3e257f1e6c 34219c1103 Author: Dean Herbert Date: Tue Nov 7 23:21:59 2023 +0900 Merge branch 'master' into better-touch-settings commit 3e257f1e6c02795c6bbb6bf08f542707e8e6e827 Author: Dean Herbert Date: Tue Nov 7 23:21:51 2023 +0900 Remove unused using statements commit 34219c11030239aa1674981c22ab397620b090a6 Merge: ed02335e3e 7bedf7cf16 Author: Dean Herbert Date: Tue Nov 7 21:57:00 2023 +0900 Merge pull request #25364 from frenzibyte/fix-resume-cursor-following-settings Fix resume cursor following gameplay cursor scale setting commit 02d9f005d09df3bd755a337a7d63c3ef4353d8b0 Author: Dean Herbert Date: Tue Nov 7 21:27:02 2023 +0900 Update squirrel to latest release Quite a few fixes since our last update. See https://github.com/clowd/Clowd.Squirrel/releases. Of special note is [a fix for incomplete updates](https://github.com/clowd/Clowd.Squirrel/issues/182) which I believe we've seen cause issues in the wild before. commit 00268d0ccce3691e682f7ae2ff08cb6a9a1f88f8 Author: Susko3 Date: Tue Nov 7 13:09:30 2023 +0100 Remove unused using commit 7bedf7cf165e1a9a125eb74af636dca957e8fc0d Author: Dean Herbert Date: Tue Nov 7 21:08:49 2023 +0900 Move static method to end of file commit fcd73e62d2f98472e66524913c5f58fa2499d4f2 Author: Susko3 Date: Tue Nov 7 13:06:14 2023 +0100 Remove mobile specific changes Will be added back in a separate PR commit 81caa854e6a7ba3251658f1cd174bf6bad62b1ea Author: ratinfx Date: Tue Nov 7 13:02:46 2023 +0100 Separate Test cases by relevant rulesets commit 544d5d1d86416a179de9c6badd7833a8e53ca518 Author: ratinfx Date: Tue Nov 7 12:23:22 2023 +0100 Forgot a clock.Stop call commit 38c9a98e67e421a965d5979425ace752517e63e2 Author: Dean Herbert Date: Tue Nov 7 10:52:48 2023 +0900 Add failing test coverage commit bdbeb2bce4286122584e0c7f9dff61bdc5d57ca1 Author: ratinfx Date: Tue Nov 7 11:11:32 2023 +0100 Renamed CollectionChanged event handler commit aa87e0a44d469bbdfb9abe9bca13ea0323eda774 Author: ratinfx Date: Tue Nov 7 01:36:58 2023 +0100 HitObject Selection logic and separation for gamemodes + moved time_regex into EditorTimestampParser commit 44f127c8a86c9fa381118571c5af5e26f8cf141d Author: ratinfx Date: Tue Nov 7 01:02:45 2023 +0100 Renamed method and made private commit 0834b79cc7fcb78873e381754f709deba0be4693 Author: ratinfx Date: Tue Nov 7 00:56:24 2023 +0100 Renamed method and moved Notifications inside commit 8e8a88cfaf4852d4e80611677cb5948806096704 Author: ratinfx Date: Tue Nov 7 00:54:15 2023 +0100 Removed nullable line from Test commit 7385c3c97bb48b507127dd8709d658788adbaf78 Author: Susko3 Date: Tue Nov 7 00:17:15 2023 +0100 Move `InputSettings` children creation code to BDL - Avoids now obsolete variable name - Makes changing to touch detection easier (access to session statics in BDL) commit 05d941871860fc94db9d92d722d44eb4f190766a Author: Susko3 Date: Tue Nov 7 00:13:46 2023 +0100 Rename setting to `TouchDisableGameplayTaps` for better visibility when searching commit 0dbba13686388559a25558ebbd4a4fd17c858e1d Author: Salman Ahmed Date: Tue Nov 7 01:59:00 2023 +0300 Split argon score sprite text and update combo counter design commit 7c1c62ba8aef898bddaa6c07124a1053251bdf8a Author: Salman Ahmed Date: Tue Nov 7 01:58:26 2023 +0300 Remove argon combo wedge and update combo counter position commit ce36884ef05dbe1664e93ef9285abb43b0849067 Author: Salman Ahmed Date: Tue Nov 7 00:54:34 2023 +0300 Make score wireframes display up to required digits count commit 4c7db4c2625483d557f1e4b6964579adcb7a0060 Author: Salman Ahmed Date: Tue Nov 7 00:49:22 2023 +0300 Make score counter right-aligned commit 754e05213c452f1f1ddc1c3485ae9e4270b23979 Author: Salman Ahmed Date: Tue Nov 7 00:53:20 2023 +0300 Update argon score wedge design commit 01e59d134a9b8436404a1c6de4bc5cb07332dfe8 Author: Salman Ahmed Date: Tue Nov 7 00:48:51 2023 +0300 Adjust health bar settings on default components initialiser to match new layout commit a4ac50cf86f8cbd148eedf75b765c65ad34301b6 Author: Susko3 Date: Mon Nov 6 21:10:04 2023 +0100 Revert "Rename popup/binding string to `Toggle gameplay clicks/taps`" This reverts commit 0d8bfedf5d3693809e76471b9feb47ebf140e40b. commit ed02335e3eb802c1865a653eac0af1b1050f3121 Merge: 9f6304b9ab a136f272cf Author: Dean Herbert Date: Tue Nov 7 05:08:47 2023 +0900 Merge pull request #25377 from bdach/system-mod-better-colours commit f8b5ecc92a2e303a87a23c218a24c103881cb8c5 Author: Susko3 Date: Mon Nov 6 21:07:15 2023 +0100 Update UI to use the new setting commit ea357bafddd9970fb2c7f06686e1604b6caca76f Author: Susko3 Date: Mon Nov 6 20:53:22 2023 +0100 Fix tests by using the correct setting for touch input commit c1967a5cbb640cf296832efec00b392922c398c9 Author: Susko3 Date: Mon Nov 6 20:43:24 2023 +0100 Make tests fail commit d6e7145e1c676ff45eb820f42375500cba43c3a1 Author: Susko3 Date: Mon Nov 6 20:42:40 2023 +0100 Add new setting for GameplayDisableTaps commit 38d16f620cdef1ab457ce2b82c5c9d1d91113761 Author: Salman Ahmed Date: Mon Nov 6 21:55:00 2023 +0300 Alter test case to comply with new behaviour commit b2749943e27ae31fb392b1bbad918cbd9432412e Author: Salman Ahmed Date: Mon Nov 6 21:52:46 2023 +0300 Display "required save" popup when creating another difficulty on a new beatmap commit 944fee56f8d8e61895882a5c55c9d6ff0e6c637e Author: Salman Ahmed Date: Mon Nov 6 21:48:47 2023 +0300 Add failing test case commit 9d10d93085cd3cde44d63836911bc607d5618901 Author: Andrei Zavatski Date: Mon Nov 6 20:45:52 2023 +0300 Adjust test scene to see graph flickering commit a136f272cf78ec3572bc13bdcf0de47b74789a73 Author: Bartłomiej Dach Date: Mon Nov 6 16:40:57 2023 +0100 Just use yellow for system mods commit 073249dafb3605a36bb8482f73f2dac1b7733b9f Author: Salman Ahmed Date: Mon Nov 6 18:35:46 2023 +0300 Allow tinkering with cursor-related settings in resume overlay test scene commit e12ee29a942279becf7ca4fd3816af1787b3fce8 Author: Salman Ahmed Date: Mon Nov 6 18:35:30 2023 +0300 Update existing test coverage commit 75fbbb35ad2f88524670a19312dcb43569db8190 Author: Salman Ahmed Date: Mon Nov 6 18:28:51 2023 +0300 Move cursor scale application within `OsuCursor` Doing so takes down two birds with one stone. 1. `ResumeOverlay` having to manually apply cursor scale to its "resume cursor". 2. Resume cursor input handling scaling up with the gameplay setting. Now, only the sprite itself gets scaled. commit 915feeffb05389da36e9eb4e1c75f962202b3703 Author: Salman Ahmed Date: Mon Nov 6 17:37:25 2023 +0300 Revert gameplay cursor scale changes commit f897c21b3f5b57b5892f25cef3644aabf82d7c43 Author: Joshua Hegedus Date: Mon Nov 6 15:25:12 2023 +0100 partial change commit a01f6187f4738f85376cb820315d95d8c4545e4c Author: Joshua Hegedus Date: Mon Nov 6 14:52:06 2023 +0100 testing the tooltip commit 9f6304b9ab612bcdb24c5eb33101f818b9d60909 Merge: 408ae84111 51c891e2e4 Author: Bartłomiej Dach Date: Mon Nov 6 12:40:11 2023 +0100 Merge pull request #25376 from peppy/verify-screen-refresh-on-enter Automatically refresh the verify screen's issue list on re-entering it commit 4bc36a6c90dfd051cd6202be7e4fec48c1b05080 Author: Bartłomiej Dach Date: Mon Nov 6 12:18:02 2023 +0100 Fix unused variable commit 034f53da4b1d79220d8af95055a203076ab88c87 Author: Joshua Hegedus Date: Mon Nov 6 11:54:57 2023 +0100 added isEnabled to tooltip commit 39ad91feea58e0a91e95b3a2be0889ff98be4ce6 Author: Bartłomiej Dach Date: Mon Nov 6 11:50:04 2023 +0100 Make debug input toggle post notifications commit 6deac9a5a45319d1536a9dc223a4efb07324a63c Author: Bartłomiej Dach Date: Mon Nov 6 11:24:56 2023 +0100 Use better colours for system mods commit 51c891e2e4ff17432a01bf4f9ee75ad8c1498883 Author: Dean Herbert Date: Mon Nov 6 19:34:34 2023 +0900 Automatically refresh the verify screen's issue list on re-entering it Addresses https://github.com/ppy/osu/discussions/25365. commit 718492a0b7d9c38b32102095c84393fbe5a792d9 Author: Joshua Hegedus Date: Mon Nov 6 11:29:15 2023 +0100 fixed DRY commit 682668ccf0f73bdbb98b800afcaff983399d391d Author: Bartłomiej Dach Date: Mon Nov 6 10:54:32 2023 +0100 Remove touch device toasts entirely commit 92e4a8666def6e4bcc66d008ca0d206ca6c6cbd8 Author: Dean Herbert Date: Mon Nov 6 18:43:47 2023 +0900 Add `spinnerbonus-max` support and fallback to `spinnerbonus` commit b219a371a93d82c3638df3b47f51e85d20f1fb94 Author: Dean Herbert Date: Mon Nov 6 18:29:51 2023 +0900 Move sample playback logic local to avoid edge case with no bonus ticks Can't see a better way of doing this. commit 86cf0a36cfb842cf97f074988a28c9958e9b0b81 Author: Dean Herbert Date: Mon Nov 6 18:16:31 2023 +0900 Add test coverage of spinner with no bonus ticks commit aa6f14b0247f2fe0768379b9a1ae03f75827ba86 Author: Dean Herbert Date: Mon Nov 6 18:16:04 2023 +0900 Fix spinner test hitting assertion when spinning too fast commit 204cd541e2b8876089c619abd94e97baafb97b8b Author: Bartłomiej Dach Date: Mon Nov 6 10:14:56 2023 +0100 Use placeholder mod icon for touch device commit 97fee6143c7b81d169452396a490b8293b521527 Author: Bartłomiej Dach Date: Mon Nov 6 10:08:19 2023 +0100 Rename touch "input handlers" to detectors commit 408ae841110854b17c963beb67c7aa68e9f55555 Merge: 41cd9a4db6 1f0b914251 Author: Bartłomiej Dach Date: Mon Nov 6 09:38:48 2023 +0100 Merge pull request #25375 from peppy/reset-rotation-skin-editor Add skin editor dropdown items to reset rotation and scale commit 41cd9a4db615290f557c664b9151c1c48ef64667 Merge: 5ef8500d2a 69d6feb5a8 Author: Bartłomiej Dach Date: Mon Nov 6 09:34:11 2023 +0100 Merge pull request #25374 from peppy/add-skinnable-player-name Add player name skin component commit e2928cc6b96f816320f238e5f653bd75c5ed9ca3 Author: Dean Herbert Date: Mon Nov 6 17:32:39 2023 +0900 Fix incorrect assertion check targets (and flip assertion for miss case) commit 4a70f2435c574b82829a5d2508ae29f7d2e3a2fb Author: Joshua Hegedus Date: Mon Nov 6 09:22:50 2023 +0100 fixed showUsernameTooltip commit 5ef8500d2ac66aaa647833d2fe07faa8b9315fcb Merge: bc9cdb4ce0 0915ac8891 Author: Bartłomiej Dach Date: Mon Nov 6 09:19:49 2023 +0100 Merge pull request #25349 from Joehuu/argon-key-counter-upright Keep `ArgonKeyCounterDisplay` text upright commit b62811633f07820848ec960e228989f02e30f68c Author: Dean Herbert Date: Mon Nov 6 17:17:19 2023 +0900 Add test coverage of touching and missing not enabled touch mod commit 69d6feb5a8b9137aaf74956945b897d7741fe3a3 Author: Bartłomiej Dach Date: Mon Nov 6 08:51:31 2023 +0100 Add test coverage for player name skin component commit b45d8c785cd662796c6098f72aadf589b99161e4 Author: Joshua Hegedus Date: Mon Nov 6 08:38:34 2023 +0100 fixed review findings commit 0915ac8891f1a5036a325d95b870d29c0daeb733 Author: Dean Herbert Date: Mon Nov 6 16:32:12 2023 +0900 Use left aligned text for non-rotate key counter commit 1f0b914251bc61d82bf9e3db207e75399a600806 Author: Dean Herbert Date: Mon Nov 6 16:18:33 2023 +0900 Add skin editor dropdown items to reset rotation and scale commit 40d081ee2de0940600f94ff126259b019622483b Author: Dean Herbert Date: Mon Nov 6 16:05:50 2023 +0900 Add note about `Width` requirement in `UserGridPanel` commit 7ba07ab5305dc0be39bddc06967d826e36bfeea8 Author: Bartłomiej Dach Date: Mon Nov 6 08:05:42 2023 +0100 Add protections against handling system mods in mod presets commit adb9ca5a13cb920c6554457392a9f715b85038ee Author: Bartłomiej Dach Date: Mon Nov 6 07:56:09 2023 +0100 Add failing test coverage for incorrect treatment of TD in mod presets commit 3c72c5bccd21b4127ceaae9346ec04e6b059db9f Author: Bartłomiej Dach Date: Mon Nov 6 07:48:09 2023 +0100 Steer touch input flag via bindable rather than config manager commit 11bd801795f5a838cfc478e486586476fed2eb30 Author: Bartłomiej Dach Date: Mon Nov 6 07:44:25 2023 +0100 Use more intelligent default for `TouchInputActive` commit febd004bda4a0d17d9e14f7250bb1aeebf86455e Merge: a78fab0e7d bc9cdb4ce0 Author: Bartłomiej Dach Date: Mon Nov 6 07:41:35 2023 +0100 Merge branch 'master' into less-basic-touchscreen-detection commit e2b07628fb5719540ea3d1405de25a83b469b8da Author: Dean Herbert Date: Mon Nov 6 15:24:12 2023 +0900 Add player name skin component 3 minute implementation. Addresses https://github.com/ppy/osu/discussions/25340. commit 277cf7dc127cfacaf62f51bc88e0a0a3c1474382 Author: ratinfx Date: Sun Nov 5 18:26:51 2023 +0100 Ensure every SelectedItem is alive and has Blueprint commit 9947897c5f83c7298c381015a95673902486b52d Author: Susko3 Date: Sun Nov 5 12:53:40 2023 +0100 Use appropriate clicks/taps text in player loader input settings commit 0d8bfedf5d3693809e76471b9feb47ebf140e40b Author: Susko3 Date: Sun Nov 5 12:44:22 2023 +0100 Rename popup/binding string to `Toggle gameplay clicks/taps` commit fa1d1df594d3f5307e01207952c4eb6be7ee3494 Author: Susko3 Date: Sun Nov 5 12:43:14 2023 +0100 Rename mouse button string to `Disable clicks during gameplay` commit 86fb33cb90b500dba57b2c199b381e7e8473b558 Author: Susko3 Date: Sun Nov 5 12:40:06 2023 +0100 Add disable taps checkbox to touch input settings commit 9cb331641c39b9a1b54b192be3420e0db8b7ba68 Author: Salman Ahmed Date: Sun Nov 5 06:34:09 2023 +0300 Rename container commit 99405a2bbd38e999672d0fe89c83e56b845a0bdf Author: Salman Ahmed Date: Sun Nov 5 06:28:34 2023 +0300 Tidy up resume overlay test scene commit 48a75f6152705c5377b116f0dc2b6cf598036bb3 Author: Salman Ahmed Date: Sun Nov 5 06:28:10 2023 +0300 Fix resume cursor following gameplay cursor scale setting commit 634795e45f12676c277be583bad61c29cc3ec22a Author: Salman Ahmed Date: Sun Nov 5 02:50:14 2023 +0300 Adjust failing test scenes commit 1d4f4cf4c362e0766e92231714c6431900fbc1b7 Merge: 77f5a4cdf5 bc9cdb4ce0 Author: Salman Ahmed Date: Sun Nov 5 02:02:36 2023 +0300 Merge branch 'master' into gameplay-hud-redesign/counters commit 77f5a4cdf53fca660a71140b84c9897439ddbf2e Author: Salman Ahmed Date: Sun Nov 5 02:01:26 2023 +0300 Update skin deserialisation archive commit 6c3169a0ed6e9f0f9e1e7d668993e04861f63540 Author: Salman Ahmed Date: Sun Nov 5 01:56:45 2023 +0300 Remove PP wedge and logic for gameplay layout commit a23dfbeab55bb3e195407bcf436444f150d5a355 Author: Salman Ahmed Date: Sun Nov 5 01:55:13 2023 +0300 Revert "Abstractify PP counter logic from the "Triangles" implementation" This reverts commit daf4a03fd092ac84955a8f63fa3c45200a28cf04. commit 58a830fc5b2bd749ebccd7cf1b5e0f12b6f4c117 Author: Salman Ahmed Date: Sun Nov 5 01:55:12 2023 +0300 Revert "Add "Argon" performance points counter" This reverts commit 56eeb117ce2011ad4b80cf32c3b015eb482d7c9b. commit 1c844a155e97059e23cdae6470401d217fa88db3 Author: Salman Ahmed Date: Sun Nov 5 01:52:12 2023 +0300 Remove health line detail commit 91cf237fc12fcbecc6d1345310717407f559a32e Author: Salman Ahmed Date: Sat Nov 4 02:46:28 2023 +0300 Revert health display settings changes commit 7492d953aee303732df79ba0267f34dbacfbb3e9 Author: ratinfx Date: Sat Nov 4 21:17:58 2023 +0100 Moved error checks into Editor - Invoke Action on error to Notify user - added some comments commit ec290ae953c9dffec44bb71e1fcde4e0785ef843 Author: Joshua Hegedus Date: Sat Nov 4 19:03:23 2023 +0100 added tests commit a70bfca501312bc587c230064a6269b20a714c82 Author: Joshua Hegedus Date: Thu Nov 2 09:16:25 2023 +0100 added usergrid for tooltip commit 19cdf99df8f101b5c676528826a39cb905c1efe5 Author: ratinfx Date: Sat Nov 4 12:04:58 2023 +0100 Fixed up tests commit f867cff8c79c55f75708ea41c699c6d7a557485c Author: ratinfx Date: Sat Nov 4 03:42:08 2023 +0100 Added OpenEditorTimestamp Tests commit 60f62faec3712e1086af4d0a7462c60d0efbc257 Author: ratinfx Date: Sat Nov 4 03:30:38 2023 +0100 Renamed Editor method commit f854e78bb03f6117b1cfb8b0579e867d1aae093f Author: ratinfx Date: Sat Nov 4 03:29:05 2023 +0100 Added ExclamationTriangle Icon to notifications commit 43ab7f49426626b3d9536af481221c98e7dca86a Author: ratinfx Date: Sat Nov 4 02:01:18 2023 +0100 Added OpenEditorTimestamp base implementation commit d3c5988bf14f42b31064342c211ade4b7024b858 Merge: 818432fab4 bc9cdb4ce0 Author: Bartłomiej Dach Date: Fri Nov 3 09:11:39 2023 +0100 Merge branch 'master' into slider-combo-matching-2 commit 3f8baf913b46b884d9cbb5530721d58913403b5a Author: Joseph Madamba Date: Thu Nov 2 19:46:09 2023 -0700 Add 100 and 1000 key press step to test overflow commit e3b3ce6c84102e34778c4fd25bb39e366dc0977f Author: Joseph Madamba Date: Thu Nov 2 18:44:56 2023 -0700 Fix test overflowing on widescreen + add default (triangles) key counter testing commit 16731ff85ff90b8c9e20b40b0358bc2c128782c2 Author: Joseph Madamba Date: Thu Nov 2 18:20:15 2023 -0700 Fix text positioning commit b3dfe19472a2a6a7f7d2b2d34570036df8f6b49c Author: Joseph Madamba Date: Thu Nov 2 18:17:25 2023 -0700 Fix `UprightAspectMaintainingContainer` not being centred commit 090601b485bdec297ef3d723f7254b54ca335d3b Author: Joseph Madamba Date: Thu Nov 2 18:12:39 2023 -0700 Apply peppy's upright key counter attempt diff Co-Authored-By: Dean Herbert commit bc9cdb4ce07fcc7fc16117121f6bb620a8094c36 Merge: efb4458061 a0757ce13f Author: Dan Balasescu Date: Fri Nov 3 11:27:22 2023 +0900 Merge pull request #25341 from peppy/slider-combo-matching Rename and invert flags for slider classic behaviours commit a78fab0e7d74d41b58ecefbe74854370ffee08c9 Author: Bartłomiej Dach Date: Fri Nov 3 00:17:29 2023 +0100 Do not hardcode ruleset name in touch device detection toast commit a613292802ce0fe5f53b31de761e6dcdf3135113 Author: Bartłomiej Dach Date: Thu Nov 2 23:44:40 2023 +0100 Fix unknown mod test failure commit 8e9006b5d5c263cf79fed1e74532e7de5dfca122 Author: Bartłomiej Dach Date: Thu Nov 2 22:27:16 2023 +0100 Declare Touch Device incompatible with Autopilot With Autopilot active, Touch Device no longer matters. commit 0dd0a84312e224bb2cb5396cdc479e2b04688000 Author: Bartłomiej Dach Date: Thu Nov 2 22:26:52 2023 +0100 Move player touch handler to `SubmittingPlayer` Shouldn't be there in `ReplayPlayer`. commit 8784dd42c0c4c1aba37cb0cc4f5cda8055811a69 Author: Bartłomiej Dach Date: Thu Nov 2 22:20:17 2023 +0100 Do not attempt to turn on Touch Device in song select with autoplay active commit d25b54c06d660455484762a011c162c6cb68dfd7 Author: Bartłomiej Dach Date: Thu Nov 2 22:14:38 2023 +0100 Split test into two They would fail on CI when written as one, and I don't care why. commit 3a6d65d395c1bf3c0e30429fec90be5e4fedb7c3 Author: Bartłomiej Dach Date: Thu Nov 2 19:51:21 2023 +0100 Touch up `PlayerTouchInputHandler` commit 4532d0ecdf12abd32b3d64cbab3b9e975f34c63d Author: Bartłomiej Dach Date: Thu Nov 2 19:48:34 2023 +0100 Add logging & debug facility for touch input interceptor commit c588f434e5f51bee3683c6114bc951fda40fb50c Author: Bartłomiej Dach Date: Tue Oct 31 13:54:18 2023 +0100 Fix song select touch handler causing crashes when song select is suspended commit ef555ed0cf442b98cb139de435e0e0815468c05e Author: Bartłomiej Dach Date: Mon Oct 30 15:48:00 2023 +0100 Fix test failures commit 21a4da463b11d557a815581cdb09121a9ea0a94d Author: Bartłomiej Dach Date: Tue Oct 31 13:47:50 2023 +0100 Add failing test covering crash scenario commit f2df02b60f7e78a4e1fad2c591c24dfe14271c1f Author: Bartłomiej Dach Date: Wed Oct 25 20:27:07 2023 +0200 Automatically activate touch device mod in player commit 29d4d81eaab886e0f99bd2c579a1425a41b4b17f Author: Bartłomiej Dach Date: Wed Oct 25 19:56:51 2023 +0200 Add test scene for basic touchscreen detection scenarios commit 2f6ff893b550a18ec1f4791d45c96c5dcb3e99cb Author: Bartłomiej Dach Date: Mon Oct 30 14:38:20 2023 +0100 Automatically activate and deactivate touch device mod in song select commit 980c900f43aa958e25d519e687a4a2e224d2399c Author: Bartłomiej Dach Date: Mon Oct 30 14:08:56 2023 +0100 Add component for game-wide touch detection commit 68efb3c110aa3617fb801cb8afe6b7fb15afcba1 Author: Bartłomiej Dach Date: Thu Nov 2 19:25:57 2023 +0100 Mark `ModTouchDevice` as always valid for submission commit 9f11a04cc731159c6d2c0e4f7084238f6bd88360 Author: Bartłomiej Dach Date: Mon Oct 30 13:24:01 2023 +0100 Generalise notion of 'touch device' mod commit a0757ce13f3156c526d51b7d3be6afcd47436230 Author: Bartłomiej Dach Date: Thu Nov 2 18:58:14 2023 +0100 Update xmldoc to match flipped flag semantics commit 86ede717cbeb705a7036276b49e5c53aeb6ecc53 Author: Bartłomiej Dach Date: Thu Nov 2 18:52:47 2023 +0100 Clean up comment commit ac6fb386d137a13eae242fa65cf417e3d6ec4abb Author: Dean Herbert Date: Thu Nov 2 23:42:52 2023 +0900 Remove nested ternary commit efb4458061f8eb3d9e04d1465ad6bf333c3e6500 Merge: e18d0b64de 998d709331 Author: Bartłomiej Dach Date: Thu Nov 2 12:40:57 2023 +0100 Merge pull request #25336 from peppy/mania-key-expand-mobile Add support for "argon" default skin to expand columns when on mobile devices commit 998d70933150c71e0cdbb5ebe4f968006ae30ebe Merge: 704f5a6de3 e18d0b64de Author: Bartłomiej Dach Date: Thu Nov 2 11:59:01 2023 +0100 Merge branch 'master' into mania-key-expand-mobile commit f0f595ca40ab02cd0637a50ce0246d05423fc0c6 Author: Dean Herbert Date: Thu Nov 2 19:52:49 2023 +0900 Continue to play spinner bonus sounds when MAX display occurs commit 704f5a6de3a4dba381efc0dc62a77ce1cb166f7a Author: Dean Herbert Date: Thu Nov 2 19:40:20 2023 +0900 Adjust sizing slightly to ensure we stay within 1366 limits commit 818432fab4279b6691286483b6be88eb663e84c3 Author: Dean Herbert Date: Thu Nov 2 19:27:55 2023 +0900 Fix non-classic osu! combo not matching expectations commit e18d0b64de9ee5cb67328818c92d983ee346c514 Merge: 64feea80db c83589cb74 Author: Bartłomiej Dach Date: Thu Nov 2 10:46:32 2023 +0100 Merge pull request #25338 from peppy/mania-mod-ordering Change osu!mania conversion mod ordering to be more appeasing commit bf9f20705f06e3094ae7e772f4ac59fa45472856 Author: Dean Herbert Date: Thu Nov 2 17:39:23 2023 +0900 Simplify classic behaviour flag to only need to be specified on the slider itself commit a7705284e7b56bcedaee756ec8f37432f029d62c Author: Dean Herbert Date: Thu Nov 2 18:02:47 2023 +0900 Add better commenting around `DrawableSliderHead` logic commit 9af2a5930cf3696ffecea558e94bcec01b642ace Author: Dean Herbert Date: Thu Nov 2 17:39:41 2023 +0900 Remove redundant passing of `Scale` to nested objects commit 9c1f4b552e651a8d163cd7adf17a0c6ff3e49f08 Author: Dean Herbert Date: Thu Nov 2 17:04:49 2023 +0900 Rename and invert flags for slider classic behaviours commit 64feea80dba69cccaba2e3a4db79ba9cc9e1e0e8 Merge: b7ab886848 48bdeaeff1 Author: Bartłomiej Dach Date: Thu Nov 2 09:32:09 2023 +0100 Merge pull request #25334 from peppy/fix-bubble-crash-again Fix another potential crash in bubbles mod commit b7ab88684846ee21e279c1f96be0b3ab5ffcf955 Merge: 57d8b5ddc9 ad82ada030 Author: Bartłomiej Dach Date: Thu Nov 2 09:07:44 2023 +0100 Merge pull request #25333 from peppy/fix-spinner-performance Fix all spinner ticks being alive and causing performance degradation commit ad82ada030715427397d6ef5b0a08b475dbfef31 Author: Bartłomiej Dach Date: Thu Nov 2 08:18:37 2023 +0100 Trim redundant comments commit c83589cb742db95d7fb21df6aa2c00836a01be89 Author: Dean Herbert Date: Thu Nov 2 15:49:10 2023 +0900 Change osu!mania conversion mod ordering to be more appeasing commit 6dab5ee4cfbad32710777b649d5fd5e6cc1d2c3e Author: Dean Herbert Date: Thu Nov 2 15:13:43 2023 +0900 Add support for "argon" default skin to expand columns when on mobile device Should ease those looking to play the game on mobile until we (potentially) have a better solution in the future. If this works out well, we can consider rolling it out to other skins. Closes https://github.com/ppy/osu/issues/23377. commit 48bdeaeff14f456abb371878307c91d79156832e Author: Dean Herbert Date: Thu Nov 2 02:42:36 2023 +0900 Fix another potential crash in bubbles mod Storing `DrawableHitObject` for later use is not safe – especially when accessing `HitObject` – as it's a pooled class. In the case here, it's important to note that `PrepareForUse` can be called a frame or more later in execution, which made this unsafe. Closes https://github.com/ppy/osu/issues/24444. commit c2de03aa44c85fccb29e5542c63c01d46dc7145d Author: Dean Herbert Date: Wed Nov 1 18:28:05 2023 +0900 Fix all spinner ticks being alive and causing performance degradation Regressed in https://github.com/ppy/osu/pull/25216. The new logic will ensure at least one tick is ready for judgement. There shouldn't be a case where more than one is needed in a single frame. commit 57d8b5ddc9989eceeff02bdc5c2b4d40514be336 Merge: 95d8ee8e9b a90f8dd4f6 Author: Dean Herbert Date: Wed Nov 1 15:48:47 2023 +0900 Merge pull request #25328 from bdach/mod-cleanups-docs Clean up mod usability flags commit a90f8dd4f63191209d593201a2bb1a00b7828a37 Author: Bartłomiej Dach Date: Tue Oct 31 16:20:33 2023 +0100 Seal a few more multiplayer playability flags of rate-changing mods Not really changing anything, just tightening things down to curb possible funny business. commit 955e2ed05166aeaf6073938661a9bc7197d9b816 Author: Bartłomiej Dach Date: Tue Oct 31 16:18:09 2023 +0100 Seal `UnknownMod` Not a class for extension. commit a644c75957247c8f16674ea47e1eec4a239f1159 Author: Bartłomiej Dach Date: Tue Oct 31 16:16:57 2023 +0100 Mark `ModScoreV2` as invalid for multiplayer Doesn't do much for the client; mostly a safety for osu-web's sake, as without the change it could theoretically fail to validate the mod properly in multiplayer contexts. commit 456f4ebba2208d4a764df157d02dcbbbe6dda544 Author: Bartłomiej Dach Date: Tue Oct 31 16:16:14 2023 +0100 Seal `ModScoreV2` Nobody should ever need to extend it. commit 3a2645efb17dbe9bee7251b4a8ecc0868cf8799d Author: Bartłomiej Dach Date: Tue Oct 31 16:15:10 2023 +0100 Seal `ModAutoplay` playability flags Can't do much more than that due to the unfortunate fact of Cinema inheriting from Autoplay. commit 7ea298a1b6a4f17a8ae3b505c599f04ac498e4ce Author: Bartłomiej Dach Date: Tue Oct 31 16:13:44 2023 +0100 Add xmldoc to `Mod` playability flags commit 95d8ee8e9bdf17df06ff0c20ba9d6881e474e96c Merge: bc2acc3e93 9f5a280bc2 Author: Dean Herbert Date: Tue Oct 31 22:13:42 2023 +0900 Merge pull request #25323 from bdach/fix-key-binding-test-failures Fix key binding row fire-and-forgetting writes commit 9f5a280bc22b1f88d20b7b885d4aa252f7feee7c Author: Bartłomiej Dach Date: Tue Oct 31 12:25:08 2023 +0100 Fix key binding row fire-and-forgetting writes Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129 This is what happens if you carelessly fire and forget. The working theory (that I'm not sure I have the tools to conclusively confirm) is that the async write from the key binding changing could fire _after_ the section is reset. I briefly considered having the test wait for the change, but given that the entirety of the surrounding flow is using sync operations, this just looks like a bug to me. And there's no real sane way to inject async into that flow due to dependence on `OsuButton.Action`. commit bc2acc3e93072336e3a06a437a6a8824e85d34c8 Merge: 850866e7f4 0d44b5af90 Author: Bartłomiej Dach Date: Tue Oct 31 11:02:59 2023 +0100 Merge pull request #25318 from peppy/fix-follow-point-scrathces Fix potential texture corruption when cropping gameplay textures of weird aspect ratios commit 850866e7f4ba91fba5eb09a9fd18dcb904902f6a Merge: 84fb0c63e5 64efc3d251 Author: Bartłomiej Dach Date: Tue Oct 31 09:37:29 2023 +0100 Merge pull request #25316 from peppy/metronome-always-play-tick Decouple metronome tick playback from pendulum movement commit 0d44b5af90d606657e63c9c386574dcd5e18c89f Author: Dean Herbert Date: Tue Oct 31 17:36:23 2023 +0900 Fix potential texture corruption when cropping gameplay textures of weird aspet ratios Closes https://github.com/ppy/osu/issues/25273. commit 84fb0c63e59a77a678d478a909e38469a1fffa26 Merge: af84704076 144006fbe8 Author: Bartłomiej Dach Date: Tue Oct 31 09:34:44 2023 +0100 Merge pull request #23823 from peppy/beat-divisor-select-text-on-click Select text in beat divisor popover automatically commit 144006fbe83e60b6ba5a0cab7856eb3c4416da28 Author: Bartłomiej Dach Date: Tue Oct 31 08:38:22 2023 +0100 Update autoselect implementation to work correctly with framework changes commit 8a68333425ee46b6c5fe149864a29a7b9b5481ec Merge: c1743dbe1d af84704076 Author: Bartłomiej Dach Date: Tue Oct 31 08:36:53 2023 +0100 Merge branch 'master' into beat-divisor-select-text-on-click commit af8470407643f7b6dae17bec98c29dffd673a554 Merge: fa220d34de 8c067dc584 Author: Bartłomiej Dach Date: Tue Oct 31 08:30:19 2023 +0100 Merge pull request #25315 from peppy/fix-flaky-tests Address some flaky tests from recent times commit 64efc3d251ef1c4ff39f2d3b2c25df4dc020ae6e Author: Dean Herbert Date: Tue Oct 31 15:33:40 2023 +0900 Decouple metronome tick playback from pendulum movement Not super happy about doing this, but it seems like it's in the best interest of editor usability. commit 8c067dc584066527badb6a9029f5ef31a932bba8 Author: Dean Herbert Date: Tue Oct 31 14:53:07 2023 +0900 Fix mod tests not waiting for presets to finish loading See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850. commit 7ceced70122d51ffc030074d1f3738645367be59 Author: Dean Herbert Date: Tue Oct 31 14:47:04 2023 +0900 Scope `TestPauseWithLargeOffset` to focus on what matters See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009 This test is to make sure we don't seek before the original pause time, so I've exposed that value precisely to avoid CI woes. commit d379e553da920cfd8cbccca2f5a03786c8627dc6 Author: Dean Herbert Date: Tue Oct 31 14:31:26 2023 +0900 Fix back-to-front logging commit bdd3f2847b8a27d1e34657297fdc290deeaf1e88 Author: Dean Herbert Date: Tue Oct 31 14:26:00 2023 +0900 Add an extra storyboard sample to avoid intermittent failures in `TestStoryboardSamplesStopOnSkip` Probably CI running slow timing balls. The point of failure is `waitUntilStoryboardSamplesPlay()` after already testing the important part of the test (that the samples stop on skip) so let's give it another possible point to recover. See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701. commit 66b84d02cb1631302631d5b16afd31d0d420a13a Author: Dean Herbert Date: Tue Oct 31 14:20:11 2023 +0900 Add note about `TestGameplayExitFlow` failure, and ignore for now See: https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641 https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419 commit 89444d5544aad8c89be4eff311cd6beeedc1c421 Author: Dean Herbert Date: Tue Oct 31 14:00:49 2023 +0900 Fix export test still occasionally failing due to file write in progress https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074 Basically, `File.Move` may not be an atomic operation. commit 37ec10d4f592ebab514c9a9afc5f9dcb8dce7c2f Author: Dean Herbert Date: Tue Oct 31 13:49:39 2023 +0900 Fix `TestSongSelectScrollHandling` not waiting for `VolumeOverlay` to load See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721. commit fa220d34def142e8f3280dbfe742614a3b41909b Merge: 0ffd5104ef a3dc9a73b1 Author: Dean Herbert Date: Tue Oct 31 13:36:30 2023 +0900 Merge pull request #25272 from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI commit a3dc9a73b19120c0c4ef4ba7199463fb63ad280c Author: Dean Herbert Date: Tue Oct 31 13:35:15 2023 +0900 Revert behaviour changes of `MaxDimensions` test and ignore instead commit 0ffd5104efe347776a9f4334e08dd50c16c822f8 Merge: 3060cf1438 bb6555c901 Author: Dean Herbert Date: Tue Oct 31 13:34:13 2023 +0900 Merge pull request #25274 from frenzibyte/tournament-display-team-seed Support displaying team seeds in tournament client commit bb6555c9011fb98c3b2c49fc8fcea25663c64aec Merge: feeb95e4c3 3060cf1438 Author: Dean Herbert Date: Tue Oct 31 12:45:21 2023 +0900 Merge branch 'master' into tournament-display-team-seed commit feeb95e4c389b85a1e72b1f00d2a79131ecb2652 Author: Dean Herbert Date: Tue Oct 31 12:44:43 2023 +0900 Adjust `DrawableTeamTitleWithHeader` to match new layout commit 87c9df937f85d3f7e9b220c2f21c13caae74b25b Author: Dean Herbert Date: Tue Oct 31 12:40:21 2023 +0900 Move team seed to below team name commit 3060cf1438147203a4333b2caf648bbb0b2d47b8 Merge: 5a1865ed01 06508d08fe Author: Dean Herbert Date: Tue Oct 31 12:14:00 2023 +0900 Merge pull request #25286 from frenzibyte/search-text-box-select-all Automatically select existing search text when opening settings commit 5a1865ed01357e0c110fa1543cc10e3d9c82a746 Merge: f706fd2fca 12ef93ac3b Author: Dean Herbert Date: Tue Oct 31 10:38:12 2023 +0900 Merge pull request #25311 from bdach/spinner-rotation-tracker-incorrect-assertion commit 12ef93ac3b42a86c031c37a9f89e430bf90912b6 Author: Bartłomiej Dach Date: Mon Oct 30 21:31:34 2023 +0100 Remove no-longer-valid assertion commit e5b51f769ce72e7394131df3b993a7a840115984 Author: Bartłomiej Dach Date: Mon Oct 30 21:15:40 2023 +0100 Fix incorrect assertion placement in spinner rotation tracker Checking the delta after the application of rate is not correct. The delta is in screen-space *before* the rate from rate-changing mods were applied; the point of the application of the rate is to compensate for the fact that the spinner is still judged in "track time" - but the goal is to keep the spinner's difficulty *independent* of rate, which means that with DT active the user's spin is "twice as effective" to compensate for the fact that the spinner is twice as short in real time. In another formulation, with DT active, the user gets to record replay frames "half as often" as in normal gameplay. commit f2c0bc821802067e8cb9c7e5bbf64215e6e4fc31 Author: Bartłomiej Dach Date: Mon Oct 30 21:15:04 2023 +0100 Add failing test case commit 06508d08fe1f289404bb20756f43403c209e0d0e Author: Bartłomiej Dach Date: Mon Oct 30 20:22:41 2023 +0100 Delete outdated test commit 88e10dd051d33ca0e63a7cd5f82dac3d9b4e039c Author: Bartłomiej Dach Date: Mon Oct 30 20:03:44 2023 +0100 Update framework commit f706fd2fca126e56883a24d750c694bce17aa532 Merge: 30ffb15868 de89b7e53c Author: Dean Herbert Date: Tue Oct 31 01:44:18 2023 +0900 Merge pull request #25307 from bdach/slider-velocity-undo Fix slider velocity changes not being undone correctly commit 30ffb15868e4ca0dde48fe8c1416c5b4069d544e Merge: fbba3787d1 b2d3aa982d Author: Bartłomiej Dach Date: Mon Oct 30 15:03:21 2023 +0100 Merge pull request #25304 from peppy/fix-click-through-timeline Fix right clicks on timeline potentially not working as expected commit b2d3aa982de80d859f8293c25240df369d4dfd8a Merge: cea24298cb fbba3787d1 Author: Bartłomiej Dach Date: Mon Oct 30 12:52:00 2023 +0100 Merge branch 'master' into fix-click-through-timeline commit cea24298cb99c901077c6e8a23bdfa34da3ceafd Author: Bartłomiej Dach Date: Mon Oct 30 12:42:34 2023 +0100 Privatise setters commit de89b7e53c305c0bf048b3ee42c028775d2da2cd Author: Bartłomiej Dach Date: Mon Oct 30 10:59:02 2023 +0100 Fix slider velocity changes not being undone correctly Closes https://github.com/ppy/osu/issues/25239. `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already supposed to be handling changes to hitobjects that will show up neither when comparing the hitobjects themselves or the timing point with "legacy" info stripped - so, in other words, changes to slider velocity and samples. However, a change to slider velocity requires default application to take effect, so just resetting the value would visually fix the timeline marker but not change the actual object. Calling `EditorBeatmap.Update()` fixes this by way of triggering default re-application. This could probably be smarter (by only invoking the update when strictly necessary, etc.) - but I'm not sure it's worth the hassle. This is intended to be a quick fix, rather than a complete solution - the complete solution would indeed likely entail a wholesale restructuring of the editor's change handling. commit b3369dbb7b188d99f226894924a70339478c21b6 Author: Bartłomiej Dach Date: Mon Oct 30 10:57:48 2023 +0100 Add failing test for slider velocity commit e1ff0d12c66db4c2f16bc5d88fdb568dd5341bf7 Author: Bartłomiej Dach Date: Mon Oct 30 10:55:26 2023 +0100 Update tests to NUnit-style assertions commit 0ed5f274f6e45ea22401a50e905e2a1d3406f170 Author: Bartłomiej Dach Date: Mon Oct 30 10:48:31 2023 +0100 Enable NRT in `TestSceneSliderVelocityAdjust` commit fbba3787d12ea76c35ef2fcb9d1d36f5e98988bc Merge: 8828562512 e949b1f613 Author: Dean Herbert Date: Mon Oct 30 18:25:06 2023 +0900 Merge pull request #25190 from frenzibyte/match-skin-element-animation-support Match capability of animating legacy skin elements with osu!(stable) commit 882856251280947828bb65b626ccba4a88c53377 Merge: 2dc2469507 366e41f111 Author: Dean Herbert Date: Mon Oct 30 18:18:46 2023 +0900 Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox Fix cut and copy not working in song select search filter textbox commit 2dc24695070c8323b3f31ff80a20eddd0047b8a4 Merge: 66fa09ba66 a000c06900 Author: Bartłomiej Dach Date: Mon Oct 30 10:12:27 2023 +0100 Merge pull request #25303 from peppy/last-played-import-score-update Update the last played date of a beatmap when importing a replay by the local user commit 63e6eaf53880e326d43a75efec66134bb36bfe30 Author: Dean Herbert Date: Mon Oct 30 17:55:21 2023 +0900 Fix failing tests commit 57d88a0ac459398a14aafd8923238ce1bc012e7f Author: Dean Herbert Date: Mon Oct 30 17:46:04 2023 +0900 Fix right clicks on timeline objects potentially getting eaten by playfield area `SelectionHandler` is receiving input from anywhere out of necessity: https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs#L119-L125 Also important is that `BlueprintContainer` will selectively not block right clicks to make sure they fall through to the `ContextMenuContainer`: https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs#L122-L126 But because the whole editor is sharing a `ContextMenuContainer` and it's at a higher level than both components, we observe here the playfield's `SelectionHandler` intercepting the right click before it can reach the `ContextMenuContainer`. The fix here is similar to what we're already doing in `TimelineBlueprintContaienr`. commit 6be02966b9e79dfbb94ad372b932decc78ee65f5 Author: Dean Herbert Date: Mon Oct 30 18:06:09 2023 +0900 Add test coverage of failing context menu display commit 39abb8e4085d17bc8ff64a80f19e268a3d4a5b7f Author: Salman Ahmed Date: Mon Oct 30 11:54:19 2023 +0300 Only run "select all on focus" behaviour on desktop platforms commit 66fa09ba6636873eb2f9b152da0557110af95312 Merge: 19d10e5e45 2b24167c47 Author: Dean Herbert Date: Mon Oct 30 17:32:20 2023 +0900 Merge pull request #25287 from frenzibyte/fix-user-profile-support-banners Update user profile overlay to show more than one tournament banner commit a000c069006278ca34e68fdd693dacc3f17d0e6e Merge: 0dfb41b796 19d10e5e45 Author: Bartłomiej Dach Date: Mon Oct 30 09:29:07 2023 +0100 Merge branch 'master' into last-played-import-score-update commit 0dfb41b7966de7823982f3f18b2a5adfa38ac1c4 Author: Bartłomiej Dach Date: Mon Oct 30 09:28:37 2023 +0100 Add test coverage for not updating `LastPlayed` due to newer plays commit 19d10e5e451eea1488c05ebe5ddc51b845baceb9 Merge: 46d1eca0c7 a8c3f59845 Author: Bartłomiej Dach Date: Mon Oct 30 09:04:06 2023 +0100 Merge pull request #25300 from peppy/better-submission-logging Improve log output surrounding score submission commit 46d1eca0c7f96d7bb1cf82202e3556b215ca7b90 Merge: 5ab20f5db7 a91b704d21 Author: Bartłomiej Dach Date: Mon Oct 30 08:42:34 2023 +0100 Merge pull request #25301 from peppy/inspections-bash Fix some new nullable inspections commit 4ae9b40a7806d6637840c25349282f07ef6d66e1 Author: Dean Herbert Date: Mon Oct 30 16:35:14 2023 +0900 Update resources commit caddbacfe8a5a429a6d2e763b2b25cfed7ffb3a5 Merge: 841c5bb4bd 5ab20f5db7 Author: Dean Herbert Date: Mon Oct 30 16:35:10 2023 +0900 Merge branch 'master' into gameplay-hud-redesign/counters commit c1c8e2968f1f620851c4e608043051f07b944d8a Author: Dean Herbert Date: Mon Oct 30 15:46:09 2023 +0900 Move operation to after user population commit 96dd7b3333014cb5e8e404d129b163de1f72f6e8 Author: Dean Herbert Date: Mon Oct 30 15:44:16 2023 +0900 Update the last played date of a beatmap when importing a replay by the local user commit a91b704d21df8adeca8068dd448d2ac9424010c9 Author: Dean Herbert Date: Mon Oct 30 15:10:10 2023 +0900 Fix some new nullable inspections commit a8c3f598457ee9079ba97d2f381f75f7774890dd Author: Dean Herbert Date: Mon Oct 30 15:07:35 2023 +0900 Clean up type display for web requests in logs commit d90f29a5ff4a4618955b7ac7c4e743d39b4aa03a Author: Dean Herbert Date: Mon Oct 30 15:07:26 2023 +0900 Improve log output surrounding score submission commit c7bc8e686543e4fe6e823d06b5d79be144d8ad6e Author: Salman Ahmed Date: Mon Oct 30 06:41:01 2023 +0300 Move behaviour to settings search text box only commit 2b24167c471aa1b0597d76123264d6d4f53f09ec Merge: 984c30ded6 5ab20f5db7 Author: Salman Ahmed Date: Mon Oct 30 06:20:59 2023 +0300 Merge branch 'master' into fix-user-profile-support-banners commit 984c30ded662bc6091c980dc6d6fcf1da880479e Author: Salman Ahmed Date: Mon Oct 30 06:20:13 2023 +0300 Load each tournament banner as soon as it is loaded commit af10dbb76c4b2ab6217655f7b0eeee124acc3635 Author: Salman Ahmed Date: Mon Oct 30 06:19:52 2023 +0300 Add test case with many tournament banners commit 5ab20f5db7eac7853e3e86a5cff06d570a44a9a5 Merge: bb2da97096 204ebfade7 Author: Dean Herbert Date: Mon Oct 30 01:01:33 2023 +0900 Merge pull request #25294 from Frederisk/patch-1 commit 204ebfade7ecaf5a426bfc21a6b89cfa6393fed8 Author: Rowe Wilson Frederisk Holme Date: Sun Oct 29 21:25:15 2023 +0800 Small update to README of Templates commit 922ad80cfc9faf6fd63a0a5f01a266247924c4f8 Author: Salman Ahmed Date: Sun Oct 29 01:44:21 2023 +0300 Update user profile overlay to show more than one tournament banner commit ec9ae12bbd880f2f9a1c31adca3d09e516d0dbb4 Author: Salman Ahmed Date: Sun Oct 29 01:43:49 2023 +0300 Update API response model to accept array of tournament banners commit 31c6973bb646272b3ddcb2b3405d1802c8bf770c Author: Salman Ahmed Date: Sun Oct 29 01:03:45 2023 +0300 Add test coverage commit d877536dc0ec8d1f8f1889be73740a58ef29f869 Author: Salman Ahmed Date: Sun Oct 29 01:03:38 2023 +0300 Select all text content in `SearchTextBox` on focus commit bb2da970964d46e88feae1dd4d8294b6fff40384 Merge: c5ff708c6f c38c8e933a Author: Dean Herbert Date: Sun Oct 29 00:03:00 2023 +0900 Merge pull request #25279 from frenzibyte/tournament-date-text-box-invariant-culture Change tournament date text box parsing to use invariant culture info commit c38c8e933ab0aba67d7a36ccff1413cde465dd8e Author: Salman Ahmed Date: Sat Oct 28 16:52:33 2023 +0300 Change tournament date text box parsing to use invariant culture info commit 366e41f11182c1220b2c8e33bc74172fa7543986 Author: Susko3 Date: Sat Oct 28 12:23:23 2023 +0200 Use local workaround instead of disabling clipboard entirely commit cfc0520481df18553b7252f1f63149ee89e4c9e9 Author: Susko3 Date: Sat Oct 28 12:13:13 2023 +0200 Add failing test commit e76a5f9419276d8eaa8bea22c899fd1aa651c80b Author: Salman Ahmed Date: Sat Oct 28 10:18:15 2023 +0300 Fix failing tests commit 7083c04c5923a9f4494bcdaadfc70de656a33c4d Author: Salman Ahmed Date: Sat Oct 28 09:25:55 2023 +0300 Refactor logic slightly to display team seed everywhere This change makes the team seed display in "team intro" screen as well. commit 81c1634d4453ad31acceaacd48c5d59a868b73a7 Author: Salman Ahmed Date: Sat Oct 28 08:42:40 2023 +0300 Display team seeds in map pool screen as well commit 4371a1ab57a5bfb9549d948121bb15f5b1237ecd Author: Salman Ahmed Date: Sat Oct 28 08:42:29 2023 +0300 Move team seed setting from gameplay screen commit 832e30c31a3e68891c23a5f22ad156a3a6224fc4 Author: Salman Ahmed Date: Sat Oct 28 08:30:59 2023 +0300 Adjust horizontal padding in tournament sprite text commit e2788a22b153ac5763c9d47a3534f719b4fde497 Author: Salman Ahmed Date: Sat Oct 28 08:30:33 2023 +0300 Add setting to configure team seed display commit 28e331deed1c27de3f6177b3fe779bf673cc4b97 Author: Salman Ahmed Date: Sat Oct 28 08:29:46 2023 +0300 Support displaying team seed in `TeamDisplay` commit c5ff708c6fac810921cc14973c6088434cd4e6cc Merge: 4bdd7b2fb8 6526955b09 Author: Salman Ahmed Date: Sat Oct 28 07:32:15 2023 +0300 Merge pull request #25267 from bdach/legacy-font-fixed-width Fix legacy sprite texts not matching stable with respect to fixed width commit a53c0adae077847112830952a025df3de4cdfe68 Author: Salman Ahmed Date: Sat Oct 28 06:56:12 2023 +0300 Remove unused using directive commit 51b7c97cabd8944cc7dfd840ae4a247d42efeca7 Author: Salman Ahmed Date: Sat Oct 28 06:07:49 2023 +0300 Fix `TestScenePlayerMaxDimensions` bottlenecking CI commit 6526955b09ec9cbfd07f6234f2d126c39bdb87a2 Merge: dca5716709 4bdd7b2fb8 Author: Salman Ahmed Date: Sat Oct 28 04:46:30 2023 +0300 Merge branch 'master' into legacy-font-fixed-width commit 4bdd7b2fb88fbece8fa40279030ed6ca533a935c Merge: 5a9d4170e8 bac306879a Author: Salman Ahmed Date: Sat Oct 28 04:16:36 2023 +0300 Merge pull request #25269 from bdach/multiple-skips Exclude video events from being accounted for when calculating storyboard time bounds commit bac306879a4c2965b780c8588f97e95c24e354d0 Author: Salman Ahmed Date: Sat Oct 28 03:18:13 2023 +0300 Minor reword on documentation commit dca57167094aac3c06e4023db346cfd99e00ab54 Merge: 99e590c8dd 5a9d4170e8 Author: Salman Ahmed Date: Sat Oct 28 02:45:23 2023 +0300 Merge branch 'master' into legacy-font-fixed-width commit 9ce2c1f49c37e63d3d6c18b8fb854ee3b4766adf Author: Bartłomiej Dach Date: Fri Oct 27 22:10:03 2023 +0200 Exclude video events from being accounted for when calculating storyboard time bounds Closes https://github.com/ppy/osu/issues/25263. In some circumstances, stable allows skipping twice if a particularly long storyboarded intro is being displayed: https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Player.cs#L1728-L1736 `AllowDoubleSkip` is calculated thus: https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameModes/Play/Player.cs#L1761-L1770 and `leadInTime` is calculated thus: https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameModes/Play/Player.cs#L1342-L1351 The key to watch out for here is `{first,last}EventTime`. `EventManager` will calculate it on-the-fly as it adds storyboard elements: https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameplayElements/Events/EventManager.cs#L253-L256 However, this pathway is only used for sprite, animation, sample, and break events. Video and background events use the following pathway: https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameplayElements/Events/EventManager.cs#L368 Note that this particular overload does not mutate either bound. Which means that for the purposes of determining where a storyboard starts and ends temporally, a video event's start time is essentially ignored. To reflect that, add a clause that excludes video events from calculations of `{Earliest,Latest}EventTime`. commit 2f9b50172e0b0f261a94585d2c525405a77eaa48 Author: Bartłomiej Dach Date: Fri Oct 27 22:09:33 2023 +0200 Add failing test coverage for video events affecting storyboard time bounds commit 99e590c8dd645c58b2fa6197e2f9bd7b003b9e27 Author: Bartłomiej Dach Date: Fri Oct 27 20:10:36 2023 +0200 Fix legacy sprite texts not matching stable with respect to fixed width stable's `pSpriteText` has a `TextConstantSpacing` flag, that is selectively enabled for some usages. In particular, these are: - mania combo counter (not yet implemented) - taiko combo counter (not yet implemented) - score counter - accuracy counter - scoreboard entries (not yet implemented) Everything else uses non-fixed-width fonts. Hilariously, `LegacySpinner` _tried_ to account for this by changing `Font` to have `fixedWidth: false` specified, only to fail to notice that `LegacySpriteText` changes `Font` in its BDL, making the property set do precisely nothing. For this reason, attempting to set `Font` on a `LegacySpriteText` will now throw. commit c9cb0561f7a2ac5117d9add6792e02b53014c1a3 Author: Bartłomiej Dach Date: Fri Oct 27 19:48:10 2023 +0200 Move `maxSizePerGlyph` optional ctor param to init-only property I'm doing this as I'm about to add more similar properties to `LegacySpriteText` and I don't want to create a twenty-argument constructor monstrosity. commit 7a5f3b856f41d3288b2d7940cb9009dabf8d8770 Author: Bartłomiej Dach Date: Fri Oct 27 19:43:49 2023 +0200 Add visual test coverage for displaying hitcircles with high combo index commit 5a9d4170e84739b87e784942682dc9e96b4bef76 Merge: 4ed30342db 32fc19ea0d Author: Dean Herbert Date: Sat Oct 28 02:29:56 2023 +0900 Merge pull request #24794 from bdach/score-encoding-cleanup Correctly handle multiple online score ID types commit 4ed30342dbe00dd6a4b5412a86533426ac212163 Merge: e6445343b0 35f30d6135 Author: Dean Herbert Date: Sat Oct 28 02:29:21 2023 +0900 Merge pull request #25264 from bdach/quick-retry-f-rank Fix quick retry immediately after completion marking score as failed commit e6445343b0e3afddb4479502aacf63f122b4eeb4 Merge: 24b1d1e955 5ad962070c Author: Dean Herbert Date: Sat Oct 28 02:28:54 2023 +0900 Merge pull request #25265 from bdach/skin-editor-freeze Fix skin editor freezing game if opened during active gameplay commit 35f30d6135b29b73b68d861bb68564cc951f1a27 Author: Bartłomiej Dach Date: Fri Oct 27 14:39:58 2023 +0200 Scale back debug assertion The import preparation task can actually be non-null when exiting even if the player hasn't passed: - fail beatmap - click import button to import the failed replay commit 5ad962070c0448b81c8457b8816818b6e6041502 Author: Bartłomiej Dach Date: Fri Oct 27 14:34:30 2023 +0200 Fix skin editor freezing game if opened during active gameplay commit b5cb5380045b0d8be6031cbdffb4a799ac402bd3 Author: Bartłomiej Dach Date: Fri Oct 27 14:23:41 2023 +0200 Add failing test case for skin editor freeze commit 6789a522d6d79d6fd1d4f8c15b9c83b119ab61b1 Author: Bartłomiej Dach Date: Fri Oct 27 14:15:30 2023 +0200 Rename test to distinguish it from test-to-come commit dc7f5cd6edc94275a56b3b5cdb5766c76c84181c Author: Bartłomiej Dach Date: Fri Oct 27 13:30:51 2023 +0200 Add preventive assertions concerning submission flow state commit 2d5b1711f6ffc233ca308153a665d18dcbbccea8 Author: Bartłomiej Dach Date: Fri Oct 27 13:27:48 2023 +0200 Share `!HasPassed` condition commit 32fc19ea0d2515aeab4e84248f6cf67ec7d7de98 Author: Bartłomiej Dach Date: Fri Oct 27 13:22:17 2023 +0200 Fix results screen test failure commit 96d784e06bd6068f09620eaaa45c4766d0da900d Author: Bartłomiej Dach Date: Fri Oct 27 12:39:54 2023 +0200 Delete `ScoreInfo.HasReplay` as no longer needed commit 3944b045ed4582b233066dc714be6075b47482f0 Author: Bartłomiej Dach Date: Fri Oct 27 11:58:02 2023 +0200 Add extra test coverage for marking score as failed commit 86a8ab6db6548d211e5f0e5ff1a4feb4b7a506c1 Author: Bartłomiej Dach Date: Fri Oct 27 11:39:43 2023 +0200 Fix quick retry immediately after completion marking score as failed Closes https://github.com/ppy/osu/issues/25247. The scenario involved here is as follows: 1. User completes beatmap by hitting all notes. 2. `checkScoreCompleted()` determines completion, and calls `progressToResults(withDelay: true)`. 3. `progressToResults()` schedules `resultsDisplayDelegate`, which includes a call to `prepareAndImportScoreAsync()`, a second in the future. 4. User presses quick retry hotkey. This calls `Player.Restart(quickRestart: true)`, which invokes `Player.RestartRequested`, which in turn calls `PlayerLoader.restartRequested(true)`, which in turn causes `PlayerLoader` to make itself current, which means that `Player.OnExiting()` will get called. 5. `Player.OnExiting()` sees that `prepareScoreForDisplayTask` is null (because `prepareAndImportScoreAsync()` - which sets it - is scheduled to happen in the future), and as such assumes that the score did not complete. Thus, it marks the score as failed. 6. `Player.Restart()` after invoking `RestartRequested` calls `PerformExit(false)`, which then will unconditionally call `prepareAndImportScoreAsync()`. But the score has already been marked as failed. The flow above can be described as "convoluted", but I'm not sure I have it in me right now to try and refactor it again. Therefore, to fix, switch the `prepareScoreForDisplayTask` null check in `Player.OnExiting()` to check `GameplayState.HasPassed` instead, as it is not susceptible to the same out-of-order read issue. commit 7140eee870bab0d86ab25c15f3d56dce1b68d627 Author: Bartłomiej Dach Date: Fri Oct 27 11:38:10 2023 +0200 Add failing test coverage for quick retry after completion not changing rank commit f931f4c324f96063a3964fc660daf06d99e657d2 Author: Dean Herbert Date: Fri Oct 27 18:19:44 2023 +0900 Remove reundant interface specification commit 99027485e203d95cff043000b192837dc457e0bc Merge: fc25e24397 24b1d1e955 Author: Dean Herbert Date: Fri Oct 27 18:19:28 2023 +0900 Merge branch 'master' into score-encoding-cleanup commit 24b1d1e9558badb2f1a6cb5dc30a5aa6fc79f41d Author: Dean Herbert Date: Fri Oct 27 18:18:07 2023 +0900 Fix code quality fail commit fc25e24397b5c4da9133b29b93de6d60b957512e Merge: cbb2a0dd70 344bb28469 Author: Dean Herbert Date: Fri Oct 27 18:03:38 2023 +0900 Merge branch 'master' into score-encoding-cleanup commit 344bb284691c8b5c00c8d2ef8a6230df4b9fd97f Merge: f165653e8d fdb81bfa4c Author: Dean Herbert Date: Fri Oct 27 17:07:50 2023 +0900 Merge pull request #25253 from bdach/fix-double-adjustment-application Fix `StopUsingBeatmapClock()` applying adjustments to track it was supposed to stop using commit f165653e8de3532dd427c0886e8a96e27204e212 Merge: 099d5f33fc 8b9b085ef5 Author: Dean Herbert Date: Fri Oct 27 16:53:23 2023 +0900 Merge pull request #25233 from Termincc/FreezeFrame-and-Transform-Compatibility Make FreezeFrame and Transform Incompatible commit 099d5f33fcb6d21df74ccf439c51de15dfc468c9 Merge: 9a0882af69 84102cd51e Author: Dean Herbert Date: Fri Oct 27 15:57:01 2023 +0900 Merge pull request #25227 from frenzibyte/fix-tournament-tests Use current date as default value for tournament date text boxes commit 9a0882af69769199562ac8eb196bd70fb5961b03 Merge: c3e87c506b 2f95e7a284 Author: Dan Balasescu Date: Fri Oct 27 15:50:13 2023 +0900 Merge pull request #25218 from peppy/better-slider-judgement-handling Fix out-of-order judgements when missing a slider head commit fdb81bfa4ca2d9819bb0c252059b7b84919af583 Author: Bartłomiej Dach Date: Thu Oct 26 19:38:41 2023 +0200 Rename methods to not mention "source clock" anymore commit 565ae99e0dfddbecef6bc24828ba6c39c837f5cd Author: Bartłomiej Dach Date: Thu Oct 26 19:27:50 2023 +0200 Fix `StopUsingBeatmapClock()` applying adjustments to track it was supposed to stop using - Closes https://github.com/ppy/osu/issues/25248 - Possibly also closes https://github.com/ppy/osu/issues/20475 Regressed in e33486a766044c17c2f254f5e8df6d72b29c341e. `StopUsingBeatmapClock()` intends to, as the name says, stop operating on the working beatmap clock to yield its usage to other components on exit. As part of that it tries to unapply audio adjustments so that other screens can apply theirs freely instead. However, the aforementioned commit introduced a bug in this. Previously to it, `track` was an alias for the `SourceClock`, which could be mutated in an indirect way via `ChangeSource()` calls. The aforementioned commit made `track` a `readonly` field, initialised in constructor, which would _never_ change value. In particular, it would _always_ be the beatmap track, which meant that `StopUsingBeatmapClock()` would remove the adjustments from the beatmap track, but then at the end of the method, _apply them onto that same track again_. This was only saved by the fact that clock adjustments are removed again on disposal of the `MasterGameplayClockContainer()`. This - due to async disposal pressure - could explain infrequently reported cases wherein the track would just continue to speed up ad infinitum. To fix, fully substitute the beatmap track for a virtual track at the point of calling `StopUsingBeatmapClock()`. commit 0482c05d7c031132a17e5e0fa3e4b605051cd2b4 Author: Bartłomiej Dach Date: Thu Oct 26 19:27:05 2023 +0200 Add failing test case commit c3e87c506b3e24d8d3691e6d90ae958afb435fa8 Merge: a463c37320 7779554360 Author: Salman Ahmed Date: Thu Oct 26 19:27:14 2023 +0300 Merge pull request #25240 from bdach/fix-catch-distance-snap-grid Fix various catch distance snap grid breakage commit 7779554360e59d0a8f814a03eae25ef1ea6b11fb Merge: c51513705a a463c37320 Author: Bartłomiej Dach Date: Thu Oct 26 17:50:15 2023 +0200 Merge branch 'master' into fix-catch-distance-snap-grid commit a463c37320500f20b9330ba53e6355c9e4e090a5 Merge: 3930e41759 2fa2217381 Author: Dean Herbert Date: Fri Oct 27 00:23:47 2023 +0900 Merge pull request #25243 from bdach/song-select-volume-scroll-blocked Fix left side of carousel blocking volume adjust hotkeys commit c51513705ad3131f5a5b6f20a54eeee8f8b8573e Merge: 79910df959 3930e41759 Author: Salman Ahmed Date: Thu Oct 26 17:44:33 2023 +0300 Merge branch 'master' into fix-catch-distance-snap-grid commit 3930e41759d11b09efa4b091dbcd2a18c0dc954d Merge: b078748724 54b69333f0 Author: Salman Ahmed Date: Thu Oct 26 17:43:47 2023 +0300 Merge pull request #25230 from bdach/double-click-disabled-slider Do not revert to default value when double-clicking disabled slider commit 2fa221738184c9ded7f091cea16bf40f4e02765d Author: Bartłomiej Dach Date: Thu Oct 26 16:26:31 2023 +0200 Fix left side of carousel blocking volume adjust hotkeys Closes https://github.com/ppy/osu/issues/25234. A little ad-hoc, but probably fine...? commit 5d6a58d443cf6467bcc72b8db4d36875acbab7bc Author: Bartłomiej Dach Date: Thu Oct 26 16:19:53 2023 +0200 Add failing test scene for scroll handling in song select commit 54b69333f08d6c14536cb7ca5eca19c5f7001611 Merge: 3b9c4c9d53 b078748724 Author: Salman Ahmed Date: Thu Oct 26 17:01:46 2023 +0300 Merge branch 'master' into double-click-disabled-slider commit 79910df9593b8478419b4eb2f4be12b0cfd1dbf8 Author: Bartłomiej Dach Date: Thu Oct 26 15:46:32 2023 +0200 Fix catch distance snap provider not hiding slider properly Regressed in https://github.com/ppy/osu/pull/25171. The old code was kinda dependent on correct order of setting `Disabled`. `CatchHitObjectComposer` would disable distance spacing in its BDL, and then via the base `DistancedHitObjectComposer.LoadComplete()`, the slider would be faded out. The switch to composition broke that ordering. To fix, stop relying on ordering and just respond to changes as they come. That's what bindables are for. commit 359ae3120494d0b9d3b61599d6f50f5abe0330ba Author: Bartłomiej Dach Date: Thu Oct 26 15:40:46 2023 +0200 Fix catch distance snap grid not moving Regressed in https://github.com/ppy/osu/pull/25154. Specifically, in 013b5fa916d819ec7a8a93b1692d4aa027934a67 and 74b86349d58e5169e52bbdc70cef3dec81579a74. A simple case of too-much-code-deleted-itis. commit b078748724ef9628b4144578f9f428ef6492ac05 Merge: 66055aa08c 238e8175ae Author: Bartłomiej Dach Date: Thu Oct 26 15:27:04 2023 +0200 Merge pull request #25235 from peppy/add-ctrl-r-quick-retr Add ability to quick retry using Ctrl-R commit cbb2a0dd70ddce70e2e156be7bac632bbc9b6480 Author: Bartłomiej Dach Date: Thu Oct 26 15:09:59 2023 +0200 Use both score ID types to deduplicate score on solo results screen commit c3e9f5184f504f119867c3745af730c6fafe02de Author: Bartłomiej Dach Date: Thu Oct 26 15:09:34 2023 +0200 Fix `SoloScoreInfo` not copying over legacy score ID when converting to `ScoreInfo` commit 900530080ff7f4c33a19b6107214c80ff4f0f997 Author: Bartłomiej Dach Date: Thu Oct 26 14:56:22 2023 +0200 Make `SoloScoreInfo` implement `IScoreInfo` commit 526ee6e14070a2ba0d09ad544353be52796e698c Author: Bartłomiej Dach Date: Thu Oct 26 14:46:24 2023 +0200 Remove `IScoreInfo : IHasNamedFiles` inheritance commit 66055aa08ca1daddce85ccf5978014913566ad77 Merge: 5e059a362f 4cca70ee19 Author: Bartłomiej Dach Date: Thu Oct 26 14:31:45 2023 +0200 Merge pull request #25236 from peppy/hold-back-sharp-compress Fix iOS AOT compilation failure due to SharpCompress library upgrade commit 238e8175ae3b2ddb8e8b86dc969ddba2225e693f Author: Dean Herbert Date: Thu Oct 26 21:26:26 2023 +0900 Add ability to quick retry using Ctrl-R Matches osu!stable commit 8b9b085ef5422976b6ec9ef8cd11406c235209fc Author: Termincc <112787855+Termincc@users.noreply.github.com> Date: Thu Oct 26 22:15:10 2023 +1000 Address mod incompatibilities Makes FreezeFrame and Transform mods incompatible. commit dbb69419e6d49e6661d31eb22f2445e499e5e742 Author: Bartłomiej Dach Date: Thu Oct 26 12:39:07 2023 +0200 Add test coverage for parsing new online ID commit 3b9c4c9d530eeee26f29a920299b0b363cd7348c Author: Bartłomiej Dach Date: Thu Oct 26 12:04:27 2023 +0200 Do not revert to default value when double-clicking disabled slider Closes https://github.com/ppy/osu/issues/25228. commit 89fec95b016364d2a97a30a1d6cbbbf6e46e19a6 Author: Bartłomiej Dach Date: Thu Oct 26 12:11:25 2023 +0200 Fix cross-test data dependency by recreating slider every time commit 96437c4518a394c2354853b95c5f07853c6340d1 Author: Bartłomiej Dach Date: Thu Oct 26 12:03:35 2023 +0200 Fix tests specifying float precision for double bindable Would cause assignments to `.Value` to become imprecise even if the underlying bindable could represent the value 100% accurately. commit 910d74fdda85433e2cf6b1f62daa3edc4a75f816 Author: Bartłomiej Dach Date: Thu Oct 26 11:59:38 2023 +0200 Add failing test coverage for double-click on disabled sliders commit 4cca70ee1939118d719d5cbecd5b2d109fd07c94 Author: Dean Herbert Date: Thu Oct 26 17:42:28 2023 +0900 Fix iOS AOT compilation failure due to SharpCompress library upgrade commit 841c5bb4bd9d78a2dc191271d3a09a60446c35e6 Author: Salman Ahmed Date: Thu Oct 26 11:04:55 2023 +0300 Add modified skin for serialisation test coverage commit 84102cd51ef34f1cf81b2ae41783807a5f2ebb2d Author: Salman Ahmed Date: Thu Oct 26 10:46:04 2023 +0300 Use current date as default value for tournament date text box commit e949b1f613a3015c4a8ae91a76e87e2229711570 Author: Salman Ahmed Date: Thu Oct 26 10:36:57 2023 +0300 Fix failing tests commit 2ba02416c22b9bcd0283b79e28dcb65a41f414e1 Author: Bartłomiej Dach Date: Thu Oct 26 09:14:59 2023 +0200 Revert test changes fully to clean up diff commit ca4b09f8ef1ce173727f29dffb0ee3ec2612df7c Merge: e2192806e4 5e059a362f Author: Bartłomiej Dach Date: Thu Oct 26 09:04:05 2023 +0200 Merge branch 'master' into score-encoding-cleanup commit 07e7d533bfa211536e199ac92c308cfc6f5bfd45 Author: Salman Ahmed Date: Thu Oct 26 10:01:27 2023 +0300 Bake external scale factors into glyph scale commit e119e045e47a5023531b5d41dfd4ed80fcc5e427 Author: Salman Ahmed Date: Thu Oct 26 09:12:24 2023 +0300 Update "Argon" skin components layout and use the new components commit df80b4dcab1fdda9f120376bfcbbdb26f96ccb1b Author: Salman Ahmed Date: Thu Oct 26 09:11:27 2023 +0300 Update "Argon" health display specifications to match design Also adds a little white bar next to the display to match with the components below it (score/accuracy/combo counters). commit 50af1574cfea82a89933fc7fb969d4a94726a766 Author: Salman Ahmed Date: Thu Oct 26 09:10:56 2023 +0300 Add "Argon" background wedges commit 56eeb117ce2011ad4b80cf32c3b015eb482d7c9b Author: Salman Ahmed Date: Thu Oct 26 09:00:16 2023 +0300 Add "Argon" performance points counter commit daf4a03fd092ac84955a8f63fa3c45200a28cf04 Author: Salman Ahmed Date: Thu Oct 26 08:59:47 2023 +0300 Abstractify PP counter logic from the "Triangles" implementation commit 0aa0562dc0a5b645332c309bac55e7a444eb5c56 Author: Salman Ahmed Date: Thu Oct 26 08:59:04 2023 +0300 Add "Argon" combo counter commit 1f36acca1a6c31f4ca73c487ac63795fd35ddacf Author: Salman Ahmed Date: Thu Oct 26 08:58:47 2023 +0300 Add "Argon" accuracy counter commit 9ca672d689ecf08c5f7c8a08d5e46ada684cac36 Author: Salman Ahmed Date: Mon Oct 23 01:58:41 2023 +0300 Add "Argon" total score counter commit 5e059a362fbdb5f3df1414abaf79a5c89e1a2fa8 Merge: 4c80413551 6934e045df Author: Bartłomiej Dach Date: Wed Oct 25 12:03:26 2023 +0200 Merge pull request #25223 from peppy/prompt-before-save-for-export Fix editor not prompting before saving beatmap for export commit 4c8041355118c9f00f7cbe4d8bf7b61a659747e2 Merge: 9c9000027a 2886d2d4c2 Author: Bartłomiej Dach Date: Wed Oct 25 11:56:52 2023 +0200 Merge pull request #25222 from peppy/update-taiko-argon-barlines Apply same changes to "argon" osu!taiko barline design that were applies to osu!mania commit 9c9000027a58b36c1b1bec7d3767774339721fc9 Merge: 7dd11fc5bf 74f794a549 Author: Bartłomiej Dach Date: Wed Oct 25 11:43:46 2023 +0200 Merge pull request #25221 from peppy/fix-repeat-dim Fix repeat circles on sliders not correctly getting dimmed commit 7dd11fc5bff3c4d4078a746c14941d5ec0ea43c4 Author: Dean Herbert Date: Wed Oct 25 17:55:55 2023 +0900 Fix null check commit 2f95e7a284b0c014c37d41da5a69c01ac0bd4547 Author: Dean Herbert Date: Wed Oct 25 15:44:51 2023 +0900 Add note about implementation being shared commit 6eafb66fdfedac1cae4e0568f81d75bd47ec41d4 Author: Dean Herbert Date: Wed Oct 25 15:44:42 2023 +0900 Fix `DrawableSliderTail` potentially forcing miss on head too early commit 2a075065d8736a5eef561dda9e4768aa8181f043 Merge: a648b32519 da07066a74 Author: Bartłomiej Dach Date: Wed Oct 25 08:31:28 2023 +0200 Merge pull request #25217 from peppy/update-country-codes Update country code names to match database commit a648b325198ee5b9e664771154bb627f3df065a3 Merge: 34505b3933 23ea128f30 Author: Dean Herbert Date: Wed Oct 25 14:45:24 2023 +0900 Merge pull request #25191 from frenzibyte/velocity-based-ball-animation Apply velocity into legacy slider ball animation rate commit 6934e045df2525eeeab800b4c9b543eed8d38256 Author: Dean Herbert Date: Wed Oct 25 14:33:06 2023 +0900 Fix editor not prompting before saving beatmap for export commit 2886d2d4c27a536690dcc5095709112cec117e54 Author: Dean Herbert Date: Wed Oct 25 14:20:43 2023 +0900 Apply same changes to "argon" osu!taiko barline design that were applied to osu!mania commit 74f794a549f2f8b30a1fa1af8a7f9fc24ea9b92d Author: Dean Herbert Date: Wed Oct 25 14:01:55 2023 +0900 Fix repeat circles on sliders not correctly getting dimmed commit 23ea128f306f7a242c9ce986f0b2a2aff442659d Merge: 121fa6f165 34505b3933 Author: Dean Herbert Date: Wed Oct 25 14:01:19 2023 +0900 Merge branch 'master' into velocity-based-ball-animation commit 121fa6f165f504df061b0dc0350fb9e85da78221 Author: Dean Herbert Date: Wed Oct 25 13:53:20 2023 +0900 Simplify pre-checks in `HitObjectApplied` delegate commit da07066a744c6808d00fdaa82e0e0b141e34f9fc Author: Dean Herbert Date: Wed Oct 25 13:03:03 2023 +0900 Add note about `CountryCode` being at parity with `osu_countries` commit d9ec030cc8a2fca7b121d9d5353ea707064af876 Author: Dean Herbert Date: Wed Oct 25 13:02:15 2023 +0900 Remove missing country commit cd8b068f4c42097daa53e3fb19fd4d35eb6b65a1 Author: Dean Herbert Date: Wed Oct 25 13:01:23 2023 +0900 Add fallback case to `CountryExtensions.GetAcronym` commit e79aeea3b04b709a2dcfa362455695318550bbec Author: Dean Herbert Date: Tue Oct 24 18:50:28 2023 +0900 Add test coverage commit 550340790759db6f29c2a18613922503770239fa Author: Dean Herbert Date: Tue Oct 24 18:40:12 2023 +0900 Force miss head when a tick or repeat is successfully judged commit 5eefc5323d8adc308352f46f17a81a3554b22d9b Author: Dean Herbert Date: Tue Oct 24 18:36:45 2023 +0900 Standardise `DrawableSliderRepeat` / `DrawableSliderTick` judgement implementations commit 176cb0dd28b4847bbe59c8ffc1911af0e6f14906 Author: Dean Herbert Date: Tue Oct 24 18:33:35 2023 +0900 Remove unused variable commit 93147a5998efda1c9bf94aa4ae85aec35ff641c8 Author: Dean Herbert Date: Tue Oct 24 18:00:48 2023 +0900 Change slider tail tick to only hold back judgement on ticks/repeats commit 17070707b5fbdbaeef32804b0154e45143f03b3d Author: Dean Herbert Date: Tue Oct 24 14:46:58 2023 +0900 Update and add remaining country codes to match database commit 11c949d09144d57099d1be3fcd725eeaefaa0a8c Author: Dean Herbert Date: Tue Oct 24 14:45:25 2023 +0900 Sort countries alphabetically commit ded99c4097539fde80d0901748a07bce9ba6b31e Author: Dean Herbert Date: Tue Oct 24 14:32:03 2023 +0900 Simplify calculation commit 1591246afbeb9f7e2f503e4359f43adf1913454b Author: Dean Herbert Date: Tue Oct 24 13:53:31 2023 +0900 Update country code names to match database Required for ASS / osu-web cross-compatibility commit bcbb77d3839028edf18535ac7976668c02cc7c6f Author: Salman Ahmed Date: Tue Oct 24 02:29:07 2023 +0300 Fix incorrect assumption in taiko circle piece logic commit ff66b74b0e5ab4f95967f3234a985f0b27e8a718 Author: Salman Ahmed Date: Tue Oct 24 02:24:00 2023 +0300 Refactor logic to support DHO pooling commit 0cf572d0295d26e6b7c842b1bd78000d3683282e Author: Salman Ahmed Date: Mon Oct 23 11:46:21 2023 +0300 Use existing property and fix nullability commit 8ed660d863cc32fe754487ad98dd3140f75669aa Author: Salman Ahmed Date: Mon Oct 23 01:58:25 2023 +0300 Remove incorrect logic commit 12bb4b697c4c58e806cfdb4105940d10db52f657 Author: Salman Ahmed Date: Sun Oct 22 03:27:21 2023 +0300 Support retrieving textures in argon skin from game resources commit 976ae62214a2314f2d2baa1249f6276374327e7e Author: Salman Ahmed Date: Sat Oct 21 01:10:06 2023 +0300 Fix incorrect nullability specification commit ab3b51e4a0a9042d1b20d08d64b2c47b2b6848bb Author: Salman Ahmed Date: Thu Oct 19 14:02:46 2023 +0300 Refactor osu!taiko circle piece logic to read better commit 491f119988f37e6264ccb7ebe3dfe3bb9e9d4b36 Author: Salman Ahmed Date: Wed Oct 18 20:56:17 2023 +0300 Add animation support for legacy osu!mania column lights commit 517d0f65b646daa784423dfdf1aae528f8448aaa Author: Salman Ahmed Date: Sat Oct 21 00:22:29 2023 +0300 Adjust frame length of osu!mania hold-note body animation commit badb1310a38484955250757f78c3103be93d38c2 Author: Salman Ahmed Date: Thu Oct 19 14:00:13 2023 +0300 Adjust frame length of osu!mania judgement animation commit 2a70c331b9f9730c6e775fe3962cf1bf1c1e5fd1 Author: Salman Ahmed Date: Thu Oct 19 14:01:13 2023 +0300 Remove animation support from osu! slider reverse arrow commit 80ce78e05dc2e97947c21520fb9fc7264259a9ea Author: Salman Ahmed Date: Thu Oct 19 13:59:07 2023 +0300 Remove animation support from osu! hit circle overlay commit 7373a9a784ce32d047d3a15eafe0dc946f2179d9 Author: Salman Ahmed Date: Fri Oct 20 23:54:29 2023 +0300 Remove unnecessary usage of `ApplyWithDoubledAlpha` commit ac8c2a173b2a2bedb4ea22fa46f0c7cf56a732e8 Author: Salman Ahmed Date: Fri Oct 20 22:47:45 2023 +0300 Apply velocity into legacy slider ball animation rate commit e2192806e456a90f252f7265fff941b1cabf4f1c Author: Bartłomiej Dach Date: Mon Oct 16 12:00:33 2023 +0200 Use `ID` rather than `SoloScoreID` The latter is apparently not going to be a thing anymore. commit fb2293821ab009304c11be3d4d352ee8aa92debe Author: Bartłomiej Dach Date: Thu Sep 7 11:26:51 2023 +0200 Allow watching replay from multi/playlist results screens commit c4af8591a5952fc760ec967b37153178017d7e27 Author: Bartłomiej Dach Date: Thu Sep 7 09:39:10 2023 +0200 Preserve `OnlineID` when importing scores Previously, for lazer scores, the ID returned from `osu-web` was discarded and replaced with -1, due to the fact that the appropriate structures for unification with stable, as well as unification across solo and multiplayer, were not in place yet. Now we're at the point where scores from all the aforementioned sources receive a `solo_scores` DB row, and as such, we can start treating `solo_scores`-scheme IDs as canonical "online IDs" for a score. commit d5a733d244ba5d5915f3b6370c7dfebb383fc600 Author: Bartłomiej Dach Date: Thu Sep 7 12:32:28 2023 +0200 Use solo score ID as `OnlineID` when converting from `MultiplayerScore` commit b144cfd55c1a5546a42223d3e2de44aecc47c56e Author: Bartłomiej Dach Date: Mon Sep 4 12:21:23 2023 +0200 Add `LegacyOnlineID` handling to places that definitely need it Mostly places that can interact with imported replays. There are other places that use the online ID as a sort tiebreaker, or to check presence of a score on results screens, but they should probably still continue to only use `OnlineID`, since all scores with a legacy online ID should have an online ID, but the converse is not generally true. commit c53f4c144cc109d0b0f710adf39ea31be12a29fb Author: Bartłomiej Dach Date: Fri Sep 1 08:23:29 2023 +0200 Encode/decode new `OnlineID` into/from `LegacyReplaySoloScoreInfo` commit fa519984dfdbb5cff3425f170ba7e8698d5fd318 Author: Bartłomiej Dach Date: Fri Sep 1 08:10:26 2023 +0200 Move legacy online ID encode/decode to legacy property commit bfcb4f4f2d940835eb8e9f42eb620184d4ed877c Author: Bartłomiej Dach Date: Fri Sep 1 08:04:35 2023 +0200 Add failing test for legacy online ID decoding commit c1a817fec607aa2577fab9ebf7223b352020d33e Author: Bartłomiej Dach Date: Fri Sep 1 07:47:07 2023 +0200 Add `LegacyOnlineID` with backwards migration commit c1743dbe1df7994f425d118c19c44ee8ea8c126c Author: Dean Herbert Date: Thu Jun 1 16:53:29 2023 +0900 Select all text when popover is initially shown Depends on https://github.com/ppy/osu-framework/pull/5823. --- .config/dotnet-tools.json | 4 +- osu.Android.props | 2 +- .../TestSceneJuiceStreamSelectionBlueprint.cs | 8 +- .../JuiceStreamPathTest.cs | 4 +- .../Mods/TestSceneCatchModPerfect.cs | 2 +- .../Mods/TestSceneCatchModRelax.cs | 2 +- .../TestSceneAutoJuiceStream.cs | 2 +- .../TestSceneCatchModHidden.cs | 2 +- .../TestSceneDrawableHitObjects.cs | 2 +- .../TestSceneJuiceStream.cs | 2 +- .../Blueprints/Components/EditablePath.cs | 2 +- .../Objects/JuiceStreamPath.cs | 2 +- .../TestSceneOpenEditorTimestampInMania.cs | 94 +++++++++++ .../Edit/ManiaHitObjectComposer.cs | 33 ++++ .../Checks/CheckOffscreenObjectsTest.cs | 12 +- .../Editor/TestSceneObjectMerging.cs | 10 +- .../TestSceneOpenEditorTimestampInOsu.cs | 91 ++++++++++ .../TestSceneOsuEditorSelectInvalidPath.cs | 2 +- .../TestScenePathControlPointVisualiser.cs | 62 ++++--- .../TestSceneSliderControlPointPiece.cs | 28 ++-- .../Editor/TestSceneSliderLengthValidity.cs | 8 +- .../TestSceneSliderPlacementBlueprint.cs | 119 +++++++++---- .../Editor/TestSceneSliderReversal.cs | 4 +- .../TestSceneSliderSelectionBlueprint.cs | 2 +- .../Editor/TestSceneSliderSnapping.cs | 10 +- .../Editor/TestSceneSliderSplitting.cs | 28 ++-- .../Editor/TestSliderScaling.cs | 2 +- .../Mods/TestSceneOsuModHidden.cs | 10 +- .../Mods/TestSceneOsuModPerfect.cs | 2 +- .../OsuHitObjectGenerationUtilsTest.cs | 6 +- .../TestSceneHitCircleLateFade.cs | 2 +- .../TestSceneLegacyHitPolicy.cs | 18 +- .../TestSceneSlider.cs | 14 +- .../TestSceneSliderApplication.cs | 6 +- .../TestSceneSliderFollowCircleInput.cs | 2 +- .../TestSceneSliderInput.cs | 8 +- .../TestSceneSliderSnaking.cs | 6 +- .../TestSceneStartTimeOrderedHitPolicy.cs | 10 +- .../Difficulty/OsuDifficultyAttributes.cs | 4 +- .../Components/PathControlPointPiece.cs | 24 +-- .../Components/PathControlPointVisualiser.cs | 33 ++-- .../Sliders/SliderPlacementBlueprint.cs | 158 +++++++++++++++--- .../Edit/FreehandSliderToolboxGroup.cs | 100 +++++++++++ .../Edit/OsuHitObjectComposer.cs | 42 ++++- .../Edit/OsuSelectionHandler.cs | 4 +- .../Replays/OsuAutoGenerator.cs | 9 +- .../Skinning/Argon/ArgonFollowCircle.cs | 9 +- .../Skinning/Default/DefaultFollowCircle.cs | 9 +- .../Skinning/Legacy/LegacyFollowCircle.cs | 7 +- osu.Game.Rulesets.Taiko/Objects/DrumRoll.cs | 2 +- .../Formats/LegacyBeatmapDecoderTest.cs | 36 ++-- .../Formats/LegacyBeatmapEncoderTest.cs | 33 +++- .../Editing/LegacyEditorBeatmapPatcherTest.cs | 4 +- .../Editing/TestSceneEditorClipboard.cs | 2 +- .../Visual/Editing/TestSceneEditorMenuBar.cs | 22 +-- .../Editing/TestSceneHitObjectComposer.cs | 2 +- .../Editing/TestSceneOpenEditorTimestamp.cs | 151 +++++++++++++++++ .../Gameplay/TestSceneBezierConverter.cs | 42 ++--- .../TestSceneGameplaySampleTriggerSource.cs | 2 +- .../Visual/Gameplay/TestSceneSliderPath.cs | 75 +++++---- .../Beatmaps/Formats/LegacyBeatmapEncoder.cs | 14 +- osu.Game/Database/LegacyBeatmapExporter.cs | 7 +- osu.Game/Graphics/UserInterface/OsuMenu.cs | 30 +++- .../UserInterface/OsuMenuItemSpacer.cs | 13 ++ osu.Game/Localisation/EditorStrings.cs | 10 ++ osu.Game/Online/Chat/MessageFormatter.cs | 7 +- osu.Game/OsuGame.cs | 23 +++ osu.Game/Overlays/SkinEditor/SkinEditor.cs | 10 +- .../SkinEditor/SkinSelectionHandler.cs | 7 +- .../Rulesets/Edit/EditorTimestampParser.cs | 50 ++++++ osu.Game/Rulesets/Edit/HitObjectComposer.cs | 12 ++ osu.Game/Rulesets/Objects/BezierConverter.cs | 52 +++--- .../Objects/Legacy/ConvertHitObjectParser.cs | 25 +-- osu.Game/Rulesets/Objects/SliderPath.cs | 18 +- .../Rulesets/Objects/SliderPathExtensions.cs | 6 +- osu.Game/Rulesets/Objects/Types/PathType.cs | 78 ++++++++- .../Edit/Components/Menus/EditorMenuBar.cs | 27 +-- .../Components/Menus/EditorMenuItemSpacer.cs | 13 -- .../Components/EditorBlueprintContainer.cs | 22 +++ osu.Game/Screens/Edit/Editor.cs | 51 +++++- .../Screens/Play/HUD/ArgonHealthDisplay.cs | 10 +- osu.Game/osu.Game.csproj | 4 +- osu.iOS.props | 2 +- 83 files changed, 1437 insertions(+), 447 deletions(-) create mode 100644 osu.Game.Rulesets.Mania.Tests/Editor/TestSceneOpenEditorTimestampInMania.cs create mode 100644 osu.Game.Rulesets.Osu.Tests/Editor/TestSceneOpenEditorTimestampInOsu.cs create mode 100644 osu.Game.Rulesets.Osu/Edit/FreehandSliderToolboxGroup.cs create mode 100644 osu.Game.Tests/Visual/Editing/TestSceneOpenEditorTimestamp.cs create mode 100644 osu.Game/Graphics/UserInterface/OsuMenuItemSpacer.cs create mode 100644 osu.Game/Rulesets/Edit/EditorTimestampParser.cs delete mode 100644 osu.Game/Screens/Edit/Components/Menus/EditorMenuItemSpacer.cs diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 3cecb0d07cb4..b8dc201559f1 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -21,10 +21,10 @@ ] }, "ppy.localisationanalyser.tools": { - "version": "2023.712.0", + "version": "2023.1117.0", "commands": [ "localisation" ] } } -} \ No newline at end of file +} diff --git a/osu.Android.props b/osu.Android.props index 15553510cbe7..aa993485f3b8 100644 --- a/osu.Android.props +++ b/osu.Android.props @@ -10,7 +10,7 @@ true - + diff --git a/osu.iOS.props b/osu.iOS.props index ef54dd06b4df..b43cb1b3f123 100644 --- a/osu.iOS.props +++ b/osu.iOS.props @@ -23,6 +23,6 @@ iossimulator-x64 - +