[K21] Subtitles from German live broadcasters (ARD, ZDF) temporarly are not displayed #1611

werimail · 2024-07-30T11:31:30Z

Describe the problem

Subtitles from German live broadcasters (ARD, ZDF, etc.) temporarly are not displayed in Kodi 21 (Omega), although selected in the OSD

Possible fix

It shows subtitles available e.g.: "German - Untertitel deutsch (Standard)" but nothing shows when it is turned on.

Steps to reproduce

Steps to reproduce the behavior:

Call up the stream (using PVR IPTV Simple Client etc.)
Enable subtitles via the OSD menu

Debug log

kodi_debug_sub_omega.log

Stream manifest file(s)

Additional info

Here is some additional context or explanation that might help:
Streaming Adresses of German live broadcasters (ZDF):
https://zdf-hls-15.akamaized.net/hls/live/2016498/de/high/master.m3u8

Operating system(s)

Android

Operating system version(s)

LineageOS 20 based on Android for Raspberry Pi 400

InputStream Adaptive version(s)

ISA 21.4.10

Kodi version(s)

Kodi 21

CastagnaIT · 2024-08-01T11:55:40Z

is a know problem of bad segment package pts / selection,
mainly for HLS because pts that come from segment packages are differents form the manifest pts of subtitles

inputstream.adaptive/src/samplereader/SubtitleSampleReader.cpp

Lines 168 to 171 in 22e17ca

    
           //! @todo: startPTS workaround! pts has been taken by substracting the period start 
        
           //! this just to have a lower pts value, but the real problem is in CSession::GetNextSample 
        
           //! that that makes an incorrect comparison of DTSorPTS 
        
           if (CSrvBroker::GetResources().GetTree().GetTreeType() == adaptive::TreeType::HLS)

inputstream.adaptive/src/Session.cpp

Lines 1070 to 1076 in 22e17ca

    
           //!@ todo: DTSorPTS comparison is wrong 
        
           //! currently we are compare audio/video/subtitles 
        
           //! for audio/video the pts/dts come from demuxer, but subtitles use pts from manifest 
        
           //! these values not always are comparable because pts/dts that come from demuxer packet data 
        
           //! can be different and makes this package selection ineffective 
        
           //! see also workaround on CSubtitleSampleReader::ReadSample 
        
           if (!res || streamReader->DTSorPTS() < res->GetReader()->DTSorPTS())

this bug influence also this value

inputstream.adaptive/src/main.h

Lines 67 to 69 in 22e17ca

    
           // The last PTS of the segment package fed to kodi. 
        
           // NO_PTS_VALUE only when playback starts or a new period starts 
        
           std::atomic<uint64_t> m_lastPts{PLAYLIST::NO_PTS_VALUE};

used to seek subtitle stream when re-enabled
then when you turn off/on subtitle happens bad behaviours with segments

a good solution require not easy changes on more components
from my part atm i have no time
thing to do in a future or by someonelse

PS. attach hundred of files in a Issue thread is nonsense, compress all them in a single file

werimail added the Triage: Needed (managed by bot) issue that was just created and needs someone looking at it label Jul 30, 2024

CastagnaIT added Triage: Confirmed issue has been reproduced by a team member and removed Triage: Needed (managed by bot) issue that was just created and needs someone looking at it labels Aug 1, 2024

CastagnaIT added the Component: HLS label Aug 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[K21] Subtitles from German live broadcasters (ARD, ZDF) temporarly are not displayed #1611

[K21] Subtitles from German live broadcasters (ARD, ZDF) temporarly are not displayed #1611

werimail commented Jul 30, 2024 •

edited

Loading

CastagnaIT commented Aug 1, 2024 •

edited

Loading

[K21] Subtitles from German live broadcasters (ARD, ZDF) temporarly are not displayed #1611

[K21] Subtitles from German live broadcasters (ARD, ZDF) temporarly are not displayed #1611

Comments

werimail commented Jul 30, 2024 • edited Loading

Describe the problem

Possible fix

Steps to reproduce

Debug log

Stream manifest file(s)

Additional info

Operating system(s)

Operating system version(s)

InputStream Adaptive version(s)

Kodi version(s)

CastagnaIT commented Aug 1, 2024 • edited Loading

werimail commented Jul 30, 2024 •

edited

Loading

CastagnaIT commented Aug 1, 2024 •

edited

Loading