Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in ocp-browser, the ocamldoc showing for Cryptokit.hash_channel is the one for hash_string #3

Closed
UnixJunkie opened this issue Sep 6, 2017 · 5 comments
Closed

in ocp-browser, the ocamldoc showing for Cryptokit.hash_channel is the one for hash_string #3

UnixJunkie opened this issue Sep 6, 2017 · 5 comments

Comments

@UnixJunkie
Copy link
Contributor

I have opam pinned cryptokit to the master git branch.
I don't know where this problem comes from.
I checked the related ocamldoc string, it looks correct.
I wonder if other users experience that too.
@UnixJunkie
Copy link
Contributor Author

@dbuenzli you might have an idea. I think there is a bug somewhere and it is documentation related.

@UnixJunkie
Copy link
Contributor Author

I have ocp-index.1.1.5 and ocaml 4.04.1.

@UnixJunkie
Copy link
Contributor Author

I think versions of ocp-index that were shipping with older compilers like 4.01.0 were not affected.

@dbuenzli
Copy link

dbuenzli commented Sep 8, 2017

I think there's a doc string attachement problem here in cryptokit.mli, a newline is needed. The rules became stricter when ocaml/ocaml#149 was pulled in.

@xavierleroy
Copy link
Owner

Fixed in commit [master 8ba4083]. Thanks @dbuenzli for debugging this issue.

@UnixJunkie UnixJunkie mentioned this issue Sep 11, 2017
Merged
@dbuenzli dbuenzli mentioned this issue Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbuenzli @UnixJunkie @xavierleroy