Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject #416

Merged
merged 15 commits into from
Mar 10, 2024
Merged

Use pyproject #416

merged 15 commits into from
Mar 10, 2024

Conversation

raybellwaves
Copy link
Member

@raybellwaves raybellwaves commented Mar 10, 2024

Just some repo health updates

  • Got rid of setup.py and setup.cfg and moved to pyproject.toml
  • Got rid of black, isort and flake8 and moved to ruff
  • Removed numpy and scipy licenses (probably from my first ever PR. Don't think they're needed)
  • Simplified version by just using a string. (can't see this repo having frequent updates that it's a problem that we forget)
  • Fixed some typing using Optional
  • Fixed readthedocs build
  • Changed publish to use build

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (80be142) to head (d4422cf).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   94.73%   94.76%   +0.02%     
==========================================
  Files          26       27       +1     
  Lines        2794     2810      +16     
==========================================
+ Hits         2647     2663      +16     
  Misses        147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Mar 10, 2024

Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-10 21:18:23 UTC

@raybellwaves raybellwaves merged commit 27e812e into xarray-contrib:main Mar 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants